<div dir="ltr">Could you just merge these four changes in a single patch?<br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Apr 12, 2018 at 1:51 PM Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Since these are mechanical changes, I'll review and give LGTM.<br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Apr 12, 2018 at 1:49 PM Grang, Mandeep Singh <<a href="mailto:mgrang@codeaurora.org" target="_blank">mgrang@codeaurora.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
@ruiu @rksimon These 4 are the last remaining patches pending review
and merge. Is it possible for you to review them?<br>
<a class="m_-5822675098003441187m_-5210510445524835779moz-txt-link-freetext" href="https://reviews.llvm.org/D45142" target="_blank">https://reviews.llvm.org/D45142</a><br>
<a class="m_-5822675098003441187m_-5210510445524835779moz-txt-link-freetext" href="https://reviews.llvm.org/D45139" target="_blank">https://reviews.llvm.org/D45139</a><br>
<a class="m_-5822675098003441187m_-5210510445524835779moz-txt-link-freetext" href="https://reviews.llvm.org/D45138" target="_blank">https://reviews.llvm.org/D45138</a><br>
<a class="m_-5822675098003441187m_-5210510445524835779moz-txt-link-freetext" href="https://reviews.llvm.org/D45137" target="_blank">https://reviews.llvm.org/D45137</a><br>
<br>
--Mandeep<br>
<br>
<div class="m_-5822675098003441187m_-5210510445524835779moz-cite-prefix">On 4/9/2018 3:34 PM, Grang, Mandeep
Singh wrote:<br>
</div>
<blockquote type="cite">
<br>
<div class="m_-5822675098003441187m_-5210510445524835779moz-cite-prefix">On 4/9/2018 3:16 PM, Rui Ueyama
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">
<div dir="ltr">On Mon, Apr 9, 2018 at 3:13 PM Mandeep Singh
Grang via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">mgrang
added a comment.<br>
<br>
In <a href="https://reviews.llvm.org/D45138#1062213" rel="noreferrer" target="_blank">https://reviews.llvm.org/D45138#1062213</a>,
@ruiu wrote:<br>
<br>
> I'm not familiar with r327219, but if a decision to
use randomized sort has been made, why don't you replace
all occurrences of std::sort with llvm::sort in a single
patch? I don't think that an author of each file don't
have to understand this kind of change and approve
individually.<br>
<br>
<br>
I had a patch to replace *all* occurrences of std::sort to
llvm::sort <a href="https://reviews.llvm.org/D44363" rel="noreferrer" target="_blank">https://reviews.llvm.org/D44363</a>.
However, the reviewers felt that the patch was getting too
big and suggested splitting it into smaller patches
target-wise, tablegen, MC, etc. Hence these separate
patches.<br>
</blockquote>
<div><br>
</div>
<div>If the only reason not to submit them as a single patch
is its size, I can actually approve. As long as it is a
mechanical patch, I'm not worried too much about its size.</div>
</div>
</div>
</blockquote>
Adding @rksimon since he has been reviewing my patches. Is it OK
if I squash the remaining 4 patches (<span class="m_-5822675098003441187m_-5210510445524835779phui-oi-objname" style="color:rgb(0,0,0);font-weight:700;font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">D45142</span><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:700;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;display:inline!important;float:none"><span> </span></span><span class="m_-5822675098003441187m_-5210510445524835779phui-oi-objname" style="color:rgb(0,0,0);font-weight:700;font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">D45139</span><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:700;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;display:inline!important;float:none"><span> </span></span><span class="m_-5822675098003441187m_-5210510445524835779phui-oi-objname" style="color:rgb(0,0,0);font-weight:700;font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">D45138</span><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:700;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;display:inline!important;float:none"><span> </span></span><span class="m_-5822675098003441187m_-5210510445524835779phui-oi-objname" style="color:rgb(0,0,0);font-weight:700;font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">D45137</span><span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:700;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:nowrap;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;display:inline!important;float:none"><span></span></span>)
into one and push them as a single patch?<br>
</blockquote>
<br>
</div>
</blockquote></div></blockquote></div>