<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Agree about moving it to Support.<div class="">Also I'll revert the change made to lib/LTO/LLVMBuild.txt<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 12, 2018, at 10:32 AM, Benjamin Kramer <<a href="mailto:benny.kra@gmail.com" class="">benny.kra@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I removed the one on ObjectMemoryBuffer again. Making LTO depend on MCJIT isn't right, the right fix would be to move ObjectMemoryBuffer to Support.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Apr 12, 2018 at 1:20 PM Weiming Zhao via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: weimingz<br class="">
Date: Wed Apr 11 16:09:20 2018<br class="">
New Revision: 329861<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329861&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=329861&view=rev</a><br class="">
Log:<br class="">
Add missing vtable anchors<br class="">
<br class="">
Summary: This patch adds anchor() for MemoryBuffer, raw_fd_ostream, RTDyldMemoryManager, SectionMemoryManager, etc.<br class="">
<br class="">
Reviewers: jlebar, eli.friedman, dblaikie<br class="">
<br class="">
Reviewed By: dblaikie<br class="">
<br class="">
Subscribers: mehdi_amini, mgorny, dblaikie, weimingz, llvm-commits<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D45244" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D45244</a><br class="">
<br class="">
Modified:<br class="">
llvm/trunk/include/llvm/ExecutionEngine/ObjectMemoryBuffer.h<br class="">
llvm/trunk/include/llvm/ExecutionEngine/RTDyldMemoryManager.h<br class="">
llvm/trunk/include/llvm/ExecutionEngine/SectionMemoryManager.h<br class="">
llvm/trunk/include/llvm/Support/MemoryBuffer.h<br class="">
llvm/trunk/include/llvm/Support/raw_ostream.h<br class="">
llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp<br class="">
llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h<br class="">
llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp<br class="">
llvm/trunk/lib/ExecutionEngine/SectionMemoryManager.cpp<br class="">
llvm/trunk/lib/LTO/LLVMBuild.txt<br class="">
llvm/trunk/lib/Support/MemoryBuffer.cpp<br class="">
llvm/trunk/lib/Support/raw_ostream.cpp<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/ExecutionEngine/ObjectMemoryBuffer.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/ObjectMemoryBuffer.h?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/ObjectMemoryBuffer.h?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/ExecutionEngine/ObjectMemoryBuffer.h (original)<br class="">
+++ llvm/trunk/include/llvm/ExecutionEngine/ObjectMemoryBuffer.h Wed Apr 11 16:09:20 2018<br class="">
@@ -56,6 +56,7 @@ public:<br class="">
private:<br class="">
SmallVector<char, 0> SV;<br class="">
std::string BufferName;<br class="">
+ void anchor() override;<br class="">
};<br class="">
<br class="">
} // namespace llvm<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/ExecutionEngine/RTDyldMemoryManager.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RTDyldMemoryManager.h?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RTDyldMemoryManager.h?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/ExecutionEngine/RTDyldMemoryManager.h (original)<br class="">
+++ llvm/trunk/include/llvm/ExecutionEngine/RTDyldMemoryManager.h Wed Apr 11 16:09:20 2018<br class="">
@@ -47,6 +47,9 @@ public:<br class="">
/// newly loaded object.<br class="">
virtual void notifyObjectLoaded(ExecutionEngine *EE,<br class="">
const object::ObjectFile &) {}<br class="">
+<br class="">
+private:<br class="">
+ void anchor() override;<br class="">
};<br class="">
<br class="">
// RuntimeDyld clients often want to handle the memory management of<br class="">
@@ -142,6 +145,9 @@ protected:<br class="">
};<br class="">
typedef std::vector<EHFrame> EHFrameInfos;<br class="">
EHFrameInfos EHFrames;<br class="">
+<br class="">
+private:<br class="">
+ void anchor() override;<br class="">
};<br class="">
<br class="">
// Create wrappers for C Binding types (see CBindingWrapping.h).<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/ExecutionEngine/SectionMemoryManager.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/SectionMemoryManager.h?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/SectionMemoryManager.h?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/ExecutionEngine/SectionMemoryManager.h (original)<br class="">
+++ llvm/trunk/include/llvm/ExecutionEngine/SectionMemoryManager.h Wed Apr 11 16:09:20 2018<br class="">
@@ -182,6 +182,8 @@ private:<br class="">
std::error_code applyMemoryGroupPermissions(MemoryGroup &MemGroup,<br class="">
unsigned Permissions);<br class="">
<br class="">
+ void anchor() override;<br class="">
+<br class="">
MemoryGroup CodeMem;<br class="">
MemoryGroup RWDataMem;<br class="">
MemoryGroup RODataMem;<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/Support/MemoryBuffer.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/MemoryBuffer.h?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/MemoryBuffer.h?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/Support/MemoryBuffer.h (original)<br class="">
+++ llvm/trunk/include/llvm/Support/MemoryBuffer.h Wed Apr 11 16:09:20 2018<br class="">
@@ -148,6 +148,9 @@ public:<br class="">
virtual BufferKind getBufferKind() const = 0;<br class="">
<br class="">
MemoryBufferRef getMemBufferRef() const;<br class="">
+<br class="">
+private:<br class="">
+ virtual void anchor();<br class="">
};<br class="">
<br class="">
/// This class is an extension of MemoryBuffer, which allows copy-on-write<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/Support/raw_ostream.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/raw_ostream.h?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/raw_ostream.h?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/Support/raw_ostream.h (original)<br class="">
+++ llvm/trunk/include/llvm/Support/raw_ostream.h Wed Apr 11 16:09:20 2018<br class="">
@@ -329,6 +329,8 @@ private:<br class="">
/// Copy data into the buffer. Size must not be greater than the number of<br class="">
/// unused bytes in the buffer.<br class="">
void copy_to_buffer(const char *Ptr, size_t Size);<br class="">
+<br class="">
+ virtual void anchor();<br class="">
};<br class="">
<br class="">
/// An abstract base class for streams implementations that also support a<br class="">
@@ -336,6 +338,7 @@ private:<br class="">
/// but needs to patch in a header that needs to know the output size.<br class="">
class raw_pwrite_stream : public raw_ostream {<br class="">
virtual void pwrite_impl(const char *Ptr, size_t Size, uint64_t Offset) = 0;<br class="">
+ void anchor() override;<br class="">
<br class="">
public:<br class="">
explicit raw_pwrite_stream(bool Unbuffered = false)<br class="">
@@ -383,6 +386,8 @@ class raw_fd_ostream : public raw_pwrite<br class="">
/// Set the flag indicating that an output error has been encountered.<br class="">
void error_detected(std::error_code EC) { this->EC = EC; }<br class="">
<br class="">
+ void anchor() override;<br class="">
+<br class="">
public:<br class="">
/// Open the specified file for writing. If an error occurs, information<br class="">
/// about the error is put into EC, and the stream should be immediately<br class="">
<br class="">
Modified: llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp (original)<br class="">
+++ llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp Wed Apr 11 16:09:20 2018<br class="">
@@ -28,6 +28,8 @@<br class="">
<br class="">
using namespace llvm;<br class="">
<br class="">
+void llvm::ObjectMemoryBuffer::anchor() {}<br class="">
+<br class="">
namespace {<br class="">
<br class="">
static struct RegisterJIT {<br class="">
@@ -665,3 +667,5 @@ LinkingSymbolResolver::findSymbol(const<br class="">
return nullptr;<br class="">
return ClientResolver->findSymbol(Name);<br class="">
}<br class="">
+<br class="">
+void LinkingSymbolResolver::anchor() {}<br class="">
<br class="">
Modified: llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h (original)<br class="">
+++ llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h Wed Apr 11 16:09:20 2018<br class="">
@@ -42,6 +42,7 @@ public:<br class="">
private:<br class="">
MCJIT &ParentEngine;<br class="">
std::shared_ptr<LegacyJITSymbolResolver> ClientResolver;<br class="">
+ void anchor() override;<br class="">
};<br class="">
<br class="">
// About Module states: added->loaded->finalized.<br class="">
<br class="">
Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp (original)<br class="">
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp Wed Apr 11 16:09:20 2018<br class="">
@@ -298,4 +298,6 @@ void *RTDyldMemoryManager::getPointerToN<br class="">
return (void*)Addr;<br class="">
}<br class="">
<br class="">
+void RTDyldMemoryManager::anchor() {}<br class="">
+void MCJITMemoryManager::anchor() {}<br class="">
} // namespace llvm<br class="">
<br class="">
Modified: llvm/trunk/lib/ExecutionEngine/SectionMemoryManager.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/SectionMemoryManager.cpp?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/SectionMemoryManager.cpp?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/ExecutionEngine/SectionMemoryManager.cpp (original)<br class="">
+++ llvm/trunk/lib/ExecutionEngine/SectionMemoryManager.cpp Wed Apr 11 16:09:20 2018<br class="">
@@ -232,6 +232,8 @@ SectionMemoryManager::~SectionMemoryMana<br class="">
<br class="">
SectionMemoryManager::MemoryMapper::~MemoryMapper() {}<br class="">
<br class="">
+void SectionMemoryManager::anchor() {}<br class="">
+<br class="">
namespace {<br class="">
// Trivial implementation of SectionMemoryManager::MemoryMapper that just calls<br class="">
// into sys::Memory.<br class="">
<br class="">
Modified: llvm/trunk/lib/LTO/LLVMBuild.txt<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LLVMBuild.txt?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/LTO/LLVMBuild.txt?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/LTO/LLVMBuild.txt (original)<br class="">
+++ llvm/trunk/lib/LTO/LLVMBuild.txt Wed Apr 11 16:09:20 2018<br class="">
@@ -37,3 +37,4 @@ required_libraries =<br class="">
Support<br class="">
Target<br class="">
TransformUtils<br class="">
+ MCJIT<br class="">
<br class="">
Modified: llvm/trunk/lib/Support/MemoryBuffer.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/MemoryBuffer.cpp?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/MemoryBuffer.cpp?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/Support/MemoryBuffer.cpp (original)<br class="">
+++ llvm/trunk/lib/Support/MemoryBuffer.cpp Wed Apr 11 16:09:20 2018<br class="">
@@ -531,3 +531,5 @@ MemoryBufferRef MemoryBuffer::getMemBuff<br class="">
StringRef Identifier = getBufferIdentifier();<br class="">
return MemoryBufferRef(Data, Identifier);<br class="">
}<br class="">
+<br class="">
+void MemoryBuffer::anchor() {}<br class="">
<br class="">
Modified: llvm/trunk/lib/Support/raw_ostream.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/raw_ostream.cpp?rev=329861&r1=329860&r2=329861&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/raw_ostream.cpp?rev=329861&r1=329860&r2=329861&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/Support/raw_ostream.cpp (original)<br class="">
+++ llvm/trunk/lib/Support/raw_ostream.cpp Wed Apr 11 16:09:20 2018<br class="">
@@ -474,6 +474,8 @@ raw_ostream &raw_ostream::indent(unsigne<br class="">
return *this;<br class="">
}<br class="">
<br class="">
+void raw_ostream::anchor() {}<br class="">
+<br class="">
//===----------------------------------------------------------------------===//<br class="">
// Formatted Output<br class="">
//===----------------------------------------------------------------------===//<br class="">
@@ -727,6 +729,8 @@ bool raw_fd_ostream::has_colors() const<br class="">
return sys::Process::FileDescriptorHasColors(FD);<br class="">
}<br class="">
<br class="">
+void raw_fd_ostream::anchor() {}<br class="">
+<br class="">
//===----------------------------------------------------------------------===//<br class="">
// outs(), errs(), nulls()<br class="">
//===----------------------------------------------------------------------===//<br class="">
@@ -804,3 +808,5 @@ uint64_t raw_null_ostream::current_pos()<br class="">
<br class="">
void raw_null_ostream::pwrite_impl(const char *Ptr, size_t Size,<br class="">
uint64_t Offset) {}<br class="">
+<br class="">
+void raw_pwrite_stream::anchor() {}<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>