<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hm, debug_ranges grows by 0.4%, but this didn't increase anything else. The total size of the dsym's DWARF segment increases by 0.08%. That seems like an acceptable overhead.<div class=""><br class=""></div><div class="">vedant<br class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 10, 2018, at 7:13 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">0.6% increase to debug_line (assuming you checked & this didn't increase anything else? Can't see how it could, but just checking - /maybe/ some inlining/debug_ranges stuff?) seems acceptable to me.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, Apr 10, 2018 at 6:37 PM Adrian Prantl via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">aprantl added a comment.<br class="">
<br class="">
I'm fine with this change since the result is more accurate than before (where the instruction would inherit whatever the previous instruction's location was.<br class="">
<br class="">
David: how do you feel about the size increase, since you brought that up?<br class="">
<br class="">
<br class="">
<br class="">
================<br class="">
Comment at: include/llvm/IR/DebugInfoMetadata.h:1512<br class="">
+ /// is true, we will set the merged debug location as line 0 of the nearest<br class="">
+ /// common scope where 2 locations are inlined from.<br class="">
+ //<br class="">
----------------<br class="">
`... common scope the the two locations.`<br class="">
<br class="">
<br class="">
<a href="https://reviews.llvm.org/D45396" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D45396</a><br class="">
<br class="">
<br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></body></html>