<div dir="ltr">I realize it's non-trivial to keep these all in the same list - but I'd rather not create a new list only to remove it again later if it can be helped. What particular issues did you encounter when attempting to use a single list?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Apr 11, 2018 at 7:17 AM Hsiangkai Wang via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">HsiangKai updated this revision to Diff 142000.<br>
HsiangKai added a comment.<br>
<br>
Add DILabel list to DISubprogram. The new DISubprogram will be<br>
<br>
DISubprogram(..., variables: !7, labels: !8)<br>
<br>
To maintain all local entities of the function in one list is not trivial modification. I think it should not relate to label debugging. The refactoring of these lists into one should be another patch.<br>
<br>
So, to enable label debugging, I use a separate list to maintain labels in the function. I add a test case in <a href="https://reviews.llvm.org/D45045" rel="noreferrer" target="_blank">https://reviews.llvm.org/D45045</a> under Clang repo.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D45024" rel="noreferrer" target="_blank">https://reviews.llvm.org/D45024</a><br>
<br>
Files:<br>
  include/llvm/Analysis/TargetTransformInfoImpl.h<br>
  include/llvm/Bitcode/LLVMBitCodes.h<br>
  include/llvm/IR/DIBuilder.h<br>
  include/llvm/IR/DebugInfoMetadata.h<br>
  include/llvm/IR/InstVisitor.h<br>
  include/llvm/IR/IntrinsicInst.h<br>
  include/llvm/IR/Intrinsics.td<br>
  include/llvm/IR/Metadata.def<br>
  lib/Analysis/ObjCARCInstKind.cpp<br>
  lib/Analysis/ValueTracking.cpp<br>
  lib/AsmParser/LLParser.cpp<br>
  lib/Bitcode/Reader/MetadataLoader.cpp<br>
  lib/Bitcode/Writer/BitcodeWriter.cpp<br>
  lib/CodeGen/IntrinsicLowering.cpp<br>
  lib/IR/AsmWriter.cpp<br>
  lib/IR/DIBuilder.cpp<br>
  lib/IR/DebugInfoMetadata.cpp<br>
  lib/IR/LLVMContextImpl.h<br>
  lib/IR/Verifier.cpp<br>
  lib/Transforms/Utils/Local.cpp<br>
  lib/Transforms/Utils/SimplifyCFG.cpp<br>
  test/DebugInfo/Generic/debug-label-bitcode.ll<br>
<br>
</blockquote></div>