<div dir="ltr"><div><div>Interesting...<br></div>It should have broken anything. I am going to investigate on why that happened.<br><br></div>Thanks for reverting it.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 9, 2018 at 2:56 PM, Hans Wennborg via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This broke tests on Windows, e.g.<br>
<a href="http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/11251" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-x86-windows-<wbr>msvc2015/builds/11251</a><br>
<br>
Interestingly it didn't break all bots; e.g. not<br>
<a href="http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9936" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-x64-ninja-win7/<wbr>builds/9936</a><br>
<br>
Maybe it's a floating-point rounding thing?<br>
<br>
Reverted in r329569.<br>
<div class="HOEnZb"><div class="h5"><br>
On Fri, Apr 6, 2018 at 5:30 PM, Andrea Di Biagio via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: adibiagio<br>
> Date: Fri Apr 6 08:30:02 2018<br>
> New Revision: 329403<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329403&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=329403&view=rev</a><br>
> Log:<br>
> [llvm-mca] Do not separate iterations with a newline in the timeline view.<br>
><br>
> Also, update a few tests to minimize the diff in D45369.<br>
> No functional change intended.<br>
><br>
> Modified:<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/CortexA57/direct-<wbr>branch.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/direct-<wbr>branch.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/scheduler-<wbr>queue-usage.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/dot-product.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/pipes-fpu.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>1.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>2.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>3.s<br>
> llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>4.s<br>
> llvm/trunk/tools/llvm-mca/<wbr>TimelineView.cpp<br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/CortexA57/direct-<wbr>branch.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/AArch64/CortexA57/direct-branch.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/AArch64/CortexA57/<wbr>direct-branch.s?rev=329403&r1=<wbr>329402&r2=329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/CortexA57/direct-<wbr>branch.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/CortexA57/direct-<wbr>branch.s Fri Apr 6 08:30:02 2018<br>
> @@ -1,4 +1,4 @@<br>
> -# RUN: llvm-mca -march=aarch64 -mcpu=cortex-a57 -iterations=600 -timeline < %s | FileCheck %s<br>
> +# RUN: llvm-mca -march=aarch64 -mcpu=cortex-a57 -iterations=600 -timeline -timeline-max-iterations=4 < %s | FileCheck %s<br>
><br>
> b t<br>
><br>
> @@ -42,13 +42,12 @@<br>
><br>
><br>
> # CHECK: Timeline view:<br>
> -# CHECK-NEXT: 012<br>
> -# CHECK-NEXT: Index 0123456789<br>
> +# CHECK: Index 0123456<br>
><br>
> -# CHECK: [0,0] DeER . . . b t<br>
> -# CHECK: [1,0] D=eER. . . b t<br>
> -# CHECK: [2,0] D==eER . . b t<br>
> -# CHECK: [3,0] .D==eER . . b t<br>
> +# CHECK: [0,0] DeER .. b t<br>
> +# CHECK-NEXT: [1,0] D=eER.. b t<br>
> +# CHECK-NEXT: [2,0] D==eER. b t<br>
> +# CHECK-NEXT: [3,0] .D==eER b t<br>
><br>
><br>
> # CHECK: Average Wait times (based on the timeline view):<br>
> @@ -58,4 +57,4 @@<br>
> # CHECK-NEXT: [3]: Average time elapsed from WB until retire stage<br>
><br>
> # CHECK: [0] [1] [2] [3]<br>
> -# CHECK-NEXT: 0. 10 4.3 4.3 0.0 b t<br>
> +# CHECK-NEXT: 0. 4 2.2 2.2 0.0 b t<br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/direct-<wbr>branch.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/AArch64/Exynos/direct-branch.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/AArch64/Exynos/<wbr>direct-branch.s?rev=329403&r1=<wbr>329402&r2=329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/direct-<wbr>branch.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/direct-<wbr>branch.s Fri Apr 6 08:30:02 2018<br>
> @@ -1,5 +1,5 @@<br>
> -# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m3 -iterations=300 -timeline < %s | FileCheck %s -check-prefix=ALL -check-prefix=M3<br>
> -# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m1 -iterations=300 -timeline < %s | FileCheck %s -check-prefix=ALL -check-prefix=M1<br>
> +# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m3 -iterations=300 -timeline -timeline-max-iterations=3 -resource-pressure=false < %s | FileCheck %s -check-prefix=ALL -check-prefix=M3<br>
> +# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m1 -iterations=300 -timeline -timeline-max-iterations=3 -resource-pressure=false < %s | FileCheck %s -check-prefix=ALL -check-prefix=M1<br>
><br>
> b t<br>
><br>
> @@ -34,4 +34,4 @@<br>
> # ALL-NEXT: [3]: Average time elapsed from WB until retire stage<br>
><br>
> # ALL: [0] [1] [2] [3]<br>
> -# ALL-NEXT: 0. 10 0.0 0.0 0.0 b t<br>
> +# ALL-NEXT: 0. 3 0.0 0.0 0.0 b t<br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/scheduler-<wbr>queue-usage.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/AArch64/Exynos/scheduler-queue-usage.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/AArch64/Exynos/<wbr>scheduler-queue-usage.s?rev=<wbr>329403&r1=329402&r2=329403&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/scheduler-<wbr>queue-usage.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/AArch64/Exynos/scheduler-<wbr>queue-usage.s Fri Apr 6 08:30:02 2018<br>
> @@ -1,5 +1,5 @@<br>
> -# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m3 -iterations=1 -verbose < %s | FileCheck %s -check-prefix=ALL<br>
> -# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m1 -iterations=1 -verbose < %s | FileCheck %s -check-prefix=ALL<br>
> +# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m3 -iterations=1 -verbose -resource-pressure=false -instruction-info=false < %s | FileCheck %s -check-prefix=ALL<br>
> +# RUN: llvm-mca -march=aarch64 -mcpu=exynos-m1 -iterations=1 -verbose -resource-pressure=false -instruction-info=false < %s | FileCheck %s -check-prefix=ALL<br>
><br>
> b t<br>
><br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/dot-product.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/dot-product.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/X86/BtVer2/dot-<wbr>product.s?rev=329403&r1=<wbr>329402&r2=329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/dot-product.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/dot-product.s Fri Apr 6 08:30:02 2018<br>
> @@ -59,10 +59,10 @@ vhaddps %xmm3, %xmm3, %xmm4<br>
> # CHECK: [0,0] DeeER. . . vmulps %xmm0, %xmm1, %xmm2<br>
> # CHECK-NEXT: [0,1] D==eeeER . . vhaddps %xmm2, %xmm2, %xmm3<br>
> # CHECK-NEXT: [0,2] .D====eeeER . vhaddps %xmm3, %xmm3, %xmm4<br>
> -# CHECK: [1,0] .DeeE-----R . vmulps %xmm0, %xmm1, %xmm2<br>
> +# CHECK-NEXT: [1,0] .DeeE-----R . vmulps %xmm0, %xmm1, %xmm2<br>
> # CHECK-NEXT: [1,1] . D=eeeE---R . vhaddps %xmm2, %xmm2, %xmm3<br>
> # CHECK-NEXT: [1,2] . D====eeeER . vhaddps %xmm3, %xmm3, %xmm4<br>
> -# CHECK: [2,0] . DeeE-----R . vmulps %xmm0, %xmm1, %xmm2<br>
> +# CHECK-NEXT: [2,0] . DeeE-----R . vmulps %xmm0, %xmm1, %xmm2<br>
> # CHECK-NEXT: [2,1] . D====eeeER . vhaddps %xmm2, %xmm2, %xmm3<br>
> # CHECK-NEXT: [2,2] . D======eeeER vhaddps %xmm3, %xmm3, %xmm4<br>
><br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/pipes-fpu.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/pipes-fpu.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/X86/BtVer2/pipes-fpu.<wbr>s?rev=329403&r1=329402&r2=<wbr>329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/pipes-fpu.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/pipes-fpu.s Fri Apr 6 08:30:02 2018<br>
> @@ -87,7 +87,7 @@ vsqrtps %ymm0, %ymm2<br>
> # CHECK-NEXT: [0,5] . DeeeeeeeeeeeeeeeeeeeeeER . . . . . . . . . vsqrtps %xmm0, %xmm2<br>
> # CHECK-NEXT: [0,6] . DeeeE-----------------R . . . . . . . . . vaddps %ymm0, %ymm1, %ymm2<br>
> # CHECK-NEXT: [0,7] . D===================<wbr>eeeeeeeeeeeeeeeeeeeeeeeeeeeeee<wbr>eeeeeeeeeeeeER . vsqrtps %ymm0, %ymm2<br>
> -# CHECK: [1,0] . .DeeeeE-----------------------<wbr>------------------------------<wbr>---R . vpmulld %xmm0, %xmm1, %xmm2<br>
> +# CHECK-NEXT: [1,0] . .DeeeeE-----------------------<wbr>------------------------------<wbr>---R . vpmulld %xmm0, %xmm1, %xmm2<br>
> # CHECK-NEXT: [1,1] . . DeE---------------------------<wbr>------------------------------<wbr>--R. vpand %xmm0, %xmm1, %xmm2<br>
> # CHECK-NEXT: [1,2] . . DeeeE-------------------------<wbr>------------------------------<wbr>-R. vcvttps2dq %xmm0, %xmm2<br>
> # CHECK-NEXT: [1,3] . . DeeE--------------------------<wbr>------------------------------<wbr>--R vpclmulqdq $0, %xmm0, %xmm1, %xmm2<br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>1.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/register-files-1.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/X86/BtVer2/register-<wbr>files-1.s?rev=329403&r1=<wbr>329402&r2=329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>1.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>1.s Fri Apr 6 08:30:02 2018<br>
> @@ -1,4 +1,4 @@<br>
> -# RUN: llvm-mca -mtriple=x86_64-unknown-<wbr>unknown -mcpu=btver2 -iterations=5 -verbose -register-file-stats -timeline < %s | FileCheck %s<br>
> +# RUN: llvm-mca -mtriple=x86_64-unknown-<wbr>unknown -mcpu=btver2 -iterations=5 -verbose -instruction-info=false -register-file-stats -timeline < %s | FileCheck %s<br>
><br>
> vaddps %xmm0, %xmm0, %xmm0<br>
> vmulps %xmm0, %xmm0, %xmm0<br>
> @@ -34,13 +34,14 @@ vmulps %xmm0, %xmm0, %xmm0<br>
> # CHECK: Timeline view:<br>
> # CHECK-NEXT: 0123456789<br>
> # CHECK-NEXT: Index 0123456789 01234567<br>
> +<br>
> # CHECK: [0,0] DeeeER . . . . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [0,1] D===eeER . . . . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [1,0] .D====eeeER . . . . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [1,0] .D====eeeER . . . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [1,1] .D=======eeER . . . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [2,0] . D========eeeER . . . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [2,0] . D========eeeER . . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [2,1] . D===========eeER . . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [3,0] . D============eeeER . . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [3,0] . D============eeeER . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [3,1] . D===============eeER . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [4,0] . D================eeeER . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [4,0] . D================eeeER . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [4,1] . D===================eeER vmulps %xmm0, %xmm0, %xmm0<br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>2.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/register-files-2.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/X86/BtVer2/register-<wbr>files-2.s?rev=329403&r1=<wbr>329402&r2=329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>2.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>2.s Fri Apr 6 08:30:02 2018<br>
> @@ -1,4 +1,4 @@<br>
> -# RUN: llvm-mca -mtriple=x86_64-unknown-<wbr>unknown -mcpu=btver2 -register-file-size=5 -iterations=5 -verbose -register-file-stats -timeline < %s | FileCheck %s<br>
> +# RUN: llvm-mca -mtriple=x86_64-unknown-<wbr>unknown -mcpu=btver2 -register-file-size=5 -iterations=5 -verbose -instruction-info=false -register-file-stats -timeline < %s | FileCheck %s<br>
><br>
> vaddps %xmm0, %xmm0, %xmm0<br>
> vmulps %xmm0, %xmm0, %xmm0<br>
> @@ -36,11 +36,11 @@ vmulps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: Index 0123456789 01234567<br>
> # CHECK: [0,0] DeeeER . . . . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [0,1] D===eeER . . . . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [1,0] .D====eeeER . . . . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [1,0] .D====eeeER . . . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [1,1] .D=======eeER . . . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [2,0] . D========eeeER . . . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [2,0] . D========eeeER . . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [2,1] . D========eeER . . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [3,0] . . D========eeeER . . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [3,0] . . D========eeeER . . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [3,1] . . D========eeER . . vmulps %xmm0, %xmm0, %xmm0<br>
> -# CHECK: [4,0] . . . D========eeeER . vaddps %xmm0, %xmm0, %xmm0<br>
> +# CHECK-NEXT: [4,0] . . . D========eeeER . vaddps %xmm0, %xmm0, %xmm0<br>
> # CHECK-NEXT: [4,1] . . . D========eeER vmulps %xmm0, %xmm0, %xmm0<br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>3.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/register-files-3.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/X86/BtVer2/register-<wbr>files-3.s?rev=329403&r1=<wbr>329402&r2=329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>3.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>3.s Fri Apr 6 08:30:02 2018<br>
> @@ -46,4 +46,4 @@ idiv %eax<br>
> # CHECK-NEXT: Index 0123456789 0123456789 0123456789<br>
><br>
> # CHECK: [0,0] DeeeeeeeeeeeeeeeeeeeeeeeeeER . . . . . . idivl %eax<br>
> -# CHECK: [1,0] . . . . . . DeeeeeeeeeeeeeeeeeeeeeeeeeER idivl %eax<br>
> +# CHECK-NEXT: [1,0] . . . . . . DeeeeeeeeeeeeeeeeeeeeeeeeeER idivl %eax<br>
><br>
> Modified: llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>4.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/BtVer2/register-files-4.s?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-mca/X86/BtVer2/register-<wbr>files-4.s?rev=329403&r1=<wbr>329402&r2=329403&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>4.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-<wbr>mca/X86/BtVer2/register-files-<wbr>4.s Fri Apr 6 08:30:02 2018<br>
> @@ -1,4 +1,4 @@<br>
> -# RUN: llvm-mca -mtriple=x86_64-unknown-<wbr>unknown -mcpu=btver2 -iterations=22 -verbose -register-file-stats -timeline -timeline-max-iterations=3 < %s | FileCheck %s<br>
> +# RUN: llvm-mca -mtriple=x86_64-unknown-<wbr>unknown -mcpu=btver2 -iterations=22 -verbose -register-file-stats -resource-pressure=false -timeline -timeline-max-iterations=3 < %s | FileCheck %s<br>
><br>
> idiv %eax<br>
><br>
> @@ -45,5 +45,5 @@ idiv %eax<br>
> # CHECK-NEXT: 0123456789 0123456789 0123456789 01234567<br>
> # CHECK-NEXT: Index 0123456789 0123456789 0123456789 0123456789<br>
> # CHECK: [0,0] DeeeeeeeeeeeeeeeeeeeeeeeeeER . . . . . . . . . . . idivl %eax<br>
> -# CHECK: [1,0] .D========================<wbr>eeeeeeeeeeeeeeeeeeeeeeeeeER . . . . . . idivl %eax<br>
> -# CHECK: [2,0] . D=============================<wbr>===================<wbr>eeeeeeeeeeeeeeeeeeeeeeeeeER idivl %eax<br>
> +# CHECK-NEXT: [1,0] .D========================<wbr>eeeeeeeeeeeeeeeeeeeeeeeeeER . . . . . . idivl %eax<br>
> +# CHECK-NEXT: [2,0] . D=============================<wbr>===================<wbr>eeeeeeeeeeeeeeeeeeeeeeeeeER idivl %eax<br>
><br>
> Modified: llvm/trunk/tools/llvm-mca/<wbr>TimelineView.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-mca/TimelineView.cpp?rev=329403&r1=329402&r2=329403&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>mca/TimelineView.cpp?rev=<wbr>329403&r1=329402&r2=329403&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/tools/llvm-mca/<wbr>TimelineView.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-mca/<wbr>TimelineView.cpp Fri Apr 6 08:30:02 2018<br>
> @@ -155,7 +155,7 @@ void TimelineView::<wbr>printTimelineViewEntr<br>
> const TimelineViewEntry &Entry,<br>
> unsigned Iteration,<br>
> unsigned SourceIndex) const {<br>
> - if (SourceIndex == 0)<br>
> + if (Iteration == 0 && SourceIndex == 0)<br>
> OS << '\n';<br>
> OS << '[' << Iteration << ',' << SourceIndex << "]\t";<br>
> for (unsigned I = 0, E = Entry.CycleDispatched; I < E; ++I)<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>