<div dir="ltr">That was deliberate. Both functions will run over the same set of indexes, so there's no point in warning twice.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, 6 Apr 2018 at 14:45, Jonas Devlieghere <<a href="mailto:jdevlieghere@apple.com">jdevlieghere@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Did you forget to add the same warning in DWARFVerifier::verifyNameIndexEntries or was that on purpose?<br>
<br>
> On Apr 6, 2018, at 2:34 PM, Pavel Labath via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: labath<br>
> Date: Fri Apr 6 06:34:12 2018<br>
> New Revision: 329392<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329392&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=329392&view=rev</a><br>
> Log:<br>
> DWARFVerifier: validate information in name index entries<br>
><br>
> Summary:<br>
> This patch add checks to verify that the information in the name index<br>
> entries is consistent with the debug_info section. Specifically, we<br>
> check that entries point to valid DIEs, and their names, tags, and<br>
> compile units match the information in the debug_info sections.<br>
><br>
> These checks are only run if the previous checks did not find any errors<br>
> in the name index headers. Attempting to proceed with the checks anyway<br>
> would likely produce a lot of spurious errors and the verification code<br>
> would need to be very careful to avoid crashing.<br>
><br>
> I also add a couple of more checks to the abbreviation-validation code<br>
> to verify that some attributes are always present (an index without a<br>
> DW_IDX_die_offset attribute is fairly useless).<br>
><br>
> The entry verification works only on indexes without any type units - I<br>
> haven't attempted to extend it to type units, as we don't even have a<br>
> DWARF v5-compatible type unit generator at the moment.<br>
><br>
> Reviewers: JDevlieghere, aprantl, dblaikie<br>
><br>
> Subscribers: llvm-commits<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D45323" rel="noreferrer" target="_blank">https://reviews.llvm.org/D45323</a><br>
><br>
> Added:<br>
> llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-entries.s<br>
> Modified:<br>
> llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h<br>
> llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h<br>
> llvm/trunk/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp<br>
> llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp<br>
> llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-abbrev-forms.s<br>
><br>
> Modified: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h?rev=329392&r1=329391&r2=329392&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h?rev=329392&r1=329391&r2=329392&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h (original)<br>
> +++ llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h Fri Apr 6 06:34:12 2018<br>
> @@ -283,6 +283,11 @@ public:<br>
><br>
> Entry(const NameIndex &NameIdx, const Abbrev &Abbr);<br>
><br>
> + public:<br>
> + Optional<uint64_t> getCUOffset() const override;<br>
> + Optional<uint64_t> getDIESectionOffset() const override;<br>
> + Optional<dwarf::Tag> getTag() const override { return tag(); }<br>
> +<br>
> /// Returns the Index into the Compilation Unit list of the owning Name<br>
> /// Index or None if this Accelerator Entry does not have an associated<br>
> /// Compilation Unit. It is up to the user to verify that the returned Index<br>
> @@ -293,11 +298,6 @@ public:<br>
> /// DW_IDX_compile_unit attribute.<br>
> Optional<uint64_t> getCUIndex() const;<br>
><br>
> - public:<br>
> - Optional<uint64_t> getCUOffset() const override;<br>
> - Optional<uint64_t> getDIESectionOffset() const override;<br>
> - Optional<dwarf::Tag> getTag() const override { return tag(); }<br>
> -<br>
> /// .debug_names-specific getter, which always succeeds (DWARF v5 index<br>
> /// entries always have a tag).<br>
> dwarf::Tag tag() const { return Abbr->Tag; }<br>
> @@ -319,7 +319,6 @@ public:<br>
> friend class ValueIterator;<br>
> };<br>
><br>
> -private:<br>
> /// Error returned by NameIndex::getEntry to report it has reached the end of<br>
> /// the entry list.<br>
> class SentinelError : public ErrorInfo<SentinelError> {<br>
> @@ -330,6 +329,7 @@ private:<br>
> std::error_code convertToErrorCode() const override;<br>
> };<br>
><br>
> +private:<br>
> /// DenseMapInfo for struct Abbrev.<br>
> struct AbbrevMapInfo {<br>
> static Abbrev getEmptyKey();<br>
> @@ -373,8 +373,6 @@ public:<br>
> uint32_t EntryOffsetsBase;<br>
> uint32_t EntriesBase;<br>
><br>
> - Expected<Entry> getEntry(uint32_t *Offset) const;<br>
> -<br>
> void dumpCUs(ScopedPrinter &W) const;<br>
> void dumpLocalTUs(ScopedPrinter &W) const;<br>
> void dumpForeignTUs(ScopedPrinter &W) const;<br>
> @@ -429,6 +427,8 @@ public:<br>
> return Abbrevs;<br>
> }<br>
><br>
> + Expected<Entry> getEntry(uint32_t *Offset) const;<br>
> +<br>
> llvm::Error extract();<br>
> uint32_t getUnitOffset() const { return Base; }<br>
> uint32_t getNextUnitOffset() const { return Base + 4 + Hdr.UnitLength; }<br>
><br>
> Modified: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h?rev=329392&r1=329391&r2=329392&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h?rev=329392&r1=329391&r2=329392&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h (original)<br>
> +++ llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h Fri Apr 6 06:34:12 2018<br>
> @@ -240,6 +240,8 @@ private:<br>
> unsigned verifyNameIndexAttribute(const DWARFDebugNames::NameIndex &NI,<br>
> const DWARFDebugNames::Abbrev &Abbr,<br>
> DWARFDebugNames::AttributeEncoding AttrEnc);<br>
> + unsigned verifyNameIndexEntries(const DWARFDebugNames::NameIndex &NI,<br>
> + uint32_t Name, const DataExtractor &StrData);<br>
><br>
> /// Verify that the DWARF v5 accelerator table is valid.<br>
> ///<br>
> @@ -251,6 +253,8 @@ private:<br>
> /// - The buckets have a valid index, or they are empty.<br>
> /// - All names are reachable via the hash table (they have the correct hash,<br>
> /// and the hash is in the correct bucket).<br>
> + /// - Information in the index entries is consistent with the debug_info<br>
> + /// section DIEs.<br>
> ///<br>
> /// \param AccelSection section containing the acceleration table<br>
> /// \param StrData string section<br>
><br>
> Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp?rev=329392&r1=329391&r2=329392&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp?rev=329392&r1=329391&r2=329392&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp (original)<br>
> +++ llvm/trunk/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp Fri Apr 6 06:34:12 2018<br>
> @@ -601,7 +601,7 @@ Expected<DWARFDebugNames::Entry><br>
> DWARFDebugNames::NameIndex::getEntry(uint32_t *Offset) const {<br>
> const DWARFDataExtractor &AS = Section.AccelSection;<br>
> if (!AS.isValidOffset(*Offset))<br>
> - return make_error<StringError>("Incorrectly terminated entry list",<br>
> + return make_error<StringError>("Incorrectly terminated entry list.",<br>
> inconvertibleErrorCode());<br>
><br>
> uint32_t AbbrevCode = AS.getULEB128(Offset);<br>
> @@ -610,7 +610,7 @@ DWARFDebugNames::NameIndex::getEntry(uin<br>
><br>
> const auto AbbrevIt = Abbrevs.find_as(AbbrevCode);<br>
> if (AbbrevIt == Abbrevs.end())<br>
> - return make_error<StringError>("Invalid abbreviation",<br>
> + return make_error<StringError>("Invalid abbreviation.",<br>
> inconvertibleErrorCode());<br>
><br>
> Entry E(*this, *AbbrevIt);<br>
> @@ -618,7 +618,7 @@ DWARFDebugNames::NameIndex::getEntry(uin<br>
> dwarf::FormParams FormParams = {Hdr.Version, 0, dwarf::DwarfFormat::DWARF32};<br>
> for (auto &Value : E.Values) {<br>
> if (!Value.extractValue(AS, Offset, FormParams))<br>
> - return make_error<StringError>("Error extracting index attribute values",<br>
> + return make_error<StringError>("Error extracting index attribute values.",<br>
> inconvertibleErrorCode());<br>
> }<br>
> return std::move(E);<br>
><br>
> Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp?rev=329392&r1=329391&r2=329392&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp?rev=329392&r1=329391&r2=329392&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp (original)<br>
> +++ llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp Fri Apr 6 06:34:12 2018<br>
> @@ -1000,6 +1000,13 @@ unsigned DWARFVerifier::verifyNameIndexA<br>
><br>
> unsigned<br>
> DWARFVerifier::verifyNameIndexAbbrevs(const DWARFDebugNames::NameIndex &NI) {<br>
> + if (NI.getLocalTUCount() + NI.getForeignTUCount() > 0) {<br>
> + warn() << formatv("Name Index @ {0:x}: Verifying indexes of type units is "<br>
> + "not currently supported.\n",<br>
> + NI.getUnitOffset());<br>
> + return 0;<br>
> + }<br>
> +<br>
> unsigned NumErrors = 0;<br>
> for (const auto &Abbrev : NI.getAbbrevs()) {<br>
> StringRef TagName = dwarf::TagString(Abbrev.Tag);<br>
> @@ -1019,7 +1026,119 @@ DWARFVerifier::verifyNameIndexAbbrevs(co<br>
> }<br>
> NumErrors += verifyNameIndexAttribute(NI, Abbrev, AttrEnc);<br>
> }<br>
> +<br>
> + if (NI.getCUCount() > 1 && !Attributes.count(dwarf::DW_IDX_compile_unit)) {<br>
> + error() << formatv("NameIndex @ {0:x}: Indexing multiple compile units "<br>
> + "and abbreviation {1:x} has no {2} attribute.\n",<br>
> + NI.getUnitOffset(), Abbrev.Code,<br>
> + dwarf::DW_IDX_compile_unit);<br>
> + ++NumErrors;<br>
> + }<br>
> + if (!Attributes.count(dwarf::DW_IDX_die_offset)) {<br>
> + error() << formatv(<br>
> + "NameIndex @ {0:x}: Abbreviation {1:x} has no {2} attribute.\n",<br>
> + NI.getUnitOffset(), Abbrev.Code, dwarf::DW_IDX_die_offset);<br>
> + ++NumErrors;<br>
> + }<br>
> + }<br>
> + return NumErrors;<br>
> +}<br>
> +<br>
> +static SmallVector<StringRef, 2> getNames(const DWARFDie &DIE) {<br>
> + SmallVector<StringRef, 2> Result;<br>
> + if (const char *Str = DIE.getName(DINameKind::ShortName))<br>
> + Result.emplace_back(Str);<br>
> + else if (DIE.getTag() == dwarf::DW_TAG_namespace)<br>
> + Result.emplace_back("(anonymous namespace)");<br>
> +<br>
> + if (const char *Str = DIE.getName(DINameKind::LinkageName)) {<br>
> + if (Result.empty() || Result[0] != Str)<br>
> + Result.emplace_back(Str);<br>
> + }<br>
> +<br>
> + return Result;<br>
> +}<br>
> +<br>
> +unsigned<br>
> +DWARFVerifier::verifyNameIndexEntries(const DWARFDebugNames::NameIndex &NI,<br>
> + uint32_t Name,<br>
> + const DataExtractor &StrData) {<br>
> + // Verifying type unit indexes not supported.<br>
> + if (NI.getLocalTUCount() + NI.getForeignTUCount() > 0)<br>
> + return 0;<br>
> +<br>
> + DWARFDebugNames::NameTableEntry NTE = NI.getNameTableEntry(Name);<br>
> + const char *CStr = StrData.getCStr(&NTE.StringOffset);<br>
> + if (!CStr) {<br>
> + error() << formatv(<br>
> + "Name Index @ {0:x}: Unable to get string associated with name {1}.\n",<br>
> + NI.getUnitOffset(), Name);<br>
> + return 1;<br>
> + }<br>
> + StringRef Str(CStr);<br>
> +<br>
> + unsigned NumErrors = 0;<br>
> + unsigned NumEntries = 0;<br>
> + uint32_t EntryID = NTE.EntryOffset;<br>
> + Expected<DWARFDebugNames::Entry> EntryOr = NI.getEntry(&NTE.EntryOffset);<br>
> + for (; EntryOr; ++NumEntries, EntryID = NTE.EntryOffset,<br>
> + EntryOr = NI.getEntry(&NTE.EntryOffset)) {<br>
> + uint32_t CUIndex = *EntryOr->getCUIndex();<br>
> + if (CUIndex > NI.getCUCount()) {<br>
> + error() << formatv("Name Index @ {0:x}: Entry @ {1:x} contains an "<br>
> + "invalid CU index ({2}).\n",<br>
> + NI.getUnitOffset(), EntryID, CUIndex);<br>
> + ++NumErrors;<br>
> + continue;<br>
> + }<br>
> + uint32_t CUOffset = NI.getCUOffset(CUIndex);<br>
> + uint64_t DIEOffset = *EntryOr->getDIESectionOffset();<br>
> + DWARFDie DIE = DCtx.getDIEForOffset(DIEOffset);<br>
> + if (!DIE) {<br>
> + error() << formatv("Name Index @ {0:x}: Entry @ {1:x} references a "<br>
> + "non-existing DIE @ {2:x}.\n",<br>
> + NI.getUnitOffset(), EntryID, DIEOffset);<br>
> + ++NumErrors;<br>
> + continue;<br>
> + }<br>
> + if (DIE.getDwarfUnit()->getOffset() != CUOffset) {<br>
> + error() << formatv("Name Index @ {0:x}: Entry @ {1:x}: mismatched CU of "<br>
> + "DIE @ {2:x}: index - {3:x}; debug_info - {4:x}.\n",<br>
> + NI.getUnitOffset(), EntryID, DIEOffset, CUOffset,<br>
> + DIE.getDwarfUnit()->getOffset());<br>
> + ++NumErrors;<br>
> + }<br>
> + if (DIE.getTag() != EntryOr->tag()) {<br>
> + error() << formatv("Name Index @ {0:x}: Entry @ {1:x}: mismatched Tag of "<br>
> + "DIE @ {2:x}: index - {3}; debug_info - {4}.\n",<br>
> + NI.getUnitOffset(), EntryID, DIEOffset, EntryOr->tag(),<br>
> + DIE.getTag());<br>
> + ++NumErrors;<br>
> + }<br>
> +<br>
> + auto EntryNames = getNames(DIE);<br>
> + if (!is_contained(EntryNames, Str)) {<br>
> + error() << formatv("Name Index @ {0:x}: Entry @ {1:x}: mismatched Name "<br>
> + "of DIE @ {2:x}: index - {3}; debug_info - {4}.\n",<br>
> + NI.getUnitOffset(), EntryID, DIEOffset, Str,<br>
> + make_range(EntryNames.begin(), EntryNames.end()));<br>
> + }<br>
> }<br>
> + handleAllErrors(EntryOr.takeError(),<br>
> + [&](const DWARFDebugNames::SentinelError &) {<br>
> + if (NumEntries > 0)<br>
> + return;<br>
> + error() << formatv("Name Index @ {0:x}: Name {1} ({2}) is "<br>
> + "not associated with any entries.\n",<br>
> + NI.getUnitOffset(), Name, Str);<br>
> + ++NumErrors;<br>
> + },<br>
> + [&](const ErrorInfoBase &Info) {<br>
> + error() << formatv(<br>
> + "Name Index @ {0:x}: Name {1} ({2}): {3}\n",<br>
> + NI.getUnitOffset(), Name, Str, Info.message());<br>
> + ++NumErrors;<br>
> + });<br>
> return NumErrors;<br>
> }<br>
><br>
> @@ -1045,6 +1164,13 @@ unsigned DWARFVerifier::verifyDebugNames<br>
> for (const auto &NI : AccelTable)<br>
> NumErrors += verifyNameIndexAbbrevs(NI);<br>
><br>
> + // Don't attempt Entry validation if any of the previous checks found errors<br>
> + if (NumErrors > 0)<br>
> + return NumErrors;<br>
> + for (const auto &NI : AccelTable)<br>
> + for (uint64_t Name = 1; Name <= NI.getNameCount(); ++Name)<br>
> + NumErrors += verifyNameIndexEntries(NI, Name, StrData);<br>
> +<br>
> return NumErrors;<br>
> }<br>
><br>
><br>
> Modified: llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-abbrev-forms.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-abbrev-forms.s?rev=329392&r1=329391&r2=329392&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-abbrev-forms.s?rev=329392&r1=329391&r2=329392&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-abbrev-forms.s (original)<br>
> +++ llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-abbrev-forms.s Fri Apr 6 06:34:12 2018<br>
> @@ -8,6 +8,8 @@<br>
> # CHECK: error: NameIndex @ 0x0: Abbreviation 0x4 contains multiple DW_IDX_die_offset attributes.<br>
> # CHECK: NameIndex @ 0x0: Abbreviation 0x1: DW_IDX_die_offset uses an unknown form: DW_FORM_unknown_1fff.<br>
> # CHECK: warning: NameIndex @ 0x0: Abbreviation 0x3 references an unknown tag: DW_TAG_unknown_8080.<br>
> +# CHECK: error: NameIndex @ 0x0: Abbreviation 0x5 has no DW_IDX_die_offset attribute.<br>
> +# CHECK: error: NameIndex @ 0x55: Indexing multiple compile units and abbreviation 0x1 has no DW_IDX_compile_unit attribute.<br>
><br>
> .section .debug_str,"MS",@progbits,1<br>
> .Lstring_producer:<br>
> @@ -39,6 +41,30 @@<br>
> .byte 0 # End Of Children Mark<br>
> .Lcu_end0:<br>
><br>
> +.Lcu_begin1:<br>
> + .long .Lcu_end1-.Lcu_start1 # Length of Unit<br>
> +.Lcu_start1:<br>
> + .short 4 # DWARF version number<br>
> + .long .Lsection_abbrev # Offset Into Abbrev. Section<br>
> + .byte 8 # Address Size (in bytes)<br>
> + .byte 1 # Abbrev [1] DW_TAG_compile_unit<br>
> + .long .Lstring_producer # DW_AT_producer<br>
> + .short 12 # DW_AT_language<br>
> + .byte 0 # End Of Children Mark<br>
> +.Lcu_end1:<br>
> +<br>
> +.Lcu_begin2:<br>
> + .long .Lcu_end2-.Lcu_start2 # Length of Unit<br>
> +.Lcu_start2:<br>
> + .short 4 # DWARF version number<br>
> + .long .Lsection_abbrev # Offset Into Abbrev. Section<br>
> + .byte 8 # Address Size (in bytes)<br>
> + .byte 1 # Abbrev [1] DW_TAG_compile_unit<br>
> + .long .Lstring_producer # DW_AT_producer<br>
> + .short 12 # DW_AT_language<br>
> + .byte 0 # End Of Children Mark<br>
> +.Lcu_end2:<br>
> +<br>
> .section .debug_names,"",@progbits<br>
> .long .Lnames_end0-.Lnames_start0 # Header: contribution length<br>
> .Lnames_start0:<br>
> @@ -87,6 +113,36 @@<br>
> .byte 17 # DW_FORM_ref1<br>
> .byte 0 # End of abbrev<br>
> .byte 0 # End of abbrev<br>
> + .byte 5 # Abbrev code<br>
> + .byte 46 # DW_TAG_subprogram<br>
> + .byte 4 # DW_IDX_parent<br>
> + .byte 5 # DW_FORM_data2<br>
> + .byte 0 # End of abbrev<br>
> + .byte 0 # End of abbrev<br>
> .byte 0 # End of abbrev list<br>
> .Lnames_abbrev_end0:<br>
> .Lnames_end0:<br>
> +<br>
> + .long .Lnames_end1-.Lnames_start1 # Header: contribution length<br>
> +.Lnames_start1:<br>
> + .short 5 # Header: version<br>
> + .short 0 # Header: padding<br>
> + .long 2 # Header: compilation unit count<br>
> + .long 0 # Header: local type unit count<br>
> + .long 0 # Header: foreign type unit count<br>
> + .long 0 # Header: bucket count<br>
> + .long 0 # Header: name count<br>
> + .long .Lnames_abbrev_end1-.Lnames_abbrev_start1 # Header: abbreviation table size<br>
> + .long 0 # Header: augmentation length<br>
> + .long .Lcu_begin1 # Compilation unit 0<br>
> + .long .Lcu_begin2 # Compilation unit 1<br>
> +.Lnames_abbrev_start1:<br>
> + .byte 1 # Abbrev code<br>
> + .byte 46 # DW_TAG_subprogram<br>
> + .byte 3 # DW_IDX_die_offset<br>
> + .byte 17 # DW_FORM_ref1<br>
> + .byte 0 # End of abbrev<br>
> + .byte 0 # End of abbrev<br>
> + .byte 0 # End of abbrev list<br>
> +.Lnames_abbrev_end1:<br>
> +.Lnames_end1:<br>
><br>
> Added: llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-entries.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-entries.s?rev=329392&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-entries.s?rev=329392&view=auto</a><br>
> ==============================================================================<br>
> --- llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-entries.s (added)<br>
> +++ llvm/trunk/test/tools/llvm-dwarfdump/X86/debug-names-verify-entries.s Fri Apr 6 06:34:12 2018<br>
> @@ -0,0 +1,188 @@<br>
> +# RUN: llvm-mc -triple x86_64-pc-linux %s -filetype=obj -o - | not llvm-dwarfdump -verify - | FileCheck %s<br>
> +<br>
> +# CHECK: error: Name Index @ 0x0: Unable to get string associated with name 1.<br>
> +# CHECK: error: Name Index @ 0x0: Entry @ 0x73 contains an invalid CU index (47).<br>
> +# CHECK: error: Name Index @ 0x0: Entry @ 0x79 references a non-existing DIE @ 0x3fa.<br>
> +# CHECK: error: Name Index @ 0x0: Entry @ 0x85: mismatched CU of DIE @ 0x30: index - 0x0; debug_info - 0x1e.<br>
> +# CHECK: error: Name Index @ 0x0: Entry @ 0x8b: mismatched Tag of DIE @ 0x17: index - DW_TAG_subprogram; debug_info - DW_TAG_variable.<br>
> +# CHECK: error: Name Index @ 0x0: Entry @ 0x91: mismatched Name of DIE @ 0x35: index - foo; debug_info - bar, _Z3bar.<br>
> +# CHECK: error: Name Index @ 0x0: Name 2 (foo): Incorrectly terminated entry list.<br>
> +# CHECK: error: Name Index @ 0x0: Name 3 (bar) is not associated with any entries.<br>
> +# CHECK: error: Name Index @ 0x0: Entry @ 0x69: mismatched Name of DIE @ 0x1c: index - (pseudonymous namespace); debug_info - (anonymous namespace).<br>
> +<br>
> + .section .debug_str,"MS",@progbits,1<br>
> +.Lstring_foo:<br>
> + .asciz "foo"<br>
> +.Lstring_bar:<br>
> + .asciz "bar"<br>
> +.Lstring_bar_mangled:<br>
> + .asciz "_Z3bar"<br>
> +.Lstring_pseudo_namespace:<br>
> + .asciz "(pseudonymous namespace)"<br>
> +.Lstring_producer:<br>
> + .asciz "Hand-written dwarf"<br>
> +<br>
> + .section .debug_abbrev,"",@progbits<br>
> +.Lsection_abbrev:<br>
> + .byte 1 # Abbreviation Code<br>
> + .byte 17 # DW_TAG_compile_unit<br>
> + .byte 1 # DW_CHILDREN_yes<br>
> + .byte 37 # DW_AT_producer<br>
> + .byte 14 # DW_FORM_strp<br>
> + .byte 19 # DW_AT_language<br>
> + .byte 5 # DW_FORM_data2<br>
> + .byte 0 # EOM(1)<br>
> + .byte 0 # EOM(2)<br>
> + .byte 2 # Abbreviation Code<br>
> + .byte 46 # DW_TAG_subprogram<br>
> + .byte 0 # DW_CHILDREN_no<br>
> + .byte 3 # DW_AT_name<br>
> + .byte 14 # DW_FORM_strp<br>
> + .byte 63 # DW_AT_external<br>
> + .byte 25 # DW_FORM_flag_present<br>
> + .byte 0 # EOM(1)<br>
> + .byte 0 # EOM(2)<br>
> + .byte 3 # Abbreviation Code<br>
> + .byte 52 # DW_TAG_variable<br>
> + .byte 0 # DW_CHILDREN_no<br>
> + .byte 3 # DW_AT_name<br>
> + .byte 14 # DW_FORM_strp<br>
> + .byte 0 # EOM(1)<br>
> + .byte 0 # EOM(2)<br>
> + .byte 4 # Abbreviation Code<br>
> + .byte 57 # DW_TAG_namespace<br>
> + .byte 0 # DW_CHILDREN_no<br>
> + .byte 0 # EOM(1)<br>
> + .byte 0 # EOM(2)<br>
> + .byte 5 # Abbreviation Code<br>
> + .byte 52 # DW_TAG_variable<br>
> + .byte 0 # DW_CHILDREN_no<br>
> + .byte 3 # DW_AT_name<br>
> + .byte 14 # DW_FORM_strp<br>
> + .byte 110 # DW_AT_linkage_name<br>
> + .byte 14 # DW_FORM_strp<br>
> + .byte 0 # EOM(1)<br>
> + .byte 0 # EOM(2)<br>
> + .byte 0 # EOM(3)<br>
> +<br>
> + .section .debug_info,"",@progbits<br>
> +.Lcu_begin0:<br>
> + .long .Lcu_end0-.Lcu_start0 # Length of Unit<br>
> +.Lcu_start0:<br>
> + .short 4 # DWARF version number<br>
> + .long .Lsection_abbrev # Offset Into Abbrev. Section<br>
> + .byte 8 # Address Size (in bytes)<br>
> + .byte 1 # Abbrev [1] DW_TAG_compile_unit<br>
> + .long .Lstring_producer # DW_AT_producer<br>
> + .short 12 # DW_AT_language<br>
> +.Ldie_foo:<br>
> + .byte 2 # Abbrev [2] DW_TAG_subprogram<br>
> + .long .Lstring_foo # DW_AT_name<br>
> + # DW_AT_external<br>
> +.Ldie_foo_var:<br>
> + .byte 3 # Abbrev [3] DW_TAG_variable<br>
> + .long .Lstring_foo # DW_AT_name<br>
> +.Ldie_namespace:<br>
> + .byte 4 # Abbrev [3] DW_TAG_namespace<br>
> + .byte 0 # End Of Children Mark<br>
> +.Lcu_end0:<br>
> +<br>
> +.Lcu_begin1:<br>
> + .long .Lcu_end1-.Lcu_start1 # Length of Unit<br>
> +.Lcu_start1:<br>
> + .short 4 # DWARF version number<br>
> + .long .Lsection_abbrev # Offset Into Abbrev. Section<br>
> + .byte 8 # Address Size (in bytes)<br>
> + .byte 1 # Abbrev [1] DW_TAG_compile_unit<br>
> + .long .Lstring_producer # DW_AT_producer<br>
> + .short 12 # DW_AT_language<br>
> +.Ldie_foo2:<br>
> + .byte 2 # Abbrev [2] DW_TAG_subprogram<br>
> + .long .Lstring_foo # DW_AT_name<br>
> + # DW_AT_external<br>
> +.Ldie_bar_linkage:<br>
> + .byte 5 # Abbrev [2] DW_TAG_variable<br>
> + .long .Lstring_bar # DW_AT_name<br>
> + .long .Lstring_bar_mangled # DW_AT_linkage_name<br>
> + .byte 0 # End Of Children Mark<br>
> +.Lcu_end1:<br>
> +<br>
> +<br>
> + .section .debug_names,"",@progbits<br>
> + .long .Lnames_end0-.Lnames_start0 # Header: contribution length<br>
> +.Lnames_start0:<br>
> + .short 5 # Header: version<br>
> + .short 0 # Header: padding<br>
> + .long 2 # Header: compilation unit count<br>
> + .long 0 # Header: local type unit count<br>
> + .long 0 # Header: foreign type unit count<br>
> + .long 0 # Header: bucket count<br>
> + .long 4 # Header: name count<br>
> + .long .Lnames_abbrev_end0-.Lnames_abbrev_start0 # Header: abbreviation table size<br>
> + .long 0 # Header: augmentation length<br>
> + .long .Lcu_begin0 # Compilation unit 0<br>
> + .long .Lcu_begin1 # Compilation unit 1<br>
> + .long .Lstring_foo+1000 # String 1: <broken><br>
> + .long .Lstring_foo # String 2: foo<br>
> + .long .Lstring_bar # String 3: bar<br>
> + .long .Lstring_pseudo_namespace # String 4: (pseudonymous namespace)<br>
> + .long .Lnames0-.Lnames_entries0 # Offset 1<br>
> + .long .Lnames0-.Lnames_entries0 # Offset 2<br>
> + .long .Lnames1-.Lnames_entries0 # Offset 3<br>
> + .long .Lnames2-.Lnames_entries0 # Offset 4<br>
> +.Lnames_abbrev_start0:<br>
> + .byte 46 # Abbrev code<br>
> + .byte 46 # DW_TAG_subprogram<br>
> + .byte 1 # DW_IDX_compile_unit<br>
> + .byte 11 # DW_FORM_data1<br>
> + .byte 3 # DW_IDX_die_offset<br>
> + .byte 19 # DW_FORM_ref4<br>
> + .byte 0 # End of abbrev<br>
> + .byte 0 # End of abbrev<br>
> + .byte 57 # Abbrev code<br>
> + .byte 57 # DW_TAG_namespace<br>
> + .byte 1 # DW_IDX_compile_unit<br>
> + .byte 11 # DW_FORM_data1<br>
> + .byte 3 # DW_IDX_die_offset<br>
> + .byte 19 # DW_FORM_ref4<br>
> + .byte 0 # End of abbrev<br>
> + .byte 0 # End of abbrev<br>
> + .byte 52 # Abbrev code<br>
> + .byte 52 # DW_TAG_variable<br>
> + .byte 1 # DW_IDX_compile_unit<br>
> + .byte 11 # DW_FORM_data1<br>
> + .byte 3 # DW_IDX_die_offset<br>
> + .byte 19 # DW_FORM_ref4<br>
> + .byte 0 # End of abbrev<br>
> + .byte 0 # End of abbrev<br>
> + .byte 0 # End of abbrev list<br>
> +.Lnames_abbrev_end0:<br>
> +.Lnames_entries0:<br>
> +.Lnames1:<br>
> + .long 0 # End of list: bar<br>
> +.Lnames2:<br>
> + .byte 57 # Abbrev code<br>
> + .byte 0 # DW_IDX_compile_unit<br>
> + .long .Ldie_namespace-.Lcu_begin0 # DW_IDX_die_offset<br>
> + .long 0 # End of list: (pseudonymous namespace)<br>
> +.Lnames0:<br>
> + .byte 46 # Abbrev code<br>
> + .byte 47 # DW_IDX_compile_unit<br>
> + .long .Ldie_foo-.Lcu_begin0 # DW_IDX_die_offset<br>
> + .byte 46 # Abbrev code<br>
> + .byte 0 # DW_IDX_compile_unit<br>
> + .long .Ldie_foo-.Lcu_begin0+1000 # DW_IDX_die_offset<br>
> + .byte 46 # Abbrev code<br>
> + .byte 0 # DW_IDX_compile_unit<br>
> + .long .Ldie_foo-.Lcu_begin0 # DW_IDX_die_offset<br>
> + .byte 46 # Abbrev code<br>
> + .byte 0 # DW_IDX_compile_unit<br>
> + .long .Ldie_foo2-.Lcu_begin0 # DW_IDX_die_offset<br>
> + .byte 46 # Abbrev code<br>
> + .byte 0 # DW_IDX_compile_unit<br>
> + .long .Ldie_foo_var-.Lcu_begin0 # DW_IDX_die_offset<br>
> + .byte 52 # Abbrev code<br>
> + .byte 1 # DW_IDX_compile_unit<br>
> + .long .Ldie_bar_linkage-.Lcu_begin1 # DW_IDX_die_offset<br>
> + #.long 0 # End of list deliberately missing<br>
> +.Lnames_end0:<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div>