<div dir="ltr">Was this change ever reviewed? (I see the <a href="http://reviews.llvm.org" target="_blank">reviews.llvm.org</a> link, but that seems to point to a clang change). It seems to be missing a test, can you add one? It can probably be modelled on llvm/test/tools/llvm-lto2/X86/pipeline.ll .<div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 4, 2017 at 6:48 PM, Sean Fertile via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sfertile<br>
Date: Wed Oct  4 18:48:42 2017<br>
New Revision: 314963<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314963&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=314963&view=rev</a><br>
Log:<br>
Enabling new pass manager in LTO (and thinLTO) link step.<br>
<br>
Adds the option 'new-pass-manager' to the gold pluggin to enable using the<br>
new pass manager during the lto/thinlto link step.<br>
<br>
Patch by Graham Yiu.<br>
<br>
 Differential Revision: <a href="https://reviews.llvm.org/D38517" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D38517</a><br>
<br>
Modified:<br>
    llvm/trunk/tools/gold/gold-<wbr>plugin.cpp<br>
<br>
Modified: llvm/trunk/tools/gold/gold-<wbr>plugin.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=314963&r1=314962&r2=314963&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/gold/<wbr>gold-plugin.cpp?rev=314963&r1=<wbr>314962&r2=314963&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/gold/gold-<wbr>plugin.cpp (original)<br>
+++ llvm/trunk/tools/gold/gold-<wbr>plugin.cpp Wed Oct  4 18:48:42 2017<br>
@@ -183,6 +183,8 @@ namespace options {<br>
   static std::vector<const char *> extra;<br>
   // Sample profile file path<br>
   static std::string sample_profile;<br>
+  // New pass manager<br>
+  static bool new_pass_manager = false;<br>
<br>
   static void process_plugin_option(const char *opt_)<br>
   {<br>
@@ -242,6 +244,8 @@ namespace options {<br>
       DisableVerify = true;<br>
     } else if (opt.startswith("sample-<wbr>profile=")) {<br>
       sample_profile= opt.substr(strlen("sample-<wbr>profile="));<br>
+    } else if (opt == "new-pass-manager") {<br>
+      new_pass_manager = true;<br>
     } else {<br>
       // Save this option to pass to the code generator.<br>
       // ParseCommandLineOptions() expects argv[0] to be program name. Lazily<br>
@@ -805,6 +809,9 @@ static std::unique_ptr<LTO> createLTO()<br>
   if (!options::sample_profile.<wbr>empty())<br>
     Conf.SampleProfile = options::sample_profile;<br>
<br>
+  // Use new pass manager if set in driver<br>
+  Conf.UseNewPM = options::new_pass_manager;<br>
+<br>
   return llvm::make_unique<LTO>(std::<wbr>move(Conf), Backend,<br>
                                 options::<wbr>ParallelCodeGenParallelismLeve<wbr>l);<br>
 }<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>