<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 4, 2018 at 1:28 PM, Peter Collingbourne via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Was this change ever reviewed? (I see the <a href="http://reviews.llvm.org" target="_blank">reviews.llvm.org</a> link, but that seems to point to a clang change). It seems to be missing a test, can you add one? It can probably be modelled on llvm/test/tools/llvm-lto2/<wbr>X86/pipeline.ll .</div></blockquote><div><br></div><div>I searched through some old email and the gold-plugin.cpp change was original part of this patch. I asked for a test but specifically asked for one to make sure it was passed via the driver, which is what got added.</div><div><br></div><div>Teresa</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Peter</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Wed, Oct 4, 2017 at 6:48 PM, Sean Fertile via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sfertile<br>
Date: Wed Oct 4 18:48:42 2017<br>
New Revision: 314963<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314963&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=314963&view=rev</a><br>
Log:<br>
Enabling new pass manager in LTO (and thinLTO) link step.<br>
<br>
Adds the option 'new-pass-manager' to the gold pluggin to enable using the<br>
new pass manager during the lto/thinlto link step.<br>
<br>
Patch by Graham Yiu.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D38517" rel="noreferrer" target="_blank">https://reviews.llvm.org/D3851<wbr>7</a><br>
<br>
Modified:<br>
llvm/trunk/tools/gold/gold-plu<wbr>gin.cpp<br>
<br>
Modified: llvm/trunk/tools/gold/gold-plu<wbr>gin.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=314963&r1=314962&r2=314963&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/tools/gold/go<wbr>ld-plugin.cpp?rev=314963&r1=31<wbr>4962&r2=314963&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/gold/gold-plu<wbr>gin.cpp (original)<br>
+++ llvm/trunk/tools/gold/gold-plu<wbr>gin.cpp Wed Oct 4 18:48:42 2017<br>
@@ -183,6 +183,8 @@ namespace options {<br>
static std::vector<const char *> extra;<br>
// Sample profile file path<br>
static std::string sample_profile;<br>
+ // New pass manager<br>
+ static bool new_pass_manager = false;<br>
<br>
static void process_plugin_option(const char *opt_)<br>
{<br>
@@ -242,6 +244,8 @@ namespace options {<br>
DisableVerify = true;<br>
} else if (opt.startswith("sample-profil<wbr>e=")) {<br>
sample_profile= opt.substr(strlen("sample-prof<wbr>ile="));<br>
+ } else if (opt == "new-pass-manager") {<br>
+ new_pass_manager = true;<br>
} else {<br>
// Save this option to pass to the code generator.<br>
// ParseCommandLineOptions() expects argv[0] to be program name. Lazily<br>
@@ -805,6 +809,9 @@ static std::unique_ptr<LTO> createLTO()<br>
if (!options::sample_profile.empt<wbr>y())<br>
Conf.SampleProfile = options::sample_profile;<br>
<br>
+ // Use new pass manager if set in driver<br>
+ Conf.UseNewPM = options::new_pass_manager;<br>
+<br>
return llvm::make_unique<LTO>(std::mo<wbr>ve(Conf), Backend,<br>
options::ParallelCodeGenParal<wbr>lelismLevel);<br>
}<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_7096730838049528526gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</font></span></div>
<br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>