<div dir="ltr">I'm not sure which patch it is, but tons of bots are failing after these.<div><br></div><div><a href="http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/1241">http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/1241</a><br></div><div><br></div><div>as an example.</div><div><br></div><div>I'm also seeing it on my local linux box. Can you revert or fix please? :)</div><div><br></div><div>Thanks!</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Apr 2, 2018 at 2:47 PM Aaron Smith via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: asmith<br>
Date: Mon Apr  2 14:44:51 2018<br>
New Revision: 329020<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=329020&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=329020&view=rev</a><br>
Log:<br>
[lit] Use io.open to compare two files since it supports different encodings while older versions of open do not<br>
<br>
Modified:<br>
    llvm/trunk/utils/lit/lit/TestRunner.py<br>
<br>
Modified: llvm/trunk/utils/lit/lit/TestRunner.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=329020&r1=329019&r2=329020&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=329020&r1=329019&r2=329020&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)<br>
+++ llvm/trunk/utils/lit/lit/TestRunner.py Mon Apr  2 14:44:51 2018<br>
@@ -388,7 +388,7 @@ def executeBuiltinDiff(cmd, cmd_shenv):<br>
     def compareTwoFiles(filepaths):<br>
         filelines = []<br>
         for file in filepaths:<br>
-            with open(file, 'r') as f:<br>
+            with io.open(file, 'r') as f:<br>
                 filelines.append(f.readlines())<br>
<br>
         exitCode = 0<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>