<div dir="ltr">All good here. Thanks! :)<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Apr 2, 2018 at 3:24 PM Aaron Smith <<a href="mailto:aaron.smith@microsoft.com">aaron.smith@microsoft.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-6697698564752812180WordSection1">
<p class="MsoNormal">Really sorry about that. I committed that to fix some broke build bots with our patch and at the same time someone reverted my change, which means every bot will break. I’ve already recommitted the complete patch. Would you let me know
if you still have problems locally?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
<p class="MsoNormal">Aaron<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>><br>
<b>Date: </b>Monday, April 2, 2018 at 3:22 PM<br>
<b>To: </b>Aaron Smith <<a href="mailto:aaron.smith@microsoft.com" target="_blank">aaron.smith@microsoft.com</a>><br>
<b>Cc: </b>"<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>" <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: [llvm] r329020 - [lit] Use io.open to compare two files since it supports different encodings while older versions of open do not<u></u><u></u></span></p>
</div></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_-6697698564752812180WordSection1">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><a name="m_-6697698564752812180__MailOriginalBody">I'm not sure which patch it is, but tons of bots are failing after these.
<u></u><u></u></a></p>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span></span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8011%2Fbuilders%2Fclang-cmake-armv8-quick%2Fbuilds%2F1241&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214799321&sdata=SriT%2F5Hy76lO5c5GQXoU8xmea1M2OMsRc9irxkO0tZM%3D&reserved=0" target="_blank"><span>http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/1241</span><span></span></a><span><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span>as an example.<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span>I'm also seeing it on my local linux box. Can you revert or fix please? :)<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span>Thanks!<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span>-eric<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div>
<div>
<p class="MsoNormal"><span>On Mon, Apr 2, 2018 at 2:47 PM Aaron Smith via llvm-commits <</span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank"><span>llvm-commits@lists.llvm.org</span><span></span></a><span>>
wrote:<u></u><u></u></span></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><span>Author: asmith<br>
Date: Mon Apr 2 14:44:51 2018<br>
New Revision: 329020<br>
<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%3Frev%3D329020%26view%3Drev&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214809325&sdata=oghSinMxmdk1cbu%2BRW9irp%2B%2B9gGRUrMb6LInJlw8%2Bf0%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-project?rev=329020&view=rev</span><span></span></a><span><br>
Log:<br>
[lit] Use io.open to compare two files since it supports different encodings while older versions of open do not<br>
<br>
Modified:<br>
llvm/trunk/utils/lit/lit/TestRunner.py<br>
<br>
Modified: llvm/trunk/utils/lit/lit/TestRunner.py<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Futils%2Flit%2Flit%2FTestRunner.py%3Frev%3D329020%26r1%3D329019%26r2%3D329020%26view%3Ddiff&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214809325&sdata=xisvoMIrUqu1b2VBhZ6d5PCQZ15PtUnG29Nc3Haz5pE%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=329020&r1=329019&r2=329020&view=diff</span><span></span></a><span><br>
==============================================================================<br>
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)<br>
+++ llvm/trunk/utils/lit/lit/TestRunner.py Mon Apr 2 14:44:51 2018<br>
@@ -388,7 +388,7 @@ def executeBuiltinDiff(cmd, cmd_shenv):<br>
def compareTwoFiles(filepaths):<br>
filelines = []<br>
for file in filepaths:<br>
- with open(file, 'r') as f:<br>
+ with io.open(file, 'r') as f:<br>
filelines.append(f.readlines())<br>
<br>
exitCode = 0<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
</span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank"><span>llvm-commits@lists.llvm.org</span><span></span></a><span><br>
</span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214809325&sdata=AUomhGyt0HN%2Bquk7Cf4eyhWM2eoqpHghXQYaNI2s53I%3D&reserved=0" target="_blank"><span>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</span><span></span></a><span><u></u><u></u></span></p>
</blockquote>
</div>
</div></div></blockquote></div>