<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Really sorry about that. I committed that to fix some broke build bots with our patch and at the same time someone reverted my change, which means every bot will break. I’ve already recommitted the complete patch. Would you let me know
if you still have problems locally?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Aaron<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Eric Christopher <echristo@gmail.com><br>
<b>Date: </b>Monday, April 2, 2018 at 3:22 PM<br>
<b>To: </b>Aaron Smith <aaron.smith@microsoft.com><br>
<b>Cc: </b>"llvm-commits@lists.llvm.org" <llvm-commits@lists.llvm.org><br>
<b>Subject: </b>Re: [llvm] r329020 - [lit] Use io.open to compare two files since it supports different encodings while older versions of open do not<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><a name="_MailOriginalBody">I'm not sure which patch it is, but tons of bots are failing after these.
<o:p></o:p></a></p>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"></span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8011%2Fbuilders%2Fclang-cmake-armv8-quick%2Fbuilds%2F1241&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214799321&sdata=SriT%2F5Hy76lO5c5GQXoU8xmea1M2OMsRc9irxkO0tZM%3D&reserved=0"><span style="mso-bookmark:_MailOriginalBody">http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/1241</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">as an example.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">I'm also seeing it on my local linux box. Can you revert or fix please? :)<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">Thanks!<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">-eric<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"><o:p> </o:p></span></p>
<div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">On Mon, Apr 2, 2018 at 2:47 PM Aaron Smith via llvm-commits <</span><a href="mailto:llvm-commits@lists.llvm.org"><span style="mso-bookmark:_MailOriginalBody">llvm-commits@lists.llvm.org</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody">>
wrote:<o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">Author: asmith<br>
Date: Mon Apr 2 14:44:51 2018<br>
New Revision: 329020<br>
<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%3Frev%3D329020%26view%3Drev&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214809325&sdata=oghSinMxmdk1cbu%2BRW9irp%2B%2B9gGRUrMb6LInJlw8%2Bf0%3D&reserved=0" target="_blank"><span style="mso-bookmark:_MailOriginalBody">http://llvm.org/viewvc/llvm-project?rev=329020&view=rev</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><br>
Log:<br>
[lit] Use io.open to compare two files since it supports different encodings while older versions of open do not<br>
<br>
Modified:<br>
llvm/trunk/utils/lit/lit/TestRunner.py<br>
<br>
Modified: llvm/trunk/utils/lit/lit/TestRunner.py<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Futils%2Flit%2Flit%2FTestRunner.py%3Frev%3D329020%26r1%3D329019%26r2%3D329020%26view%3Ddiff&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214809325&sdata=xisvoMIrUqu1b2VBhZ6d5PCQZ15PtUnG29Nc3Haz5pE%3D&reserved=0" target="_blank"><span style="mso-bookmark:_MailOriginalBody">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=329020&r1=329019&r2=329020&view=diff</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><br>
==============================================================================<br>
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)<br>
+++ llvm/trunk/utils/lit/lit/TestRunner.py Mon Apr 2 14:44:51 2018<br>
@@ -388,7 +388,7 @@ def executeBuiltinDiff(cmd, cmd_shenv):<br>
def compareTwoFiles(filepaths):<br>
filelines = []<br>
for file in filepaths:<br>
- with open(file, 'r') as f:<br>
+ with io.open(file, 'r') as f:<br>
filelines.append(f.readlines())<br>
<br>
exitCode = 0<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
</span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank"><span style="mso-bookmark:_MailOriginalBody">llvm-commits@lists.llvm.org</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><br>
</span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=02%7C01%7Caaron.smith%40microsoft.com%7Ce370879489f44283de1108d598e8272f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636583045214809325&sdata=AUomhGyt0HN%2Bquk7Cf4eyhWM2eoqpHghXQYaNI2s53I%3D&reserved=0" target="_blank"><span style="mso-bookmark:_MailOriginalBody">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><o:p></o:p></span></p>
</blockquote>
</div>
</div>
</body>
</html>