<div dir="ltr">Hello again,<div><br></div><div>I'd like approval to pick this follow-up to r328748 into the 6.0 branch, as well. Please let me know what you think.</div><div><br></div><div>Thanks!</div><div>George</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 28, 2018 at 8:12 PM, George Burgess IV via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: gbiv<br>
Date: Wed Mar 28 20:12:03 2018<br>
New Revision: 328755<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=328755&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=328755&view=rev</a><br>
Log:<br>
[MemorySSA] Turn an assert into a condition<br>
<br>
Eli pointed out that variadic functions are totally a thing, so this<br>
assert is incorrect.<br>
<br>
No test-case is provided, since the only way this assert fires is if a<br>
specific DenseMap falls back to doing `isEqual` checks, and that seems<br>
fairly brittle (and requires a pyramid of growing<br>
`call void (i8, ...) @varargs(i8 0)`).<br>
<br>
Modified:<br>
    llvm/trunk/lib/Analysis/Memory<wbr>SSA.cpp<br>
<br>
Modified: llvm/trunk/lib/Analysis/Memory<wbr>SSA.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/MemorySSA.cpp?rev=328755&r1=328754&r2=328755&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Analysis/<wbr>MemorySSA.cpp?rev=328755&r1=<wbr>328754&r2=328755&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Analysis/Memory<wbr>SSA.cpp (original)<br>
+++ llvm/trunk/lib/Analysis/Memory<wbr>SSA.cpp Wed Mar 28 20:12:03 2018<br>
@@ -159,8 +159,8 @@ public:<br>
     if (CS.getCalledValue() != Other.CS.getCalledValue())<br>
       return false;<br>
<br>
-    assert(CS.arg_size() == Other.CS.arg_size());<br>
-    return std::equal(CS.arg_begin(), CS.arg_end(), Other.CS.arg_begin());<br>
+    return CS.arg_size() == Other.CS.arg_size() &&<br>
+           std::equal(CS.arg_begin(), CS.arg_end(), Other.CS.arg_begin());<br>
   }<br>
<br>
 private:<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>