<div dir="ltr">That's ok. I missed that too. I will revert now and add a fix it if it has not already been reverted.<div><br></div><div>-- Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 27, 2018 at 10:46 PM, Andres Freund <span dir="ltr"><<a href="mailto:andres@anarazel.de" target="_blank">andres@anarazel.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<span class=""><br>
On 2018-03-28 03:41:45 -0000, Lang Hames via llvm-commits wrote:<br>
> Author: lhames<br>
> Date: Tue Mar 27 20:41:45 2018<br>
> New Revision: 328687<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=328687&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=328687&view=rev</a><br>
> Log:<br>
> [ORC] Fix ORC on platforms without indirection support.<br>
><br>
> Previously this crashed because a nullptr (returned by<br>
> createLocalIndirectStubsManage<wbr>rBuilder() on platforms without<br>
> indirection support) functor was unconditionally invoked.<br>
><br>
> Patch by Andres Freund. Thanks Andres!<br>
</span><span class="">>  namespace llvm {<br>
> @@ -59,15 +61,20 @@ public:<br>
>        // If we found a TargetMachine, check that it's one that Orc supports.<br>
>        const Triple& TT = TM->getTargetTriple();<br>
><br>
> -      if ((TT.getArch() != Triple::x86_64 && TT.getArch() != Triple::x86) ||<br>
> -          TT.isOSWindows())<br>
> -        TM = nullptr;<br>
> +      // Target can JIT?<br>
> +      SupportsJIT = TM->getTarget().hasJIT();<br>
> +      // Use ability to create callback manager to detect whether Orc<br>
> +      // has indirection support on this platform. This way the test<br>
> +      // and Orc code do not get out of sync.<br>
> +      SupportsIndirection = !!orc::<wbr>createLocalCompileCallbackMana<wbr>ger(TT, 0);<br>
>      }<br>
<br>
</span>It seems this was, for a reason unknown to me, overly aggressive. The<br>
windows check appears to have been critical:<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/16121/steps/test/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-clang-lld-x86_<wbr>64-scei-ps4-windows10pro-fast/<wbr>builds/16121/steps/test/logs/<wbr>stdio</a><br>
<br>
Sorry for that.<br>
<span class="HOEnZb"><font color="#888888"><br>
- Andres<br>
</font></span></blockquote></div><br></div>