<div dir="ltr">I will fix this issue and submit a patch.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 27, 2018 at 5:57 PM Alex Bradbury <<a href="mailto:asb@asbradbury.org">asb@asbradbury.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 27 March 2018 at 09:39, Alex Bradbury <<a href="mailto:asb@asbradbury.org" target="_blank">asb@asbradbury.org</a>> wrote:<br>
> On 26 March 2018 at 19:05, Reid Kleckner via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> Author: rnk<br>
>> Date: Mon Mar 26 11:05:12 2018<br>
>> New Revision: 328563<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=328563&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=328563&view=rev</a><br>
>> Log:<br>
>> [lit] Implement 'cat' command for internal shell<br>
>><br>
>> Fixes PR36449<br>
>><br>
>> Patch by Chamal de Silva<br>
>><br>
>> Differential Revision: <a href="https://reviews.llvm.org/D43501" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43501</a><br>
>><br>
>> Added:<br>
>>     llvm/trunk/utils/lit/lit/builtin_commands/<br>
>>     llvm/trunk/utils/lit/lit/builtin_commands/cat.py<br>
>>     llvm/trunk/utils/lit/tests/Inputs/shtest-shell/cat-error-0.txt<br>
>>     llvm/trunk/utils/lit/tests/Inputs/shtest-shell/cat-error-1.txt<br>
>>     llvm/trunk/utils/lit/tests/Inputs/shtest-shell/cat_nonprinting.bin   (with props)<br>
>> Modified:<br>
>>     llvm/trunk/utils/lit/lit/TestRunner.py<br>
>>     llvm/trunk/utils/lit/tests/Inputs/shtest-shell/valid-shell.txt<br>
>>     llvm/trunk/utils/lit/tests/max-failures.py<br>
>>     llvm/trunk/utils/lit/tests/shtest-shell.py<br>
><br>
> This is triggering new test failures for me on an ArchLinux host. I'm<br>
> assuming this is a Python2/3 issue: Arch makes the questionable choice<br>
> of symlinking /usr/bin/python to /usr/bin/python3. Though we can see<br>
> that /usr/bin/python2.7 is being invoked directly to execute the main<br>
> lit.py entry point at least.<br>
><br>
> See <a href="http://lab.llvm.org:8014/builders/llvm-riscv-linux/builds/2582/steps/test-llvm/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8014/builders/llvm-riscv-linux/builds/2582/steps/test-llvm/logs/stdio</a><br>
><br>
> Sample failure:<br>
><br>
> FAIL: lit :: shtest-shell.py (24657 of 24663)<br>
> ******************** TEST 'lit :: shtest-shell.py' FAILED ********************<br>
> Script:<br>
> --<br>
> not /usr/bin/python2.7<br>
> /srv/buildslave/llvm-riscv-linux/llvm.src/utils/lit/lit.py -j 1 -v<br>
> /srv/buildslave/llvm-riscv-linux/llvm.obj/utils/lit/tests/../tests/Inputs/shtest-shell<br>
>> /srv/buildslave/llvm-riscv-linux/llvm.obj/utils/lit/tests/Output/shtest-shell.py.tmp.out<br>
> cat /srv/buildslave/llvm-riscv-linux/llvm.obj/utils/lit/tests/Output/shtest-shell.py.tmp.out<br>
> FileCheck --input-file<br>
> /srv/buildslave/llvm-riscv-linux/llvm.obj/utils/lit/tests/Output/shtest-shell.py.tmp.out<br>
> /srv/buildslave/llvm-riscv-linux/llvm.obj/utils/lit/tests/shtest-shell.py<br>
> --<br>
> Exit Code: 1<br>
><br>
> Command Output (stdout):<br>
> --<br>
> $ "not" "/usr/bin/python2.7"<br>
> "/srv/buildslave/llvm-riscv-linux/llvm.src/utils/lit/lit.py" "-j" "1"<br>
> "-v" "/srv/buildslave/llvm-riscv-linux/llvm.obj/utils/lit/tests/../tests/Inputs/shtest-shell"<br>
> $ "cat" "/srv/buildslave/llvm-riscv-linux/llvm.obj/utils/lit/tests/Output/shtest-shell.py.tmp.out"<br>
> # command stderr:<br>
> Traceback (most recent call last):<br>
>   File "/srv/buildslave/llvm-riscv-linux/llvm.src/utils/lit/lit/builtin_commands/cat.py",<br>
> line 59, in <module><br>
>     main(sys.argv)<br>
>   File "/srv/buildslave/llvm-riscv-linux/llvm.src/utils/lit/lit/builtin_commands/cat.py",<br>
> line 51, in main<br>
>     sys.stdout.write(contents)<br>
> TypeError: write() argument must be str, not bytes<br>
><br>
> error: command failed with exit status: 1<br>
<br>
Adding original patch author to CC.<br>
</blockquote></div>