<div dir="ltr">Thanks - though I'm not able to reproduce these failures on a modules-enabled build on linux, strangely (I do get some /other/ modules errors, though - and a link error I couldn't figure out). I've fixed what looks to be the issue & recommitted in r328123. It looked like it was a relatively simple case - might be worth trying to fix forward if you have a moment to look, if similar failures show up?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 21, 2018 at 3:39 AM Jonas Devlieghere <<a href="mailto:jdevlieghere@apple.com">jdevlieghere@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi David,<br>
<br>
I reverted this and your previous commit in r328085<br>
<br>
— Jonas<br>
<br>
> On Mar 21, 2018, at 9:24 AM, Jonas Devlieghere <<a href="mailto:jdevlieghere@apple.com" target="_blank">jdevlieghere@apple.com</a>> wrote:<br>
><br>
> Hi David,<br>
><br>
> Our second stage bots are still failing with your follow-up commit.<br>
><br>
> FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o<br>
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/host-compiler/bin/clang++  -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support -I/usr/include/libxml2 -Iinclude -I/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/clang-build/module.cache -fcxx-modules -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics -fprofile-instr-generate='/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/clang-build/profiles/%6m.profraw' -fcoverage-mapping -O3 -DNDEBUG    -fno-exceptions -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o -c /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp<br>
> While building module 'LLVM_Utils' imported from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp:10:<br>
> While building module 'LLVM_C' imported from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm/Support/MemoryBuffer.h:17:<br>
> In file included from <module-includes>:1:<br>
> In file included from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm-c/./Support.h:18:<br>
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm-c/Types.h:17:10: fatal error: cyclic dependency in module 'LLVM_Utils': LLVM_Utils -> LLVM_C -> LLVM_Utils<br>
> #include "llvm/Support/DataTypes.h"<br>
>         ^<br>
> While building module 'LLVM_Utils' imported from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp:10:<br>
> In file included from <module-includes>:89:<br>
> In file included from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm/Support/BinaryByteStream.h:20:<br>
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm/Support/MemoryBuffer.h:17:10: fatal error: could not build module 'LLVM_C'<br>
> #include "llvm-c/Types.h"<br>
> ~~~~~~~~^~~~~~~~~~~~~~~~<br>
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp:10:10: fatal error: could not build module 'LLVM_Utils'<br>
> #include "llvm/Support/BinaryStreamError.h"<br>
> ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
> 3 errors generated.<br>
><br>
> In case you’re still awake, can you have a look before I have to revert these again?<br>
><br>
> The two affected (public) bots are:<br>
> <a href="http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/" rel="noreferrer" target="_blank">http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/</a><br>
> <a href="http://green.lab.llvm.org/green/job/clang-stage2-configure-Rlto/" rel="noreferrer" target="_blank">http://green.lab.llvm.org/green/job/clang-stage2-configure-Rlto/</a><br>
><br>
> Cheers,<br>
> Jonas<br>
><br>
>> On Mar 21, 2018, at 4:07 AM, David Blaikie via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: dblaikie<br>
>> Date: Tue Mar 20 21:07:07 2018<br>
>> New Revision: 328073<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=328073&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=328073&view=rev</a><br>
>> Log:<br>
>> Fix the actual user of DataTypes.h in llvm-c to avoid the circular dependency<br>
>><br>
>> (follow-up to r328065)<br>
>><br>
>> Modified:<br>
>>   llvm/trunk/include/llvm-c/Support.h<br>
>><br>
>> Modified: llvm/trunk/include/llvm-c/Support.h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm-c/Support.h?rev=328073&r1=328072&r2=328073&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm-c/Support.h?rev=328073&r1=328072&r2=328073&view=diff</a><br>
>> ==============================================================================<br>
>> --- llvm/trunk/include/llvm-c/Support.h (original)<br>
>> +++ llvm/trunk/include/llvm-c/Support.h Tue Mar 20 21:07:07 2018<br>
>> @@ -14,8 +14,8 @@<br>
>> #ifndef LLVM_C_SUPPORT_H<br>
>> #define LLVM_C_SUPPORT_H<br>
>><br>
>> +#include "llvm-c/DataTypes.h"<br>
>> #include "llvm-c/Types.h"<br>
>> -#include "llvm/Support/DataTypes.h"<br>
>><br>
>> #ifdef __cplusplus<br>
>> extern "C" {<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
</blockquote></div>