<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 21, 2018, at 5:36 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thanks - though I'm not able to reproduce these failures on a modules-enabled build on linux, strangely (I do get some /other/ modules errors, though - and a link error I couldn't figure out). I've fixed what looks to be the issue & recommitted in r328123. </div></div></blockquote><div><br class=""></div><div>Thanks David!</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">It looked like it was a relatively simple case - might be worth trying to fix forward if you have a moment to look, if similar failures show up?</div></div></blockquote><div><br class=""></div><div>Sure, I’ll do my best. </div></div><div><br class=""><blockquote type="cite" class=""><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, Mar 21, 2018 at 3:39 AM Jonas Devlieghere <<a href="mailto:jdevlieghere@apple.com" class="">jdevlieghere@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi David,<br class="">
<br class="">
I reverted this and your previous commit in r328085<br class="">
<br class="">
— Jonas<br class="">
<br class="">
> On Mar 21, 2018, at 9:24 AM, Jonas Devlieghere <<a href="mailto:jdevlieghere@apple.com" target="_blank" class="">jdevlieghere@apple.com</a>> wrote:<br class="">
><br class="">
> Hi David,<br class="">
><br class="">
> Our second stage bots are still failing with your follow-up commit.<br class="">
><br class="">
> FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o<br class="">
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/host-compiler/bin/clang++ -DGTEST_HAS_RTTI=0 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support -I/usr/include/libxml2 -Iinclude -I/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -fmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/clang-build/module.cache -fcxx-modules -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics -fprofile-instr-generate='/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/clang-build/profiles/%6m.profraw' -fcoverage-mapping -O3 -DNDEBUG -fno-exceptions -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamError.cpp.o -c /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp<br class="">
> While building module 'LLVM_Utils' imported from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp:10:<br class="">
> While building module 'LLVM_C' imported from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm/Support/MemoryBuffer.h:17:<br class="">
> In file included from <module-includes>:1:<br class="">
> In file included from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm-c/./Support.h:18:<br class="">
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm-c/Types.h:17:10: fatal error: cyclic dependency in module 'LLVM_Utils': LLVM_Utils -> LLVM_C -> LLVM_Utils<br class="">
> #include "llvm/Support/DataTypes.h"<br class="">
> ^<br class="">
> While building module 'LLVM_Utils' imported from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp:10:<br class="">
> In file included from <module-includes>:89:<br class="">
> In file included from /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm/Support/BinaryByteStream.h:20:<br class="">
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/include/llvm/Support/MemoryBuffer.h:17:10: fatal error: could not build module 'LLVM_C'<br class="">
> #include "llvm-c/Types.h"<br class="">
> ~~~~~~~~^~~~~~~~~~~~~~~~<br class="">
> /Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/lib/Support/BinaryStreamError.cpp:10:10: fatal error: could not build module 'LLVM_Utils'<br class="">
> #include "llvm/Support/BinaryStreamError.h"<br class="">
> ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br class="">
> 3 errors generated.<br class="">
><br class="">
> In case you’re still awake, can you have a look before I have to revert these again?<br class="">
><br class="">
> The two affected (public) bots are:<br class="">
> <a href="http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/" rel="noreferrer" target="_blank" class="">http://green.lab.llvm.org/green/job/clang-stage2-coverage-R/</a><br class="">
> <a href="http://green.lab.llvm.org/green/job/clang-stage2-configure-Rlto/" rel="noreferrer" target="_blank" class="">http://green.lab.llvm.org/green/job/clang-stage2-configure-Rlto/</a><br class="">
><br class="">
> Cheers,<br class="">
> Jonas<br class="">
><br class="">
>> On Mar 21, 2018, at 4:07 AM, David Blaikie via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
>><br class="">
>> Author: dblaikie<br class="">
>> Date: Tue Mar 20 21:07:07 2018<br class="">
>> New Revision: 328073<br class="">
>><br class="">
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=328073&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=328073&view=rev</a><br class="">
>> Log:<br class="">
>> Fix the actual user of DataTypes.h in llvm-c to avoid the circular dependency<br class="">
>><br class="">
>> (follow-up to r328065)<br class="">
>><br class="">
>> Modified:<br class="">
>> llvm/trunk/include/llvm-c/Support.h<br class="">
>><br class="">
>> Modified: llvm/trunk/include/llvm-c/Support.h<br class="">
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm-c/Support.h?rev=328073&r1=328072&r2=328073&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm-c/Support.h?rev=328073&r1=328072&r2=328073&view=diff</a><br class="">
>> ==============================================================================<br class="">
>> --- llvm/trunk/include/llvm-c/Support.h (original)<br class="">
>> +++ llvm/trunk/include/llvm-c/Support.h Tue Mar 20 21:07:07 2018<br class="">
>> @@ -14,8 +14,8 @@<br class="">
>> #ifndef LLVM_C_SUPPORT_H<br class="">
>> #define LLVM_C_SUPPORT_H<br class="">
>><br class="">
>> +#include "llvm-c/DataTypes.h"<br class="">
>> #include "llvm-c/Types.h"<br class="">
>> -#include "llvm/Support/DataTypes.h"<br class="">
>><br class="">
>> #ifdef __cplusplus<br class="">
>> extern "C" {<br class="">
>><br class="">
>><br class="">
>> _______________________________________________<br class="">
>> llvm-commits mailing list<br class="">
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
><br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>