<div dir="ltr">It appears to have shown up recently. I've also pointed Richard at it.<div><br></div><div>I just did a clean release build and a clean release+asserts build of llvm and it showed up.</div><div><br></div><div>-eric<br><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 20, 2018 at 12:07 PM Krzysztof Parzyszek <<a href="mailto:kparzysz@codeaurora.org">kparzysz@codeaurora.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is a surprise to me. Are you seeing it on some buildbot as well?<br>
<br>
In any case, I'll take a look.<br>
<br>
-Krzysztof<br>
<br>
On 3/20/2018 1:56 PM, Eric Christopher wrote:<br>
> I'm sure.<br>
><br>
> That said, you've got some warnings in the code with a ToT clang now:<br>
><br>
> [1961/3415] Building CXX object<br>
> lib/Target/Hexagon/MCTargetDesc/CMakeFiles/LLVMHexagonDesc.dir/HexagonMCDuplexInfo.cpp.o<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp:<br>
> In function ‘llvm::MCInst llvm::HexagonMCInstrInfo::deriveSubInst(const<br>
> llvm::MCInst&)’:<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp:786:5:<br>
> warning: this statement may fall through [-Wimplicit-fallthrough=]<br>
>       if (Value == 2) {<br>
>       ^~<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp:792:3:<br>
> note: here<br>
>     case Hexagon::A4_combineir:<br>
>     ^~~~<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp:898:12:<br>
> warning: this statement may fall through [-Wimplicit-fallthrough=]<br>
>       } else if (Value == 1) {<br>
>              ^~<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp:904:3:<br>
> note: here<br>
>     case Hexagon::S2_storerb_io:<br>
>     ^~~~<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp:934:12:<br>
> warning: this statement may fall through [-Wimplicit-fallthrough=]<br>
>       } else if (Inst.getOperand(0).getReg() == Hexagon::R29) {<br>
>              ^~<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCDuplexInfo.cpp:940:3:<br>
> note: here<br>
>     case Hexagon::S2_storeri_io:<br>
>     ^~~~<br>
> [2042/3415] Building CXX object<br>
> lib/Target/Hexagon/AsmParser/CMakeFiles/LLVMHexagonAsmParser.dir/HexagonAsmParser.cpp.o<br>
> In file included from<br>
> /usr/local/google/home/echristo/sources/llvm/include/llvm/ADT/StringRef.h:13:0,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/include/llvm/ADT/StringMap.h:17,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/include/llvm/Support/Host.h:17,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/include/llvm/ADT/Hashing.h:49,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/include/llvm/ADT/ArrayRef.h:13,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/include/llvm/Support/CommandLine.h:23,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/MCTargetDesc/HexagonMCTargetDesc.h:17,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/Hexagon.h:45,<br>
>                   from<br>
> /usr/local/google/home/echristo/sources/llvm/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp:12:<br>
> /usr/local/google/home/echristo/sources/llvm/include/llvm/ADT/STLExtras.h:886:6:<br>
> warning: mangled name for ‘decltype (llvm::adl_begin(Range))<br>
> llvm::remove_if(R&&, UnaryPredicate) [with R =<br>
> std::__cxx11::basic_string<char>&; UnaryPredicate = int (*)(int) throw<br>
> ()]’ will change in C++17 because the exception specification is part of<br>
> a function type [-Wnoexcept-type]<br>
>   auto remove_if(R &&Range, UnaryPredicate P) -><br>
> decltype(adl_begin(Range)) {<br>
>        ^~~~~~~~~<br>
><br>
> I looked at trying to fix, but I don't know how your processor works. :)<br>
><br>
> -eric<br>
><br>
> On Tue, Mar 20, 2018 at 11:53 AM Krzysztof Parzyszek<br>
> <<a href="mailto:kparzysz@codeaurora.org" target="_blank">kparzysz@codeaurora.org</a> <mailto:<a href="mailto:kparzysz@codeaurora.org" target="_blank">kparzysz@codeaurora.org</a>>> wrote:<br>
><br>
>     I've tried. Going from V62 to V65 was quite a large change, and locally<br>
>     we had lots of interdependent patches implementing it, intertwined with<br>
>     unrelated changes to the same components. In the end it saved me a lot<br>
>     of time to just lump it all together.<br>
><br>
>     -Krzysztof<br>
><br>
>     On 3/20/2018 1:44 PM, Eric Christopher wrote:<br>
>      > For the record you really should have broken this up into<br>
>     separate commits.<br>
>      ><br>
>      >   69 files changed, 13364 insertions(+), 5905 deletions(-)<br>
>      ><br>
>      > -eric<br>
>      ><br>
><br>
>     --<br>
>     Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,<br>
>     hosted by The Linux Foundation<br>
><br>
<br>
--<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,<br>
hosted by The Linux Foundation<br>
</blockquote></div></div></div>