<div dir="ltr">Hi George,<div><br></div><div>Thanks for fixing this. I'm still seeing build warnings for this. Could you please take a look? Thanks!<div><span style="white-space:pre-wrap;font-weight:bold"><br></span></div><div><span style="white-space:pre-wrap;font-weight:bold">llvm/tools/lld/ELF/LinkerScript.h:194:32: </span><span style="white-space:pre-wrap;font-weight:bold;color:rgb(102,0,0)">error: </span><span style="white-space:pre-wrap;font-weight:bold">field 'Expression' will be initialized after field 'CommandString' [-Werror,-Wreorder]</span></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 15, 2018 at 10:27 AM George Rimar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grimar<br>
Date: Thu Mar 15 02:24:51 2018<br>
New Revision: 327613<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=327613&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=327613&view=rev</a><br>
Log:<br>
[ELF] - Fix build bot after rL327612.<br>
<br>
Error was:<br>
error: field 'Size' will be initialized after field 'CommandString' [-Werror,-Wreorder]<br>
<br>
Modified:<br>
    lld/trunk/ELF/LinkerScript.h<br>
<br>
Modified: lld/trunk/ELF/LinkerScript.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.h?rev=327613&r1=327612&r2=327613&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.h?rev=327613&r1=327612&r2=327613&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/LinkerScript.h (original)<br>
+++ lld/trunk/ELF/LinkerScript.h Thu Mar 15 02:24:51 2018<br>
@@ -191,8 +191,8 @@ struct AssertCommand : BaseCommand {<br>
 // Represents BYTE(), SHORT(), LONG(), or QUAD().<br>
 struct ByteCommand : BaseCommand {<br>
   ByteCommand(Expr E, unsigned Size, std::string CommandString)<br>
-      : BaseCommand(ByteKind), Expression(E), Size(Size),<br>
-        CommandString(CommandString) {}<br>
+      : BaseCommand(ByteKind), Expression(E), CommandString(CommandString),<br>
+        Size(Size) {}<br>
<br>
   static bool classof(const BaseCommand *C) { return C->Kind == ByteKind; }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>