<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<pre class="moz-signature" cols="72">I don't think it is very bad if check for DW_AT_ranges here just to be sure that we don't miss anything important.
-------------
Best regards,
Alexey Bataev</pre>
<div class="moz-cite-prefix">12.03.2018 15:52, David Blaikie пишет:<br>
</div>
<blockquote type="cite"
cite="mid:CAENS6EtZUfM-XX5D0NTDe+2X+BPSdU1vsDFBdartY_dEzahLYg@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div dir="ltr"><br>
<br>
<div class="gmail_quote">
<div dir="ltr">On Mon, Mar 12, 2018 at 12:52 PM Alexey Bataev
via Phabricator <<a
href="mailto:reviews@reviews.llvm.org"
moz-do-not-send="true">reviews@reviews.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">ABataev
added inline comments.<br>
<br>
<br>
================<br>
Comment at: test/DebugInfo/X86/no_debug_ranges.ll:4<br>
+<br>
+; DISABLED-NOT: {{DW_AT_ranges|.debug_ranges}}<br>
+; DISABLED: .section .debug_info<br>
----------------<br>
dblaikie wrote:<br>
> probably check for only .debug_ranges here? (since it's
outside the debug_info section, so any mention of
DW_AT_ranges wouldn't be too relevant (short of the abbrev
section, but no need to check for that when you're checking
for the contents of debug_info anyway, I think))<br>
There can be .debug_abbrev section with DW_AT_ranges, we
need to be sure that no ranges info is generated<br>
</blockquote>
<div><br>
Right, but the same property is already tested for in the
debug_info section testing, I think.<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
================<br>
Comment at: test/DebugInfo/X86/no_debug_ranges.ll:6<br>
+; DISABLED: .section .debug_info<br>
+; DISABLED-NOT: {{DW_AT_ranges|.debug_ranges}}<br>
+; DISABLED: .quad .Lfunc_begin0 # DW_AT_low_pc<br>
----------------<br>
dblaikie wrote:<br>
> probably replace ".debug_ranges" with ".section" here?
(ie: make sure the low/high pc you're checking for is in the
debug_info section, and make sure that section doesn't
include a DW_AT_ranges)<br>
Ok<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a
href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD44384&data=02%7C01%7C%7C6f3b03b9a3444c054aea08d58852e00d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636564811876790866&sdata=48m0QgR7C7ERWO02AhQbmxZTTtTAQfx%2B4992f0r4s08%3D&reserved=0"
originalsrc="https://reviews.llvm.org/D44384"
shash="LMjuJq+F9pns7/z4N//V7sgW5IlYoKJ6HESPgYvbLcwmF/MW0CRe8C6imqmC3XcLyW3sUx5J8Sy3AuwJlPSyMOq3omm6vD7Gt1VySvLTCatKMg16KC32bI0gZoHLIZymmxiNhrISs38bbsw66UaGcGxVIwAd+ZRgQGgjxls+BRU="
rel="noreferrer" target="_blank" moz-do-not-send="true">https://reviews.llvm.org/D44384</a><br>
<br>
<br>
<br>
</blockquote>
</div>
</div>
</blockquote>
<br>
</body>
</html>