<div dir="ltr"><div>Yes, I will recommit this. But, as you say, there is a conflict that I need to deal with. If you - or others - want this recommitted, let me know and I'll bump it up on my list. Hmmm... it's actually fairly high anyway. The "old" waitcnt pass has been a proxy for debugging the "new" waitcnt pass. I've been meaning to remove the old waitcnt pass; I'll make sure the debugging options for the new waitcnt pass are available before removing the old one.<br><br></div>Mark<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 7, 2018 at 3:21 PM, Matt Arsenault <span dir="ltr"><<a href="mailto:arsenm2@gmail.com" target="_blank">arsenm2@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
> On Jan 30, 2018, at 12:17, Mark Searles via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: msearles<br>
> Date: Tue Jan 30 09:17:06 2018<br>
> New Revision: 323791<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=323791&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=323791&view=rev</a><br>
> Log:<br>
> [AMDGPU] Revert "[AMDGPU] Add options for waitcnt pass debugging; add instr count in debug output."<br>
><br>
> Patch caused a buildbot failure; arg; <a href="http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/17373/s\" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/lld-x86_64-darwin13/<wbr>builds/17373/s\</a><br>
> teps/build_Lld/logs/stdio :<br>
>        /Users/buildslave/as-bldslv9/<wbr>lld-x86_64-darwin13/llvm.src/<wbr>lib/Target/AMDGPU/<wbr>SIInsertWaitcnts.cpp:1563:18: error: unused variable 'InstCnt' [-Werror,-Wunused-variable]<br>
>          static int32_t InstCnt = 0;<br>
>                                              "<br>
> This reverts commit 4f4a7d61e306b67044d9f16bc2016f<wbr>ee806bc2cc.<br>
><br>
> Removed:<br>
>    llvm/trunk/test/CodeGen/<wbr>AMDGPU/waitcnt-debug.mir<br>
> Modified:<br>
>    llvm/trunk/lib/Target/AMDGPU/<wbr>SIInsertWaitcnts.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/AMDGPU/<wbr>SIInsertWaitcnts.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SIInsertWaitcnts.cpp?rev=323791&r1=323790&r2=323791&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>AMDGPU/SIInsertWaitcnts.cpp?<wbr>rev=323791&r1=323790&r2=<wbr>323791&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Target/AMDGPU/<wbr>SIInsertWaitcnts.cpp (original)<br>
> +++ llvm/trunk/lib/Target/AMDGPU/<wbr>SIInsertWaitcnts.cpp Tue Jan 30 09:17:06 2018<br>
> @@ -54,26 +54,6 @@<br>
><br>
<br>
<br>
</span>Are you planning on recommitting this? There seems to be a large conflict with another patch since then<br>
<span class="HOEnZb"><font color="#888888"><br>
-Matt</font></span></blockquote></div><br></div>