<div dir="ltr"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">By the way, you can configure your git to use this for binary diff if you would define an external diff driver. To do so add a section to your $GIT_DIR/config file (or $HOME/.gitconfig file) similar to this:</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><div><br></div><div>[diff "bin"]</div><div>    textconv = xxd</div></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">Thanks<br><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">Galina<br></div>

<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 6, 2018 at 3:20 PM, Galina Kistanova <span dir="ltr"><<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Aaron,<br><br>Thanks for fixing that!<span class=""><br><br>> What is the command you use to create a diff?<br><br></span>Usually, one would hex dump first and then diff like regular text files, maybe side-by-side. Something like this:<br><br>$ diff -y <(xxd foo1.bin) <(xxd foo2.bin)<br><br>You can configure your git to use this for binary diff in the <br><br>If the binary files are large, limit would help dumping just chunk by chunk.<br><br>Thanks<span class="HOEnZb"><font color="#888888"><br><br>Galina</font></span><div><div class="h5"><br><br><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 6, 2018 at 11:24 AM, Aaron Smith <span dir="ltr"><<a href="mailto:aaron.smith@microsoft.com" target="_blank">aaron.smith@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">





<div link="blue" vlink="purple" lang="EN-US">
<div class="m_7379146224955400593m_-6286188767787614846WordSection1">
<p class="MsoNormal">Hi Galina,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Thanks for letting me know. It’s because the pdb is 0 bytes. I will push the correct binary.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">What is the command you use to create a diff? My way doesn’t work with binary files apparently.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">git diff -U999999 master > mypatch.diff<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">thanks,<u></u><u></u></p>
<p class="MsoNormal">Aaron<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Galina Kistanova <<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>><br>
<b>Date: </b>Tuesday, March 6, 2018 at 11:11 AM<br>
<b>To: </b>Aaron Smith <<a href="mailto:aaron.smith@microsoft.com" target="_blank">aaron.smith@microsoft.com</a>><br>
<b>Cc: </b>Artur Pilipenko via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: [llvm] r326731 - [llvm-pdbdump] Dump restrict type qualifier<u></u><u></u></span></p>
</div><div><div class="m_7379146224955400593h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><a name="m_7379146224955400593_m_-6286188767787614846__MailOriginalBody">Hello Aaron,<br>
<br>
One of added tests broke few builders:<br>
<br>
</a><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8011%2Fbuilders%2Fllvm-clang-lld-x86_64-scei-ps4-windows10pro-fast%2Fbuilds%2F15737&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813685633%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=kg5SrR5A%2BvVTjzEcjNLA5FAc2IDJxEtQX8RpM5dBtWw%3D&reserved=0" target="_blank"><span>http://lab.llvm.org:8011/build<wbr>ers/llvm-clang-lld-x86_64-<wbr>scei-ps4-windows10pro-fast/bui<wbr>lds/15737</span><span></span></a><span><br>
</span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flab.llvm.org%3A8011%2Fbuilders%2Fllvm-clang-x86_64-expensive-checks-win&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813685633%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=LzGWUDLDn6j%2Fh2pvwVknMmyZ4zKSD08UEWH%2Btzvjgu0%3D&reserved=0" target="_blank"><span>http://lab.llvm.org:8011/build<wbr>ers/llvm-clang-x86_64-expensiv<wbr>e-checks-win</span><span></span></a><span><br>
<br>
Failing Tests (3):<br>
. . .<br>
    LLVM :: tools/llvm-pdbdump/type-qualif<wbr>iers.test<br>
<br>
Please have a look?<br>
<br>
Thanks<br>
<br>
Galina<u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span>On Mon, Mar 5, 2018 at 10:29 AM, Aaron Smith via llvm-commits <</span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank"><span>llvm-commits@lists.llvm.org</span><span></span></a><span>>
 wrote:<u></u><u></u></span></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><span>Author: asmith<br>
Date: Mon Mar  5 10:29:43 2018<br>
New Revision: 326731<br>
<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%3Frev%3D326731%26view%3Drev&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813685633%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=vRhZ9g2Gr%2BtrbZH6aL074MRjybbVXqZ78g5G%2FEYX570%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=326731&view=rev</span><span></span></a><span><br>
Log:<br>
[llvm-pdbdump] Dump restrict type qualifier<br>
<br>
Reviewers: zturner, llvm-commits, rnk<br>
<br>
Reviewed By: zturner<br>
<br>
Subscribers: majnemer<br>
<br>
Differential Revision: </span><a href="https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD43639&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=q7f0ftQbJbg56yHIEuHFq5F%2BfjOlQQUWtlR9crACI1E%3D&reserved=0" target="_blank"><span>https://reviews.llvm.org/D4363<wbr>9</span><span></span></a><span><br>
<br>
Added:<br>
    llvm/trunk/test/tools/llvm-pdb<wbr>dump/Inputs/TypeQualifiersTest<wbr>.cpp<br>
    llvm/trunk/test/tools/llvm-pdb<wbr>dump/Inputs/TypeQualifiersTest<wbr>.pdb<br>
    llvm/trunk/test/tools/llvm-pdb<wbr>dump/type-qualifiers.test<br>
Modified:<br>
    llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyFunctionDumper.cpp<br>
    llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyTypedefDumper.cpp<br>
    llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyVariableDumper.cpp<br>
<br>
Added: llvm/trunk/test/tools/llvm-pdb<wbr>dump/Inputs/TypeQualifiersTest<wbr>.cpp<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Ftest%2Ftools%2Fllvm-pdbdump%2FInputs%2FTypeQualifiersTest.cpp%3Frev%3D326731%26view%3Dauto&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=Kd8voF32zioDi8y1q6xHvGh%2BcdFKR6sf2Jvio%2F%2Bwv8A%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/test/tools/ll<wbr>vm-pdbdump/Inputs/TypeQualifie<wbr>rsTest.cpp?rev=326731&view=<wbr>auto</span><span></span></a><span><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/llvm-pdb<wbr>dump/Inputs/TypeQualifiersTest<wbr>.cpp (added)<br>
+++ llvm/trunk/test/tools/llvm-pdb<wbr>dump/Inputs/TypeQualifiersTest<wbr>.cpp Mon Mar  5 10:29:43 2018<br>
@@ -0,0 +1,55 @@<br>
+// Compile with "cl /c /Zi /GR- TypeQualifiersTest.cpp"<br>
+// Link with "link TypeQualifiersTest.obj /debug /nodefaultlib /entry:main"<br>
+<br>
+union Union {<br>
+  int * __restrict x_member;<br>
+  float * __restrict y_member;<br>
+  int* volatile __restrict m_volatile;<br>
+  const char* m_const;<br>
+};<br>
+<br>
+int f(const volatile int* __restrict arg_crv) {<br>
+  Union u;<br>
+  return 1;<br>
+}<br>
+<br>
+void g(int& __restrict arg_ref) {<br>
+}<br>
+<br>
+namespace NS {<br>
+  class Class {<br>
+  public:<br>
+    int get() const { return 1;}<br>
+    int set() __restrict { return 2; }<br>
+    void help() volatile { return; }<br>
+  };<br>
+<br>
+  struct Foo {<br>
+    int a;<br>
+    int b;<br>
+    int func(int x) __restrict { return 1; }<br>
+  };<br>
+<br>
+  Foo s = { 10 };<br>
+<br>
+  const int* __restrict p_object = &s.a;<br>
+<br>
+  volatile int Foo:: * __restrict p_data_member = &Foo::a;<br>
+<br>
+  int (Foo::* p_member_func)(int) __restrict = &Foo::func;<br>
+}<br>
+<br>
+typedef long* __restrict RestrictTypedef;<br>
+RestrictTypedef RestrictVar;<br>
+<br>
+typedef volatile int* __restrict RankNArray[10][100];<br>
+RankNArray ArrayVar;<br>
+<br>
+int main() {<br>
+  NS::Class ClassVar;<br>
+  ClassVar.get();<br>
+  ClassVar.help();<br>
+  ClassVar.set();<br>
+<br>
+  return 0;<br>
+}<br>
<br>
Added: llvm/trunk/test/tools/llvm-pdb<wbr>dump/Inputs/TypeQualifiersTest<wbr>.pdb<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Ftest%2Ftools%2Fllvm-pdbdump%2FInputs%2FTypeQualifiersTest.pdb%3Frev%3D326731%26view%3Dauto&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=Q%2FYBFVJqreahX33AKUnGVX3sJrcew7p1wmeo3ZmQpy0%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/test/tools/ll<wbr>vm-pdbdump/Inputs/TypeQualifie<wbr>rsTest.pdb?rev=326731&view=<wbr>auto</span><span></span></a><span><br>
==============================<wbr>==============================<wbr>==================<br>
    (empty)<br>
<br>
Added: llvm/trunk/test/tools/llvm-pdb<wbr>dump/type-qualifiers.test<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Ftest%2Ftools%2Fllvm-pdbdump%2Ftype-qualifiers.test%3Frev%3D326731%26view%3Dauto&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=LZHfoD%2BDiZzr8nmaQYZeZKbPuISQ6RPjyPsJUxQUSzs%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/test/tools/ll<wbr>vm-pdbdump/type-qualifiers.tes<wbr>t?rev=326731&view=auto</span><span></span></a><span><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/llvm-pdb<wbr>dump/type-qualifiers.test (added)<br>
+++ llvm/trunk/test/tools/llvm-pdb<wbr>dump/type-qualifiers.test Mon Mar  5 10:29:43 2018<br>
@@ -0,0 +1,25 @@<br>
+; RUN: llvm-pdbutil pretty -all -class-recurse-depth=1 \<br>
+; RUN:   %p/Inputs/TypeQualifiersTest.<wbr>pdb > %t<br>
+; RUN: FileCheck -input-file=%t %s -check-prefix=GLOBALS_FUNC<br>
+; RUN: FileCheck -input-file=%t %s -check-prefix=GLOBALS_DATA<br>
+; RUN: FileCheck -input-file=%t %s -check-prefix=QUALS<br>
+<br>
+; GLOBALS_FUNC: ---GLOBALS---<br>
+; GLOBALS_FUNC-DAG: int __cdecl f(const volatile int* __restrict arg_crv)<br>
+; GLOBALS_FUNC-DAG: void __cdecl g(int& __restrict arg_ref)<br>
+<br>
+; GLOBALS_DATA: ---GLOBALS---<br>
+; GLOBALS_DATA-DAG: static volatile int* __restrict ArrayVar[10][100]<br>
+; GLOBALS_DATA-DAG: static long* __restrict RestrictVar<br>
+; GLOBALS_DATA-DAG: static const int* __restrict NS::p_object<br>
+; GLOBALS_DATA-DAG: static NS::Foo NS::s<br>
+; GLOBALS_DATA-DAG: static volatile int* __restrict NS::p_data_member<br>
+<br>
+; QUALS: ---TYPES---<br>
+; QUALS-DAG: typedef RankNArray<br>
+; QUALS-DAG: typedef long* __restrict RestrictTypedef<br>
+; QUALS: union Union<br>
+; QUALS-DAG: int* __restrict x_member<br>
+; QUALS-DAG: float* __restrict y_member<br>
+; QUALS-DAG: int* volatile __restrict m_volatile<br>
+; QUALS-DAG: const char* m_const<br>
<br>
Modified: llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyFunctionDumper.cpp<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Ftools%2Fllvm-pdbutil%2FPrettyFunctionDumper.cpp%3Frev%3D326731%26r1%3D326730%26r2%3D326731%26view%3Ddiff&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=Hegbc3Ds4vKsScZdg%2FettNUzCEyifw3v77qRGQZwP74%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/tools/llvm-pd<wbr>butil/PrettyFunctionDumper.cpp<wbr>?rev=326731&r1=326730&r2=32673<wbr>1&view=diff</span><span></span></a><span><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyFunctionDumper.cpp (original)<br>
+++ llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyFunctionDumper.cpp Mon Mar  5 10:29:43 2018<br>
@@ -252,6 +252,9 @@ void FunctionDumper::dump(const PDBSymbo<br>
       WithColor(Printer, PDB_ColorItem::Keyword).get() << "volatile ";<br>
     PointeeType->dump(*this);<br>
     Printer << (Symbol.isReference() ? "&" : "*");<br>
+<br>
+    if (Symbol.getRawSymbol().isRestr<wbr>ictedType())<br>
+      WithColor(Printer, PDB_ColorItem::Keyword).get() << " __restrict";<br>
   }<br>
 }<br>
<br>
<br>
Modified: llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyTypedefDumper.cpp<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Ftools%2Fllvm-pdbutil%2FPrettyTypedefDumper.cpp%3Frev%3D326731%26r1%3D326730%26r2%3D326731%26view%3Ddiff&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=ZRYqgnFpCgsbI%2B7NdL%2Fz%2FGkDuaQeOKfnYaGP%2FXykweQ%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/tools/llvm-pd<wbr>butil/PrettyTypedefDumper.cpp?<wbr>rev=326731&r1=326730&r2=326731<wbr>&view=diff</span><span></span></a><span><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyTypedefDumper.cpp (original)<br>
+++ llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyTypedefDumper.cpp Mon Mar  5 10:29:43 2018<br>
@@ -63,6 +63,9 @@ void TypedefDumper::dump(const PDBSymbol<br>
     PointeeType->dump(*this);<br>
     Printer << ((Symbol.isReference()) ? "&" : "*");<br>
   }<br>
+<br>
+  if (Symbol.getRawSymbol().isRestr<wbr>ictedType())<br>
+    WithColor(Printer, PDB_ColorItem::Keyword).get() << " __restrict";<br>
 }<br>
<br>
 void TypedefDumper::dump(const PDBSymbolTypeFunctionSig &Symbol) {<br>
<br>
Modified: llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyVariableDumper.cpp<br>
URL: </span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fllvm.org%2Fviewvc%2Fllvm-project%2Fllvm%2Ftrunk%2Ftools%2Fllvm-pdbutil%2FPrettyVariableDumper.cpp%3Frev%3D326731%26r1%3D326730%26r2%3D326731%26view%3Ddiff&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=A4v1%2FGFbjtUKDBHe1n3zx84%2BlOTTvb38AVu%2B4qXtdVs%3D&reserved=0" target="_blank"><span>http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/tools/llvm-pd<wbr>butil/PrettyVariableDumper.cpp<wbr>?rev=326731&r1=326730&r2=32673<wbr>1&view=diff</span><span></span></a><span><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyVariableDumper.cpp (original)<br>
+++ llvm/trunk/tools/llvm-pdbutil/<wbr>PrettyVariableDumper.cpp Mon Mar  5 10:29:43 2018<br>
@@ -169,6 +169,9 @@ void VariableDumper::dumpRight(cons<wbr>t PDB<br>
     WithColor(Printer, PDB_ColorItem::Keyword).get() << " const";<br>
   if (Symbol.isVolatileType())<br>
     WithColor(Printer, PDB_ColorItem::Keyword).get() << " volatile";<br>
+<br>
+  if (Symbol.getRawSymbol().isRestr<wbr>ictedType())<br>
+    WithColor(Printer, PDB_ColorItem::Keyword).get() << " __restrict";<br>
 }<br>
<br>
 void VariableDumper::dump(const PDBSymbolTypePointer &Symbol) {<br>
@@ -189,6 +192,9 @@ void VariableDumper::dump(const PDBSymbo<br>
     WithColor(Printer, PDB_ColorItem::Keyword).get() << " const ";<br>
   if (Symbol.isVolatileType())<br>
     WithColor(Printer, PDB_ColorItem::Keyword).get() << " volatile ";<br>
+<br>
+  if (Symbol.getRawSymbol().isRestr<wbr>ictedType())<br>
+    WithColor(Printer, PDB_ColorItem::Keyword).get() << " __restrict ";<br>
 }<br>
<br>
 void VariableDumper::dumpRight(cons<wbr>t PDBSymbolTypePointer &Symbol) {<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
</span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank"><span>llvm-commits@lists.llvm.org</span><span></span></a><span><br>
</span><a href="https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=04%7C01%7Caaron.smith%40microsoft.com%7Ce5960a00bc4749cf335a08d583960ae7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636559602813695632%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-2&sdata=XXxhz6bNK%2FvQITRz9RKSI8lLHGsMP0Y1cfWf488S6mU%3D&reserved=0" target="_blank"><span>http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</span><span></span></a><span><u></u><u></u></span></p>
</blockquote>
</div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
</div></div></div>
</div>

</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>