<div dir="ltr">This commit broke test/MC/WebAssembly/global-ctor-dtor.ll, making the output of the object file slightly larger.<div><div>I updated the test to unbreak it in r326571, but maybe increased size was unintentional, so you might want to take a look.</div></div></div><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 2, 2018 at 7:53 AM Heejin Ahn via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aheejin<br>
Date: Thu Mar  1 22:51:35 2018<br>
New Revision: 326541<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=326541&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=326541&view=rev</a><br>
Log:<br>
[WebAssembly] More uses of uint8_t for single byte values<br>
<br>
Summary: It looks like this was missing from D43921.<br>
<br>
Reviewers: sbc100<br>
<br>
Subscribers: jfb, dschuff, jgravelle-google, sunfish, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D43991" rel="noreferrer" target="_blank">https://reviews.llvm.org/D43991</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h<br>
<br>
Modified: llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h?rev=326541&r1=326540&r2=326541&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h?rev=326541&r1=326540&r2=326541&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h (original)<br>
+++ llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h Thu Mar  1 22:51:35 2018<br>
@@ -158,19 +158,19 @@ static const unsigned LoadP2AlignOperand<br>
 static const unsigned StoreP2AlignOperandNo = 0;<br>
<br>
 /// This is used to indicate block signatures.<br>
-enum class ExprType {<br>
-  Void    = -0x40,<br>
-  I32     = -0x01,<br>
-  I64     = -0x02,<br>
-  F32     = -0x03,<br>
-  F64     = -0x04,<br>
-  I8x16   = -0x05,<br>
-  I16x8   = -0x06,<br>
-  I32x4   = -0x07,<br>
-  F32x4   = -0x08,<br>
-  B8x16   = -0x09,<br>
-  B16x8   = -0x0a,<br>
-  B32x4   = -0x0b<br>
+enum class ExprType : unsigned {<br>
+  Void    = 0x40,<br>
+  I32     = 0x7F,<br>
+  I64     = 0x7E,<br>
+  F32     = 0x7D,<br>
+  F64     = 0x7C,<br>
+  I8x16   = 0x7B,<br>
+  I16x8   = 0x7A,<br>
+  I32x4   = 0x79,<br>
+  F32x4   = 0x78,<br>
+  B8x16   = 0x77,<br>
+  B16x8   = 0x76,<br>
+  B32x4   = 0x75<br>
 };<br>
<br>
 /// Instruction opcodes emitted via means other than CodeGen.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Regards,</div><div>Ilya Biryukov</div></div></div></div></div>