<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 2, 2018 at 3:40 PM, Chandler Carruth via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br>
Date: Fri Mar 2 15:40:08 2018<br>
New Revision: 326638<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=326638&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=326638&view=rev</a><br>
Log:<br>
[ThinLTO] Revert r325320: Import global variables<br>
<br>
This caused some links to fail with ThinLTO due to missing symbols as<br>
well as causing some binaries to have failures at runtime. We're working<br>
with the author to get a test case, but want to get the tree green<br>
again.<br>
<br>
Further, it appears to introduce a data race. While the test usage of<br>
threads was disabled in r325361 & r325362, that isn't an acceptable fix.<br>
I've reverted both of these as well. This code needs to be thread safe.<br>
Test cases for this are already on the original commit thread.<br></blockquote><div><br></div><div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">FTR, the description of it being a data race is incorrect - it was just interleaved debug/trace output that is being checked (i.e. the list of imported functions/variables emitted under debug option in the backends). The backend parallelism needs to be turned down to 1 to get deterministic messages from the otherwise parallel backends.</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><br></div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">Teresa</div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Removed:<br>
llvm/trunk/test/ThinLTO/X86/<wbr>Inputs/globals-import-cf-baz.<wbr>ll<br>
llvm/trunk/test/ThinLTO/X86/<wbr>globals-import-const-fold.ll<br>
Modified:<br>
llvm/trunk/lib/Linker/IRMover.<wbr>cpp<br>
llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp<br>
llvm/trunk/test/Transforms/<wbr>FunctionImport/funcimport.ll<br>
llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll<br>
<br>
Modified: llvm/trunk/lib/Linker/IRMover.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Linker/IRMover.cpp?rev=326638&r1=326637&r2=326638&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Linker/<wbr>IRMover.cpp?rev=326638&r1=<wbr>326637&r2=326638&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Linker/IRMover.<wbr>cpp (original)<br>
+++ llvm/trunk/lib/Linker/IRMover.<wbr>cpp Fri Mar 2 15:40:08 2018<br>
@@ -1051,10 +1051,14 @@ void IRLinker::<wbr>prepareCompileUnitsForImp<br>
ValueMap.MD()[CU-><wbr>getRawEnumTypes()].reset(<wbr>nullptr);<br>
ValueMap.MD()[CU-><wbr>getRawMacros()].reset(nullptr)<wbr>;<br>
ValueMap.MD()[CU-><wbr>getRawRetainedTypes()].reset(<wbr>nullptr);<br>
- // We import global variables only temporarily in order for instcombine<br>
- // and globalopt to perform constant folding and static constructor<br>
- // evaluation. After that elim-avail-extern will covert imported globals<br>
- // back to declarations, so we don't need debug info for them.<br>
+ // If we ever start importing global variable defs, we'll need to<br>
+ // add their DIGlobalVariable to the globals list on the imported<br>
+ // DICompileUnit. Confirm none are imported, and then we can<br>
+ // map the list of global variables to nullptr.<br>
+ assert(none_of(<br>
+ ValuesToLink,<br>
+ [](const GlobalValue *GV) { return isa<GlobalVariable>(GV); }) &&<br>
+ "Unexpected importing of a GlobalVariable definition");<br>
ValueMap.MD()[CU-><wbr>getRawGlobalVariables()].<wbr>reset(nullptr);<br>
<br>
// Imported entities only need to be mapped in if they have local<br>
<br>
Modified: llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/FunctionImport.cpp?rev=326638&r1=326637&r2=326638&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/IPO/FunctionImport.<wbr>cpp?rev=326638&r1=326637&r2=<wbr>326638&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/IPO/<wbr>FunctionImport.cpp Fri Mar 2 15:40:08 2018<br>
@@ -61,7 +61,6 @@ using namespace llvm;<br>
#define DEBUG_TYPE "function-import"<br>
<br>
STATISTIC(<wbr>NumImportedFunctions, "Number of functions imported");<br>
-STATISTIC(<wbr>NumImportedGlobalVars, "Number of global variables imported");<br>
STATISTIC(NumImportedModules, "Number of modules imported from");<br>
STATISTIC(NumDeadSymbols, "Number of dead stripped symbols in index");<br>
STATISTIC(NumLiveSymbols, "Number of live symbols in index");<br>
@@ -239,33 +238,6 @@ updateValueInfoForIndirectCall<wbr>s(const Mo<br>
return Index.getValueInfo(GUID);<br>
}<br>
<br>
-static void computeImportForReferencedGlob<wbr>als(<br>
- const FunctionSummary &Summary, const GVSummaryMapTy &DefinedGVSummaries,<br>
- FunctionImporter::ImportMapTy &ImportList,<br>
- StringMap<FunctionImporter::<wbr>ExportSetTy> *ExportLists) {<br>
- for (auto &VI : Summary.refs()) {<br>
- if (DefinedGVSummaries.count(VI.<wbr>getGUID())) {<br>
- DEBUG(dbgs() << "Ref ignored! Target already in destination module.\n");<br>
- continue;<br>
- }<br>
-<br>
- DEBUG(dbgs() << " ref -> " << VI.getGUID() << "\n");<br>
-<br>
- for (auto &RefSummary : VI.getSummaryList())<br>
- if (RefSummary->getSummaryKind() == GlobalValueSummary::<wbr>GlobalVarKind &&<br>
- // Don't try to import regular LTO summaries added to dummy module.<br>
- !RefSummary->modulePath().<wbr>empty() &&<br>
- !GlobalValue::<wbr>isInterposableLinkage(<wbr>RefSummary->linkage()) &&<br>
- // For now we don't import global variables which have outgoing<br>
- // refs. Otherwise we have to promote referenced vars/functions.<br>
- RefSummary->refs().empty()) {<br>
- ImportList[RefSummary-><wbr>modulePath()][VI.getGUID()] = 1;<br>
- if (ExportLists)<br>
- (*ExportLists)[RefSummary-><wbr>modulePath()].insert(VI.<wbr>getGUID());<br>
- }<br>
- }<br>
-}<br>
-<br>
/// Compute the list of functions to import for a given caller. Mark these<br>
/// imported functions and the symbols they reference in their source module as<br>
/// exported from their source module.<br>
@@ -275,8 +247,6 @@ static void computeImportForFunction(<br>
SmallVectorImpl<EdgeInfo> &Worklist,<br>
FunctionImporter::ImportMapTy &ImportList,<br>
StringMap<FunctionImporter::<wbr>ExportSetTy> *ExportLists = nullptr) {<br>
- computeImportForReferencedGlob<wbr>als(Summary, DefinedGVSummaries, ImportList,<br>
- ExportLists);<br>
for (auto &Edge : Summary.calls()) {<br>
ValueInfo VI = Edge.first;<br>
DEBUG(dbgs() << " edge -> " << VI.getGUID() << " Threshold:" << Threshold<br>
@@ -419,34 +389,6 @@ static void ComputeImportForModule(<br>
}<br>
}<br>
<br>
-#ifndef NDEBUG<br>
-static bool isGlobalVarSummary(const ModuleSummaryIndex &Index,<br>
- GlobalValue::GUID G) {<br>
- if (const auto &VI = Index.getValueInfo(G)) {<br>
- auto SL = VI.getSummaryList();<br>
- if (!SL.empty())<br>
- return SL[0]->getSummaryKind() == GlobalValueSummary::<wbr>GlobalVarKind;<br>
- }<br>
- return false;<br>
-}<br>
-<br>
-static GlobalValue::GUID getGUID(GlobalValue::GUID G) { return G; }<br>
-<br>
-static GlobalValue::GUID<br>
-getGUID(const std::pair<const GlobalValue::GUID, unsigned> &P) {<br>
- return P.first;<br>
-}<br>
-<br>
-template <class T><br>
-unsigned numGlobalVarSummaries(const ModuleSummaryIndex &Index, T &Cont) {<br>
- unsigned NumGVS = 0;<br>
- for (auto &V : Cont)<br>
- if (isGlobalVarSummary(Index, getGUID(V)))<br>
- ++NumGVS;<br>
- return NumGVS;<br>
-}<br>
-#endif<br>
-<br>
/// Compute all the import and export for every module using the Index.<br>
void llvm::<wbr>ComputeCrossModuleImport(<br>
const ModuleSummaryIndex &Index,<br>
@@ -484,17 +426,12 @@ void llvm::<wbr>ComputeCrossModuleImport(<br>
for (auto &ModuleImports : ImportLists) {<br>
auto ModName = ModuleImports.first();<br>
auto &Exports = ExportLists[ModName];<br>
- unsigned NumGVS = numGlobalVarSummaries(Index, Exports);<br>
- DEBUG(dbgs() << "* Module " << ModName << " exports "<br>
- << Exports.size() - NumGVS << " functions and " << NumGVS<br>
- << " vars. Imports from "<br>
- << ModuleImports.second.size() << " modules.\n");<br>
+ DEBUG(dbgs() << "* Module " << ModName << " exports " << Exports.size()<br>
+ << " functions. Imports from " << ModuleImports.second.size()<br>
+ << " modules.\n");<br>
for (auto &Src : ModuleImports.second) {<br>
auto SrcModName = Src.first();<br>
- unsigned NumGVSPerMod = numGlobalVarSummaries(Index, Src.second);<br>
- DEBUG(dbgs() << " - " << Src.second.size() - NumGVSPerMod<br>
- << " functions imported from " << SrcModName << "\n");<br>
- DEBUG(dbgs() << " - " << NumGVSPerMod << " global vars imported from "<br>
+ DEBUG(dbgs() << " - " << Src.second.size() << " functions imported from "<br>
<< SrcModName << "\n");<br>
}<br>
}<br>
@@ -502,17 +439,13 @@ void llvm::<wbr>ComputeCrossModuleImport(<br>
}<br>
<br>
#ifndef NDEBUG<br>
-static void dumpImportListForModule(const ModuleSummaryIndex &Index,<br>
- StringRef ModulePath,<br>
+static void dumpImportListForModule(<wbr>StringRef ModulePath,<br>
FunctionImporter::ImportMapTy &ImportList) {<br>
DEBUG(dbgs() << "* Module " << ModulePath << " imports from "<br>
<< ImportList.size() << " modules.\n");<br>
for (auto &Src : ImportList) {<br>
auto SrcModName = Src.first();<br>
- unsigned NumGVSPerMod = numGlobalVarSummaries(Index, Src.second);<br>
- DEBUG(dbgs() << " - " << Src.second.size() - NumGVSPerMod<br>
- << " functions imported from " << SrcModName << "\n");<br>
- DEBUG(dbgs() << " - " << NumGVSPerMod << " vars imported from "<br>
+ DEBUG(dbgs() << " - " << Src.second.size() << " functions imported from "<br>
<< SrcModName << "\n");<br>
}<br>
}<br>
@@ -532,7 +465,7 @@ void llvm::<wbr>ComputeCrossModuleImportForMo<br>
ComputeImportForModule(<wbr>FunctionSummaryMap, Index, ImportList);<br>
<br>
#ifndef NDEBUG<br>
- dumpImportListForModule(Index, ModulePath, ImportList);<br>
+ dumpImportListForModule(<wbr>ModulePath, ImportList);<br>
#endif<br>
}<br>
<br>
@@ -559,7 +492,7 @@ void llvm::<wbr>ComputeCrossModuleImportForMo<br>
ImportList[Summary-><wbr>modulePath()][GUID] = 1;<br>
}<br>
#ifndef NDEBUG<br>
- dumpImportListForModule(Index, ModulePath, ImportList);<br>
+ dumpImportListForModule(<wbr>ModulePath, ImportList);<br>
#endif<br>
}<br>
<br>
@@ -837,7 +770,7 @@ Expected<bool> FunctionImporter::importF<br>
Module &DestModule, const FunctionImporter::ImportMapTy &ImportList) {<br>
DEBUG(dbgs() << "Starting import for Module "<br>
<< DestModule.<wbr>getModuleIdentifier() << "\n");<br>
- unsigned ImportedCount = 0, ImportedGVCount = 0;<br>
+ unsigned ImportedCount = 0;<br>
<br>
IRMover Mover(DestModule);<br>
// Do the actual import of functions now, one Module at a time<br>
@@ -897,7 +830,7 @@ Expected<bool> FunctionImporter::importF<br>
if (Import) {<br>
if (Error Err = GV.materialize())<br>
return std::move(Err);<br>
- ImportedGVCount += GlobalsToImport.insert(&GV);<br>
+ GlobalsToImport.insert(&GV);<br>
}<br>
}<br>
for (GlobalAlias &GA : SrcModule->aliases()) {<br>
@@ -954,14 +887,9 @@ Expected<bool> FunctionImporter::importF<br>
NumImportedModules++;<br>
}<br>
<br>
- NumImportedFunctions += (ImportedCount - ImportedGVCount);<br>
- NumImportedGlobalVars += ImportedGVCount;<br>
+ NumImportedFunctions += ImportedCount;<br>
<br>
- DEBUG(dbgs() << "Imported " << ImportedCount - ImportedGVCount<br>
- << " functions for Module " << DestModule.<wbr>getModuleIdentifier()<br>
- << "\n");<br>
- DEBUG(dbgs() << "Imported " << ImportedGVCount<br>
- << " global variables for Module "<br>
+ DEBUG(dbgs() << "Imported " << ImportedCount << " functions for Module "<br>
<< DestModule.<wbr>getModuleIdentifier() << "\n");<br>
return ImportedCount;<br>
}<br>
<br>
Removed: llvm/trunk/test/ThinLTO/X86/<wbr>Inputs/globals-import-cf-baz.<wbr>ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ThinLTO/X86/Inputs/globals-import-cf-baz.ll?rev=326637&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ThinLTO/X86/Inputs/globals-<wbr>import-cf-baz.ll?rev=326637&<wbr>view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ThinLTO/X86/<wbr>Inputs/globals-import-cf-baz.<wbr>ll (original)<br>
+++ llvm/trunk/test/ThinLTO/X86/<wbr>Inputs/globals-import-cf-baz.<wbr>ll (removed)<br>
@@ -1,4 +0,0 @@<br>
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:<wbr>32:64-S128"<br>
-target triple = "x86_64-pc-linux-gnu"<br>
-<br>
-@baz = local_unnamed_addr constant i32 10, align 4<br>
<br>
Removed: llvm/trunk/test/ThinLTO/X86/<wbr>globals-import-const-fold.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ThinLTO/X86/globals-import-const-fold.ll?rev=326637&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ThinLTO/X86/globals-import-<wbr>const-fold.ll?rev=326637&view=<wbr>auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ThinLTO/X86/<wbr>globals-import-const-fold.ll (original)<br>
+++ llvm/trunk/test/ThinLTO/X86/<wbr>globals-import-const-fold.ll (removed)<br>
@@ -1,23 +0,0 @@<br>
-; RUN: opt -module-summary %s -o %t1.bc<br>
-; RUN: opt -module-summary %p/Inputs/globals-import-cf-<wbr>baz.ll -o %t2.bc<br>
-; RUN: llvm-lto -thinlto-action=thinlink %t1.bc %t2.bc -o %t3.index.bc<br>
-<br>
-; RUN: llvm-lto -thinlto-action=import %t1.bc %t2.bc -thinlto-index=%t3.index.bc<br>
-; RUN: llvm-dis %t1.bc.thinlto.imported.bc -o - | FileCheck --check-prefix=IMPORT %s<br>
-; RUN: llvm-lto -thinlto-action=optimize %t1.bc.thinlto.imported.bc -o %t1.bc.thinlto.opt.bc<br>
-; RUN: llvm-dis %t1.bc.thinlto.opt.bc -o - | FileCheck --check-prefix=OPTIMIZE %s<br>
-<br>
-; IMPORT: @baz = available_externally local_unnamed_addr constant i32 10<br>
-<br>
-; OPTIMIZE: define i32 @main()<br>
-; OPTIMIZE-NEXT: ret i32 10<br>
-<br>
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:<wbr>32:64-S128"<br>
-target triple = "x86_64-pc-linux-gnu"<br>
-<br>
-@baz = external local_unnamed_addr constant i32, align 4<br>
-<br>
-define i32 @main() local_unnamed_addr {<br>
- %1 = load i32, i32* @baz, align 4<br>
- ret i32 %1<br>
-}<br>
<br>
Modified: llvm/trunk/test/Transforms/<wbr>FunctionImport/funcimport.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/FunctionImport/funcimport.ll?rev=326638&r1=326637&r2=326638&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/FunctionImport/<wbr>funcimport.ll?rev=326638&r1=<wbr>326637&r2=326638&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/Transforms/<wbr>FunctionImport/funcimport.ll (original)<br>
+++ llvm/trunk/test/Transforms/<wbr>FunctionImport/funcimport.ll Fri Mar 2 15:40:08 2018<br>
@@ -7,8 +7,7 @@<br>
; RUN: opt -function-import -stats -print-imports -enable-import-metadata -summary-file %t3.thinlto.bc %t.bc -S 2>&1 | FileCheck %s --check-prefix=CHECK --check-prefix=INSTLIMDEF<br>
; Try again with new pass manager<br>
; RUN: opt -passes='function-import' -stats -print-imports -enable-import-metadata -summary-file %t3.thinlto.bc %t.bc -S 2>&1 | FileCheck %s --check-prefix=CHECK --check-prefix=INSTLIMDEF<br>
-; RUN: opt -passes='function-import' -debug-only=function-import -enable-import-metadata -summary-file %t3.thinlto.bc %t.bc -S 2>&1 | FileCheck %s --check-prefix=DUMP<br>
-; "-stats" and "-debug-only" require +Asserts.<br>
+; "-stats" requires +Asserts.<br>
; REQUIRES: asserts<br>
<br>
; Test import with smaller instruction limit<br>
@@ -81,7 +80,7 @@ declare void @callfuncptr(...) #1<br>
<br>
; Ensure that all uses of local variable @P which has used in setfuncptr<br>
; and callfuncptr are to the same promoted/renamed global.<br>
-; CHECK-DAG: @P.llvm.{{.*}} = available_externally hidden global void ()* null<br>
+; CHECK-DAG: @P.llvm.{{.*}} = external hidden global void ()*<br>
; CHECK-DAG: %0 = load void ()*, void ()** @P.llvm.<br>
; CHECK-DAG: store void ()* @staticfunc2.llvm.{{.*}}, void ()** @P.llvm.<br>
<br>
@@ -108,8 +107,6 @@ declare void @variadic(...)<br>
<br>
; INSTLIMDEF-DAG: Import globalfunc2<br>
; INSTLIMDEF-DAG: 13 function-import - Number of functions imported<br>
-; INSTLIMDEF-DAG: 4 function-import - Number of global variables imported<br>
-<br>
; CHECK-DAG: !0 = !{!"{{.*}}/Inputs/funcimport.<wbr>ll"}<br>
<br>
; The actual GUID values will depend on path to test.<br>
@@ -145,9 +142,3 @@ declare void @variadic(...)<br>
; GUID-DAG: GUID {{.*}} is linkoncealias<br>
; GUID-DAG: GUID {{.*}} is callfuncptr<br>
; GUID-DAG: GUID {{.*}} is linkoncefunc<br>
-<br>
-; DUMP: Module [[M1:.*]] imports from 1 module<br>
-; DUMP-NEXT: 13 functions imported from [[M2:.*]]<br>
-; DUMP-NEXT: 4 vars imported from [[M2]]<br>
-; DUMP: Imported 13 functions for Module [[M1]]<br>
-; DUMP-NEXT: Imported 4 global variables for Module [[M1]]<br>
<br>
Modified: llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll?rev=326638&r1=326637&r2=326638&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/PGOProfile/thinlto_<wbr>samplepgo_icp3.ll?rev=326638&<wbr>r1=326637&r2=326638&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll (original)<br>
+++ llvm/trunk/test/Transforms/<wbr>PGOProfile/thinlto_samplepgo_<wbr>icp3.ll Fri Mar 2 15:40:08 2018<br>
@@ -6,7 +6,7 @@<br>
<br>
; Test to make sure importing and dead stripping works in the<br>
; case where the target is a local function that also indirectly calls itself.<br>
-; RUN: llvm-lto2 run -thinlto-threads=1 -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l -print-imports 2>&1 | FileCheck %s --check-prefix=IMPORTS<br>
+; RUN: llvm-lto2 run -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l -print-imports 2>&1 | FileCheck %s --check-prefix=IMPORTS<br>
; Make sure we import the promted indirectly called target<br>
; IMPORTS: Import _ZL3foov.llvm.0<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>