<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Feb 25, 2018 at 2:18 AM, Nicolai Hähnle <span dir="ltr"><<a href="mailto:nhaehnle@gmail.com" target="_blank">nhaehnle@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On <a href="tel:24.02.2018%2021" value="+12402201821" target="_blank">24.02.2018 21</a>:50, Daniel Berlin wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
The last thing on this review thread is a request for a review, then it gets committed, breaking stuff.<br>
What happened here?<br>
</blockquote>
<br></span>
No, the last thing on the review thread is the change being accepted.<br></blockquote><div>Yes, that appears now.</div><div>Phab appears busted again, because if you look, you will see it never emailed that out:<br><a href="http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180219/date.html">http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180219/date.html</a></div><div><br></div><div>Search for "40546", and you will not find alex-t accepting it.</div><div><br></div><div>(Alex has also only accepted two patches, ever, including this one, and the other one was a week after joining phab last year, so it would also be pretty uncommon)</div><div><br></div></div></div></div>