<div dir="ltr">The last thing on this review thread is a request for a review, then it gets committed, breaking stuff.<div>What happened here?</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 24, 2018 at 9:33 AM, Adam Nemet via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div>Bots have been failing for a day now.  Reverted in r326037.</div><div><div class="h5"><div><br><blockquote type="cite"><div>On Feb 23, 2018, at 12:44 PM, Quentin Colombet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="m_-5828079868649176253Apple-interchange-newline"><div><div style="word-wrap:break-word;line-break:after-white-space">FWIW, I have the same problem as Sanjay.<div><br></div><div>Here is the output of the failure:</div><div><pre style="box-sizing:border-box;white-space:pre-wrap;word-wrap:break-word;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51);font-size:13px">; GCN: s_cmp_eq_u32
       ^
<stdin>:104:21: note: scanning from here
 s_or_b64 exec, exec, s[10:11]
                    ^
<stdin>:106:2: note: possible intended match here
 v_cmp_eq_u32_e64 s[10:11], s4, v0
 ^</pre><div><br></div><div><br><blockquote type="cite"><div>On Feb 23, 2018, at 12:23 PM, Sanjay Patel via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="m_-5828079868649176253Apple-interchange-newline"><div><div>spatel added a comment.<br><br>I'm not sure if it was this change or something else, but the optnone test is not stable on my system (testing with llc built from r325923):<br><br>  $ ./llvm-lit ../../llvm/test/CodeGen/<wbr>AMDGPU/control-flow-optnone.ll <br>  -- Testing: 1 tests, 1 threads --<br>  PASS: LLVM :: CodeGen/AMDGPU/control-flow-<wbr>optnone.ll (1 of 1)<br>  Testing Time: 0.11s<br>    Expected Passes    : 1<br>  $ ./llvm-lit ../../llvm/test/CodeGen/<wbr>AMDGPU/control-flow-optnone.ll <br>  -- Testing: 1 tests, 1 threads --<br>  FAIL: LLVM :: CodeGen/AMDGPU/control-flow-<wbr>optnone.ll (1 of 1)<br>  Testing Time: 0.11s<br>  ********************<br>  Failing Tests (1):<br>      LLVM :: CodeGen/AMDGPU/control-flow-<wbr>optnone.ll<br><br>I also got blame mail from a bot about this test failing for what would seem to be an unrelated change:<br><a href="http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/7201" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-ppc64be-linux-<wbr>multistage/builds/7201</a><br><br><br>Repository:<br>  rL LLVM<br><br><a href="https://reviews.llvm.org/D40546" target="_blank">https://reviews.llvm.org/<wbr>D40546</a><br><br><br><br>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br></div></div></blockquote></div><br></div></div>______________________________<wbr>_________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div></div><br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>