<div dir="ltr">I'm getting a warning from this commit with gcc<div><br></div><div><div>llvm/unittests/DebugInfo/PDB/PDBApiTest.cpp:145:3: warning: 'findChildrenByAddr' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]</div><div>  findChildrenByAddr(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,</div><div>  ^</div><div>include/llvm/DebugInfo/PDB/IPDBRawSymbol.h:45:3: note: overridden virtual function is here</div><div>  findChildrenByAddr(PDB_SymType Type, StringRef Name,</div></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Thu, Feb 22, 2018 at 11:47 AM, Aaron Smith via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: asmith<br>
Date: Thu Feb 22 11:47:43 2018<br>
New Revision: 325824<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=325824&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=325824&view=rev</a><br>
Log:<br>
[PDB] Implement more find methods for PDB symbols<br>
<br>
Summary:<br>
Add additional find methods on PDB raw symbols.<br>
<br>
findChildrenByAddr()<br>
findChildrenByVA()<br>
findInlineFramesByAddr()<br>
findInlineFramesByVA()<br>
findInlineLines()<br>
findInlineLinesByAddr()<br>
findInlineLinesByRVA()<br>
findInlineLinesByVA()<br>
<br>
<br>
<br>
<br>
Reviewers: zturner, llvm-commits<br>
<br>
Reviewed By: zturner<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D43637" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D43637</a><br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/DIA/<wbr>DIARawSymbol.h<br>
    llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/IPDBRawSymbol.h<br>
    llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/Native/<wbr>NativeRawSymbol.h<br>
    llvm/trunk/lib/DebugInfo/PDB/<wbr>DIA/DIARawSymbol.cpp<br>
    llvm/trunk/lib/DebugInfo/PDB/<wbr>Native/NativeRawSymbol.cpp<br>
    llvm/trunk/unittests/<wbr>DebugInfo/PDB/PDBApiTest.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/DIA/<wbr>DIARawSymbol.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIARawSymbol.h?rev=325824&r1=325823&r2=325824&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/DebugInfo/PDB/DIA/<wbr>DIARawSymbol.h?rev=325824&r1=<wbr>325823&r2=325824&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/DIA/<wbr>DIARawSymbol.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/DIA/<wbr>DIARawSymbol.h Thu Feb 22 11:47:43 2018<br>
@@ -30,10 +30,31 @@ public:<br>
   findChildren(PDB_SymType Type, StringRef Name,<br>
                PDB_NameSearchFlags Flags) const override;<br>
   std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findChildrenByAddr(PDB_SymType Type, StringRef Name,<br>
+                     PDB_NameSearchFlags Flags,<br>
+                     uint32_t Section, uint32_t Offset) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findChildrenByVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
+                   uint64_t VA) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
   findChildrenByRVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
                     uint32_t RVA) const override;<br>
+<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findInlineFramesByAddr(uint32_<wbr>t Section, uint32_t Offset) const override;<br>
   std::unique_ptr<<wbr>IPDBEnumSymbols><br>
   findInlineFramesByRVA(uint32_t RVA) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findInlineFramesByVA(uint64_t VA) const override;<br>
+<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers> findInlineeLines() const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByAddr(uint32_<wbr>t Section, uint32_t Offset,<br>
+                         uint32_t Length) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByRVA(uint32_t RVA, uint32_t Length) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByVA(uint64_t VA, uint32_t Length) const override;<br>
<br>
   void getDataBytes(llvm::<wbr>SmallVector<uint8_t, 32> &bytes) const override;<br>
   void getFrontEndVersion(VersionInfo &Version) const override;<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/IPDBRawSymbol.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h?rev=325824&r1=325823&r2=325824&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/DebugInfo/PDB/<wbr>IPDBRawSymbol.h?rev=325824&r1=<wbr>325823&r2=325824&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/IPDBRawSymbol.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/IPDBRawSymbol.h Thu Feb 22 11:47:43 2018<br>
@@ -42,10 +42,31 @@ public:<br>
   findChildren(PDB_SymType Type, StringRef Name,<br>
                PDB_NameSearchFlags Flags) const = 0;<br>
   virtual std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findChildrenByAddr(PDB_SymType Type, StringRef Name,<br>
+                     PDB_NameSearchFlags Flags,<br>
+                     uint32_t Section, uint32_t Offset) const = 0;<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findChildrenByVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
+                   uint64_t VA) const = 0;<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumSymbols><br>
   findChildrenByRVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
                     uint32_t RVA) const = 0;<br>
+<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findInlineFramesByAddr(uint32_<wbr>t Section, uint32_t Offset) const = 0;<br>
   virtual std::unique_ptr<<wbr>IPDBEnumSymbols><br>
   findInlineFramesByRVA(uint32_t RVA) const = 0;<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findInlineFramesByVA(uint64_t VA) const = 0;<br>
+<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumLineNumbers> findInlineeLines() const = 0;<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByAddr(uint32_<wbr>t Section, uint32_t Offset,<br>
+                         uint32_t Length) const = 0;<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByRVA(uint32_t RVA, uint32_t Length) const = 0;<br>
+  virtual std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByVA(uint64_t VA, uint32_t Length) const = 0;<br>
<br>
   virtual void getDataBytes(llvm::<wbr>SmallVector<uint8_t, 32> &bytes) const = 0;<br>
   virtual void getBackEndVersion(VersionInfo &Version) const = 0;<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/Native/<wbr>NativeRawSymbol.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/Native/NativeRawSymbol.h?rev=325824&r1=325823&r2=325824&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/DebugInfo/PDB/Native/<wbr>NativeRawSymbol.h?rev=325824&<wbr>r1=325823&r2=325824&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/Native/<wbr>NativeRawSymbol.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>DebugInfo/PDB/Native/<wbr>NativeRawSymbol.h Thu Feb 22 11:47:43 2018<br>
@@ -35,10 +35,31 @@ public:<br>
     findChildren(PDB_SymType Type, StringRef Name,<br>
       PDB_NameSearchFlags Flags) const override;<br>
   std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+    findChildrenByAddr(PDB_SymType Type, StringRef Name,<br>
+                       PDB_NameSearchFlags Flags,<br>
+                       uint32_t Section, uint32_t Offset) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+    findChildrenByVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
+                     uint64_t VA) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
     findChildrenByRVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
       uint32_t RVA) const override;<br>
+<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+    findInlineFramesByAddr(uint32_<wbr>t Section, uint32_t Offset) const override;<br>
   std::unique_ptr<<wbr>IPDBEnumSymbols><br>
     findInlineFramesByRVA(uint32_t RVA) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+    findInlineFramesByVA(uint64_t VA) const override;<br>
+<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers> findInlineeLines() const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+    findInlineeLinesByAddr(uint32_<wbr>t Section, uint32_t Offset,<br>
+                           uint32_t Length) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+    findInlineeLinesByRVA(uint32_t RVA, uint32_t Length) const override;<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+    findInlineeLinesByVA(uint64_t VA, uint32_t Length) const override;<br>
<br>
   void getDataBytes(SmallVector<<wbr>uint8_t, 32> &Bytes) const override;<br>
   void getFrontEndVersion(VersionInfo &Version) const override;<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/PDB/<wbr>DIA/DIARawSymbol.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/DIA/DIARawSymbol.cpp?rev=325824&r1=325823&r2=325824&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>DebugInfo/PDB/DIA/<wbr>DIARawSymbol.cpp?rev=325824&<wbr>r1=325823&r2=325824&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/DebugInfo/PDB/<wbr>DIA/DIARawSymbol.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/PDB/<wbr>DIA/DIARawSymbol.cpp Thu Feb 22 11:47:43 2018<br>
@@ -400,6 +400,47 @@ DIARawSymbol::findChildren(<wbr>PDB_SymType T<br>
 }<br>
<br>
 std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+DIARawSymbol::<wbr>findChildrenByAddr(PDB_SymType Type, StringRef Name,<br>
+                                 PDB_NameSearchFlags Flags, uint32_t Section,<br>
+                                 uint32_t Offset) const {<br>
+  llvm::SmallVector<UTF16, 32> Name16;<br>
+  llvm::<wbr>convertUTF8ToUTF16String(Name, Name16);<br>
+<br>
+  enum SymTagEnum EnumVal = static_cast<enum SymTagEnum>(Type);<br>
+<br>
+  DWORD CompareFlags = static_cast<DWORD>(Flags);<br>
+  wchar_t *Name16Str = reinterpret_cast<wchar_t *>(Name16.data());<br>
+<br>
+  CComPtr<IDiaEnumSymbols> DiaEnumerator;<br>
+  if (S_OK !=<br>
+      Symbol->findChildrenExByAddr(<wbr>EnumVal, Name16Str, CompareFlags, Section,<br>
+                                   Offset, &DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumSymbols>(Session, DiaEnumerator);<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+DIARawSymbol::<wbr>findChildrenByVA(PDB_SymType Type, StringRef Name,<br>
+                               PDB_NameSearchFlags Flags, uint64_t VA) const {<br>
+  llvm::SmallVector<UTF16, 32> Name16;<br>
+  llvm::<wbr>convertUTF8ToUTF16String(Name, Name16);<br>
+<br>
+  enum SymTagEnum EnumVal = static_cast<enum SymTagEnum>(Type);<br>
+<br>
+  DWORD CompareFlags = static_cast<DWORD>(Flags);<br>
+  wchar_t *Name16Str = reinterpret_cast<wchar_t *>(Name16.data());<br>
+<br>
+  CComPtr<IDiaEnumSymbols> DiaEnumerator;<br>
+  if (S_OK !=<br>
+      Symbol->findChildrenExByVA(<wbr>EnumVal, Name16Str, CompareFlags, VA,<br>
+                                  &DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumSymbols>(Session, DiaEnumerator);<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
 DIARawSymbol::<wbr>findChildrenByRVA(PDB_SymType Type, StringRef Name,<br>
                                 PDB_NameSearchFlags Flags, uint32_t RVA) const {<br>
   llvm::SmallVector<UTF16, 32> Name16;<br>
@@ -419,6 +460,15 @@ DIARawSymbol::<wbr>findChildrenByRVA(PDB_SymT<br>
 }<br>
<br>
 std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+DIARawSymbol::<wbr>findInlineFramesByAddr(uint32_<wbr>t Section, uint32_t Offset) const {<br>
+  CComPtr<IDiaEnumSymbols> DiaEnumerator;<br>
+  if (S_OK != Symbol-><wbr>findInlineFramesByAddr(<wbr>Section, Offset, &DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumSymbols>(Session, DiaEnumerator);<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
 DIARawSymbol::<wbr>findInlineFramesByRVA(uint32_t RVA) const {<br>
   CComPtr<IDiaEnumSymbols> DiaEnumerator;<br>
   if (S_OK != Symbol->findInlineFramesByRVA(<wbr>RVA, &DiaEnumerator))<br>
@@ -427,6 +477,51 @@ DIARawSymbol::<wbr>findInlineFramesByRVA(uint<br>
   return llvm::make_unique<<wbr>DIAEnumSymbols>(Session, DiaEnumerator);<br>
 }<br>
<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+DIARawSymbol::<wbr>findInlineFramesByVA(uint64_t VA) const {<br>
+  CComPtr<IDiaEnumSymbols> DiaEnumerator;<br>
+  if (S_OK != Symbol->findInlineFramesByVA(<wbr>VA, &DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumSymbols>(Session, DiaEnumerator);<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers> DIARawSymbol::<wbr>findInlineeLines() const {<br>
+  CComPtr<IDiaEnumLineNumbers> DiaEnumerator;<br>
+  if (S_OK != Symbol->findInlineeLines(&<wbr>DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumLineNumbers>(<wbr>DiaEnumerator);<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+DIARawSymbol::<wbr>findInlineeLinesByAddr(uint32_<wbr>t Section, uint32_t Offset,<br>
+                                     uint32_t Length) const {<br>
+  CComPtr<IDiaEnumLineNumbers> DiaEnumerator;<br>
+  if (S_OK != Symbol-><wbr>findInlineeLinesByAddr(<wbr>Section, Offset, Length, &DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumLineNumbers>(<wbr>DiaEnumerator);<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+DIARawSymbol::<wbr>findInlineeLinesByRVA(uint32_t RVA, uint32_t Length) const {<br>
+  CComPtr<IDiaEnumLineNumbers> DiaEnumerator;<br>
+  if (S_OK != Symbol->findInlineeLinesByRVA(<wbr>RVA, Length, &DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumLineNumbers>(<wbr>DiaEnumerator);<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+DIARawSymbol::<wbr>findInlineeLinesByVA(uint64_t VA, uint32_t Length) const {<br>
+  CComPtr<IDiaEnumLineNumbers> DiaEnumerator;<br>
+  if (S_OK != Symbol->findInlineeLinesByVA(<wbr>VA, Length, &DiaEnumerator))<br>
+    return nullptr;<br>
+<br>
+  return llvm::make_unique<<wbr>DIAEnumLineNumbers>(<wbr>DiaEnumerator);<br>
+}<br>
+<br>
 void DIARawSymbol::getDataBytes(<wbr>llvm::SmallVector<uint8_t, 32> &bytes) const {<br>
   bytes.clear();<br>
<br>
<br>
Modified: llvm/trunk/lib/DebugInfo/PDB/<wbr>Native/NativeRawSymbol.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/PDB/Native/NativeRawSymbol.cpp?rev=325824&r1=325823&r2=325824&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>DebugInfo/PDB/Native/<wbr>NativeRawSymbol.cpp?rev=<wbr>325824&r1=325823&r2=325824&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/DebugInfo/PDB/<wbr>Native/NativeRawSymbol.cpp (original)<br>
+++ llvm/trunk/lib/DebugInfo/PDB/<wbr>Native/NativeRawSymbol.cpp Thu Feb 22 11:47:43 2018<br>
@@ -30,16 +30,60 @@ NativeRawSymbol::findChildren(<wbr>PDB_SymTyp<br>
 }<br>
<br>
 std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+NativeRawSymbol::<wbr>findChildrenByAddr(PDB_SymType Type, StringRef Name,<br>
+    PDB_NameSearchFlags Flags, uint32_t Section, uint32_t Offset) const {<br>
+  return nullptr;<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+NativeRawSymbol::<wbr>findChildrenByVA(PDB_SymType Type, StringRef Name,<br>
+   PDB_NameSearchFlags Flags, uint64_t VA) const {<br>
+  return nullptr;<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
 NativeRawSymbol::<wbr>findChildrenByRVA(PDB_SymType Type, StringRef Name,<br>
     PDB_NameSearchFlags Flags, uint32_t RVA) const {<br>
   return nullptr;<br>
 }<br>
<br>
 std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+NativeRawSymbol::<wbr>findInlineFramesByAddr(uint32_<wbr>t Section,<br>
+                                        uint32_t Offset) const {<br>
+  return nullptr;<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
 NativeRawSymbol::<wbr>findInlineFramesByRVA(uint32_t RVA) const {<br>
   return nullptr;<br>
 }<br>
<br>
+std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+NativeRawSymbol::<wbr>findInlineFramesByVA(uint64_t VA) const {<br>
+  return nullptr;<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+NativeRawSymbol::<wbr>findInlineeLines() const {<br>
+  return nullptr;<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+NativeRawSymbol::<wbr>findInlineeLinesByAddr(uint32_<wbr>t Section, uint32_t Offset,<br>
+                                        uint32_t Length) const {<br>
+  return nullptr;<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+NativeRawSymbol::<wbr>findInlineeLinesByRVA(uint32_t RVA, uint32_t Length) const {<br>
+  return nullptr;<br>
+}<br>
+<br>
+std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+NativeRawSymbol::<wbr>findInlineeLinesByVA(uint64_t VA, uint32_t Length) const {<br>
+  return nullptr;<br>
+}<br>
+<br>
 void NativeRawSymbol::getDataBytes(<wbr>SmallVector<uint8_t, 32> &bytes) const {<br>
   bytes.clear();<br>
 }<br>
<br>
Modified: llvm/trunk/unittests/<wbr>DebugInfo/PDB/PDBApiTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/PDBApiTest.cpp?rev=325824&r1=325823&r2=325824&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/unittests/<wbr>DebugInfo/PDB/PDBApiTest.cpp?<wbr>rev=325824&r1=325823&r2=<wbr>325824&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/unittests/<wbr>DebugInfo/PDB/PDBApiTest.cpp (original)<br>
+++ llvm/trunk/unittests/<wbr>DebugInfo/PDB/PDBApiTest.cpp Thu Feb 22 11:47:43 2018<br>
@@ -142,14 +142,48 @@ public:<br>
     return nullptr;<br>
   }<br>
   std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findChildrenByAddr(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
+                     uint32_t Section, uint32_t Offset) const {<br>
+    return nullptr;<br>
+  }<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findChildrenByVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
+                   uint64_t VA) const override {<br>
+    return nullptr;<br>
+  }<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
   findChildrenByRVA(PDB_SymType Type, StringRef Name, PDB_NameSearchFlags Flags,<br>
                     uint32_t RVA) const override {<br>
     return nullptr;<br>
   }<br>
   std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findInlineFramesByAddr(uint32_<wbr>t Section, uint32_t Offset) const override {<br>
+    return nullptr;<br>
+  }<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
   findInlineFramesByRVA(uint32_t RVA) const override {<br>
     return nullptr;<br>
   }<br>
+  std::unique_ptr<<wbr>IPDBEnumSymbols><br>
+  findInlineFramesByVA(uint64_t VA) const override {<br>
+    return nullptr;<br>
+  }<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers> findInlineeLines() const override {<br>
+    return nullptr;<br>
+  }<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByAddr(uint32_<wbr>t Section, uint32_t Offset,<br>
+                         uint32_t Length) const override {<br>
+    return nullptr;<br>
+  }<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByRVA(uint32_t RVA, uint32_t Length) const override {<br>
+    return nullptr;<br>
+  }<br>
+  std::unique_ptr<<wbr>IPDBEnumLineNumbers><br>
+  findInlineeLinesByVA(uint64_t VA, uint32_t Length) const override {<br>
+    return nullptr;<br>
+  }<br>
<br>
   void getDataBytes(llvm::<wbr>SmallVector<uint8_t, 32> &bytes) const override {}<br>
   void getFrontEndVersion(VersionInfo &Version) const override {}<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>