<div dir="ltr">Could you include a link to the buildbot and/or further descriptions of the issue being worked around (as a reply here in this case, though good to have it in the commit message for future changes (& if the workaround's particularly weird, maybe a comment in the source))</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 16, 2018 at 1:00 PM Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Fri Feb 16 12:58:25 2018<br>
New Revision: 325388<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=325388&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=325388&view=rev</a><br>
Log:<br>
Try to fix broken build with some compilers.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/DebugInfo/PDB/Native/HashTable.h<br>
<br>
Modified: llvm/trunk/include/llvm/DebugInfo/PDB/Native/HashTable.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/Native/HashTable.h?rev=325388&r1=325387&r2=325388&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/Native/HashTable.h?rev=325388&r1=325387&r2=325388&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/DebugInfo/PDB/Native/HashTable.h (original)<br>
+++ llvm/trunk/include/llvm/DebugInfo/PDB/Native/HashTable.h Fri Feb 16 12:58:25 2018<br>
@@ -26,7 +26,29 @@ class BinaryStreamWriter;<br>
<br>
 namespace pdb {<br>
<br>
-class HashTableIterator;<br>
+class HashTableIterator<br>
+    : public iterator_facade_base<HashTableIterator, std::forward_iterator_tag,<br>
+                                  std::pair<uint32_t, uint32_t>> {<br>
+  friend class HashTable;<br>
+<br>
+  HashTableIterator(const HashTable &Map, uint32_t Index, bool IsEnd);<br>
+<br>
+public:<br>
+  HashTableIterator(const HashTable &Map);<br>
+<br>
+  HashTableIterator &operator=(const HashTableIterator &R);<br>
+  bool operator==(const HashTableIterator &R) const;<br>
+  const std::pair<uint32_t, uint32_t> &operator*() const;<br>
+  HashTableIterator &operator++();<br>
+<br>
+private:<br>
+  bool isEnd() const { return IsEnd; }<br>
+  uint32_t index() const { return Index; }<br>
+<br>
+  const HashTable *Map;<br>
+  uint32_t Index;<br>
+  bool IsEnd;<br>
+};<br>
<br>
 class HashTable {<br>
   friend class HashTableIterator;<br>
@@ -189,30 +211,6 @@ private:<br>
                                     SparseBitVector<> &Vec);<br>
 };<br>
<br>
-class HashTableIterator<br>
-    : public iterator_facade_base<HashTableIterator, std::forward_iterator_tag,<br>
-                                  std::pair<uint32_t, uint32_t>> {<br>
-  friend class HashTable;<br>
-<br>
-  HashTableIterator(const HashTable &Map, uint32_t Index, bool IsEnd);<br>
-<br>
-public:<br>
-  HashTableIterator(const HashTable &Map);<br>
-<br>
-  HashTableIterator &operator=(const HashTableIterator &R);<br>
-  bool operator==(const HashTableIterator &R) const;<br>
-  const std::pair<uint32_t, uint32_t> &operator*() const;<br>
-  HashTableIterator &operator++();<br>
-<br>
-private:<br>
-  bool isEnd() const { return IsEnd; }<br>
-  uint32_t index() const { return Index; }<br>
-<br>
-  const HashTable *Map;<br>
-  uint32_t Index;<br>
-  bool IsEnd;<br>
-};<br>
-<br>
 } // end namespace pdb<br>
<br>
 } // end namespace llvm<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>