<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thus far we don't have any testcases for syntax highlighting, partially because we auto-detect if the terminal is a pipe an turn off syntax highlighting then. It can be forced on by passing --color, though. I guess we could start testing it...<div class=""><br class=""></div><div class="">-- adrian<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 20, 2018, at 10:24 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Test case?</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Feb 12, 2018 at 1:13 PM Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br class="">
Date: Mon Feb 12 13:11:23 2018<br class="">
New Revision: 324936<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=324936&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=324936&view=rev</a><br class="">
Log:<br class="">
Fix the syntax highlighting of strings in dwarfdump.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp?rev=324936&r1=324935&r2=324936&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp?rev=324936&r1=324935&r2=324936&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp (original)<br class="">
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFFormValue.cpp Mon Feb 12 13:11:23 2018<br class="">
@@ -587,10 +587,10 @@ void DWARFFormValue::dump(raw_ostream &O<br class="">
void DWARFFormValue::dumpString(raw_ostream &OS) const {<br class="">
Optional<const char *> DbgStr = getAsCString();<br class="">
if (DbgStr.hasValue()) {<br class="">
- raw_ostream &COS = WithColor(OS, syntax::String);<br class="">
- COS << '"';<br class="">
- COS.write_escaped(DbgStr.getValue());<br class="">
- COS << '"';<br class="">
+ auto COS = WithColor(OS, syntax::String);<br class="">
+ COS.get() << '"';<br class="">
+ COS.get().write_escaped(DbgStr.getValue());<br class="">
+ COS.get() << '"';<br class="">
}<br class="">
}<br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>