<div dir="ltr">Ah *nod* nevermind - I misread/misunderstood the patch. Thanks for pointing it out!</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Feb 20, 2018 at 12:37 PM Simon Pilgrim <<a href="mailto:llvm-dev@redking.me.uk">llvm-dev@redking.me.uk</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Sorry, I don't understand - we don't need the AArch64InstrInfo
variable at all, everything it was calling was a static method.
There is no isa/dyn_cast style testing going on.<br>
</p></div><div text="#000000" bgcolor="#FFFFFF">
<div class="m_5254621615019194201moz-cite-prefix">On 20/02/2018 17:00, David Blaikie
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">If you don't need the cast result - maybe use
isa<> instead?</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Sat, Feb 17, 2018 at 5:50 AM Simon Pilgrim via
llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
rksimon<br>
Date: Sat Feb 17 05:48:23 2018<br>
New Revision: 325432<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=325432&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=325432&view=rev</a><br>
Log:<br>
Fix unused variable warning. NFCI.<br>
<br>
We were casting to AArch64InstrInfo but only using it for
static methods which some compilers complain about.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp?rev=325432&r1=325431&r2=325432&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp?rev=325432&r1=325431&r2=325432&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp
(original)<br>
+++ llvm/trunk/lib/Target/AArch64/AArch64MacroFusion.cpp Sat
Feb 17 05:48:23 2018<br>
@@ -27,7 +27,6 @@ static bool shouldScheduleAdjacent(const<br>
const TargetSubtargetInfo
&TSI,<br>
const MachineInstr
*FirstMI,<br>
const MachineInstr
&SecondMI) {<br>
- const AArch64InstrInfo &II = static_cast<const
AArch64InstrInfo&>(TII);<br>
const AArch64Subtarget &ST = static_cast<const
AArch64Subtarget&>(TSI);<br>
<br>
// Assume wildcards for unspecified instrs.<br>
@@ -66,7 +65,7 @@ static bool shouldScheduleAdjacent(const<br>
case AArch64::BICSWrs:<br>
case AArch64::BICSXrs:<br>
// Shift value can be 0 making these behave like the
"rr" variant...<br>
- return !II.hasShiftedReg(*FirstMI);<br>
+ return !AArch64InstrInfo::hasShiftedReg(*FirstMI);<br>
case AArch64::INSTRUCTION_LIST_END:<br>
return true;<br>
}<br>
@@ -108,7 +107,7 @@ static bool shouldScheduleAdjacent(const<br>
case AArch64::BICWrs:<br>
case AArch64::BICXrs:<br>
// Shift value can be 0 making these behave like the
"rr" variant...<br>
- return !II.hasShiftedReg(*FirstMI);<br>
+ return !AArch64InstrInfo::hasShiftedReg(*FirstMI);<br>
case AArch64::INSTRUCTION_LIST_END:<br>
return true;<br>
}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
</blockquote>
<br>
</div></blockquote></div>