<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Feb 18, 2018 at 10:49 AM, Charles Saternos <span dir="ltr"><<a href="mailto:charles.saternos@gmail.com" target="_blank">charles.saternos@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Yup, it fails when I do a release build. Does that mean I should remove LLVM_DUMP_METHOD or use a different qualifier?</div></div></blockquote><div><br></div><div>Probably should remove LLVM_DUMP_METHOD - it looks like that is used typically for dump routines that are guarded by #ifndef DEBUG. However, it would be good to first understand why this isn't working in release mode - from my visual inspection LLVM_DUMP_METHOD should not be optimized out automatically under NDEBUG.</div><div><br></div><div>Teresa</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888">- Charles<br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Feb 18, 2018 at 12:58 PM, Teresa Johnson <span dir="ltr"><<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Sat, Feb 17, 2018 at 4:43 PM, Charles Saternos via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>OK, I've been looking into the issue. Not sure why its happening since the test passes when I build locally. I'll keep investigating.<br></div></div></div></blockquote><div><br></div></span><div>Looked at a couple of the failures - looks like empty output. Initially thought you needed to add "REQUIRES: asserts", but neither dump method nor caller is qualified by an #ifndef NDEBUG. LLVM_DUMP_METHOD is defined somewhat differently for the NDEBUG case, but only to prevent it from being eliminated if there are no callers, and you have a caller. But as a sanity check, try reproducing locally with a compiler configured to build RELEASE.</div><div><br></div><div>Teresa</div><div><div class="m_3953213042040177024h5"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><br></div>Thanks,<br></div>Charles<br></div><div class="m_3953213042040177024m_5788739702205147219HOEnZb"><div class="m_3953213042040177024m_5788739702205147219h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 17, 2018 at 7:35 PM, Simon Pilgrim <span dir="ltr"><<a href="mailto:llvm-dev@redking.me.uk" target="_blank">llvm-dev@redking.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Charles, I'm sorry but I had to revert this at rL325454 to try
and fix the buildbot failures. Simon.<br>
</p><div><div class="m_3953213042040177024m_5788739702205147219m_-1877196461939207595h5">
<div class="m_3953213042040177024m_5788739702205147219m_-1877196461939207595m_-4063257542564892245moz-cite-prefix">On 17/02/2018 22:24, Charles Saternos
via llvm-commits wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="m_3953213042040177024m_5788739702205147219m_-1877196461939207595h5">
<div dir="ltr">
<div>
<div>Hey Davide,<br>
<br>
</div>
It's been reported here: <a href="https://bugs.llvm.org/show_bug.cgi?id=32556" target="_blank">https://bugs.llvm.org/show_bug<wbr>.cgi?id=32556</a><br>
<br>
</div>
<div>The use of std::function rather than function_ref is
related to some problem in clang.<br>
<br>
</div>
<div>Thanks,<br>
</div>
<div>Charles<br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sat, Feb 17, 2018 at 5:04 PM, Davide
Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Sat, Feb 17, 2018 at 1:39 PM, Charles Saternos
via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>
wrote:<br>
> Author: ncharlie<br>
> Date: Sat Feb 17 13:39:24 2018<br>
> New Revision: 325448<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=325448&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=325448&view=rev</a><br>
> Log:<br>
> [ThinLTO] Add GraphTraits for FunctionSummaries<br>
><br>
> Add GraphTraits definitions to the FunctionSummary
and ModuleSummaryIndex classes. These GraphTraits will be
used to construct find SCC's in ThinLTO analysis passes.<br>
><br>
> Second attempt, since last patch caused stage2 build
to fail (now using function_ref rather than
std::function).<br>
><br>
<br>
</span>Charlie, what's the bug in clang? It would be good to
fix it, regardless.<br>
<br>
Thanks,<br>
<br>
--<br>
Davide<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset class="m_3953213042040177024m_5788739702205147219m_-1877196461939207595m_-4063257542564892245mimeAttachmentHeader"></fieldset>
<br>
</div></div><span><pre>______________________________<wbr>_________________
llvm-commits mailing list
<a class="m_3953213042040177024m_5788739702205147219m_-1877196461939207595m_-4063257542564892245moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>
<a class="m_3953213042040177024m_5788739702205147219m_-1877196461939207595m_-4063257542564892245moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a>
</pre>
</span></blockquote>
<br>
</div>
</blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div></div></div><span class="m_3953213042040177024HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_3953213042040177024m_5788739702205147219gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px" nowrap>Teresa Johnson |</td><td style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px" nowrap> Software Engineer |</td><td style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px" nowrap> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px" nowrap> <a href="tel:(408)%20460-2413" value="+14084602413" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</font></span></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div>