<div dir="ltr">Thanks</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 14, 2018 at 2:43 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'll revert it now.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 14, 2018 at 2:42 PM, Vitaly Buka <span dir="ltr"><<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>+ruiu</div>Also this one is broken on Windows.<div><div class="m_5770559792043542464h5"><br class="m_5770559792043542464m_7483888884340135203m_3396118934270884921gmail-Apple-interchange-newline"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 14, 2018 at 2:25 PM, Vitaly Buka <span dir="ltr"><<a href="mailto:vitalybuka@google.com" class="m_5770559792043542464m_7483888884340135203cremed" target="_blank">vitalybuka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Windows bot does not like it: <a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/24153" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">http://lab.llvm.org:8011/b<wbr>uilders/sanitizer-windows/buil<wbr>ds/24153</a><div><pre style="font-family:"Courier New",courier,monotype,monospace;color:rgb(0,0,0);font-size:medium;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial"><span class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047m_8618067491956295029gmail-stdout" style="font-family:"Courier New",courier,monotype,monospace;color:black">c:\b\slave\sanitizer-windows\l<wbr>lvm\tools\lld\coff\Symbols.h(4<wbr>25): error C2057: expected constant expression</span></pre><br></div><div><div class="m_5770559792043542464m_7483888884340135203m_3396118934270884921h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 14, 2018 at 11:28 AM, Sam Clegg via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sbc<br>
Date: Wed Feb 14 11:28:46 2018<br>
New Revision: 325158<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=325158&view=rev" rel="noreferrer" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=325158&view=rev</a><br>
Log:<br>
Convert an assert to a static_assert. NFC.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D43305" rel="noreferrer" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">https://reviews.llvm.org/D4330<wbr>5</a><br>
<br>
Modified:<br>
lld/trunk/COFF/Symbols.h<br>
lld/trunk/ELF/Symbols.h<br>
lld/trunk/wasm/Symbols.h<br>
<br>
Modified: lld/trunk/COFF/Symbols.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Symbols.h?rev=325158&r1=325157&r2=325158&view=diff" rel="noreferrer" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/COFF/Symbols.h<wbr>?rev=325158&r1=325157&r2=32515<wbr>8&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/COFF/Symbols.h (original)<br>
+++ lld/trunk/COFF/Symbols.h Wed Feb 14 11:28:46 2018<br>
@@ -421,8 +421,8 @@ void replaceSymbol(Symbol *S, ArgT &&...<br>
static_assert(sizeof(T) <= sizeof(SymbolUnion), "Symbol too small");<br>
static_assert(alignof(T) <= alignof(SymbolUnion),<br>
"SymbolUnion not aligned enough");<br>
- assert(static_cast<Symbol *>(static_cast<T *>(nullptr)) == nullptr &&<br>
- "Not a Symbol");<br>
+ static_assert(static_cast<Symb<wbr>ol *>(static_cast<T *>(nullptr)) == nullptr,<br>
+ "Not a Symbol");<br>
new (S) T(std::forward<ArgT>(Arg)...);<br>
}<br>
} // namespace coff<br>
<br>
Modified: lld/trunk/ELF/Symbols.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=325158&r1=325157&r2=325158&view=diff" rel="noreferrer" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/ELF/Symbols.h?<wbr>rev=325158&r1=325157&r2=325158<wbr>&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/Symbols.h (original)<br>
+++ lld/trunk/ELF/Symbols.h Wed Feb 14 11:28:46 2018<br>
@@ -355,8 +355,8 @@ void replaceSymbol(Symbol *S, ArgT &&...<br>
static_assert(sizeof(T) <= sizeof(SymbolUnion), "SymbolUnion too small");<br>
static_assert(alignof(T) <= alignof(SymbolUnion),<br>
"SymbolUnion not aligned enough");<br>
- assert(static_cast<Symbol *>(static_cast<T *>(nullptr)) == nullptr &&<br>
- "Not a Symbol");<br>
+ static_assert(static_cast<Symb<wbr>ol *>(static_cast<T *>(nullptr)) == nullptr,<br>
+ "Not a Symbol");<br>
<br>
Symbol Sym = *S;<br>
<br>
<br>
Modified: lld/trunk/wasm/Symbols.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Symbols.h?rev=325158&r1=325157&r2=325158&view=diff" rel="noreferrer" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/wasm/Symbols.h<wbr>?rev=325158&r1=325157&r2=32515<wbr>8&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/wasm/Symbols.h (original)<br>
+++ lld/trunk/wasm/Symbols.h Wed Feb 14 11:28:46 2018<br>
@@ -242,8 +242,8 @@ T *replaceSymbol(Symbol *S, ArgT &&... A<br>
static_assert(sizeof(T) <= sizeof(SymbolUnion), "Symbol too small");<br>
static_assert(alignof(T) <= alignof(SymbolUnion),<br>
"SymbolUnion not aligned enough");<br>
- assert(static_cast<Symbol *>(static_cast<T *>(nullptr)) == nullptr &&<br>
- "Not a Symbol");<br>
+ static_assert(static_cast<Symb<wbr>ol *>(static_cast<T *>(nullptr)) == nullptr,<br>
+ "Not a Symbol");<br>
return new (S) T(std::forward<ArgT>(Arg)...);<br>
}<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_5770559792043542464m_7483888884340135203m_3396118934270884921m_8039761244293783047cremed m_5770559792043542464m_7483888884340135203cremed" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>