
<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Is there anything in the DWARF standard that would suggest this shouldn’t be possible? If not I think we should support it as is and implement the more advanced loop detection?<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 9, 2018, at 3:53 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">*nod* Thought so - would be good to know what scenario this is meant to support.<br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Feb 9, 2018 at 2:22 AM Jonas Devlieghere via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">JDevlieghere added a subscriber: clayborg.<br class="">

JDevlieghere added a comment.<br class="">

<br class="">

In <a href="https://reviews.llvm.org/D43092#1002677" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D43092#1002677</a>, @dblaikie wrote:<br class="">

<br class="">

> Could you check the revision history here? I'm pretty sure the first version of this I reviewed from Greg wasn't recursive - and then it became recursive at some point to handle something needed, but maybe those decisions need to be reexamined?<br class="">

<br class="">

<br class="">

It was @clayborg himself that updated the implementation. (<a href="https://reviews.llvm.org/D40156" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D40156</a> <a href="https://reviews.llvm.org/rL319104" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/rL319104</a>)<br class="">

<br class="">

> The previous implementation would only look 1 DW_AT_specification or DW_AT_abstract_origin deep. This means DWARFDie::getName() would fail in certain cases. I ran into such a case while creating a tool that used the LLVM DWARF parser to generate a symbolication format so I have seen this in the wild.<br class="">

<br class="">

<br class="">

<a href="https://reviews.llvm.org/D43092" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D43092</a><br class="">

<br class="">

<br class="">

<br class="">

</blockquote></div></div>

</div></blockquote></div><br class=""></body></html>