<div dir="ltr">if 'match' doesn't actually need the type of the first arg to be ConstantInt, perhaps the dyn_cast should be an isa instead?</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Feb 8, 2018 at 6:26 AM Simon Pilgrim via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rksimon<br>
Date: Thu Feb  8 06:24:26 2018<br>
New Revision: 324605<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=324605&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=324605&view=rev</a><br>
Log:<br>
Fix unused variable warning.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp?rev=324605&r1=324604&r2=324605&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp?rev=324605&r1=324604&r2=324605&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp Thu Feb  8 06:24:26 2018<br>
@@ -138,7 +138,7 @@ static bool IsMultiple(const APInt &C1,<br>
 static Constant *getLogBase2(Type *Ty, Constant *C) {<br>
   const APInt *IVal;<br>
   if (const auto *CI = dyn_cast<ConstantInt>(C))<br>
-    if (match(C, m_APInt(IVal)) && IVal->isPowerOf2())<br>
+    if (match(CI, m_APInt(IVal)) && IVal->isPowerOf2())<br>
       return ConstantInt::get(Ty, IVal->logBase2());<br>
<br>
   if (!Ty->isVectorTy())<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>