<div dir="ltr">Can you commit these changes for me? I don't have commit access.<div><br></div><div>Is there anything I can do to help test them? So far, I've built a stage 2 toolchain and verified that check-llvm, check-libcxx, and check-libcxxabi all pass. It wasn't clear to me that any of the check-llvm tests tested SJLJ, so I manually inspected the compiler output of "-target arm-darwin".</div><div><br></div><div>Thanks for reviewing the changes.</div><div><br></div><div>-Ryan</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 7, 2018 at 2:27 PM, Ryan Prichard <span dir="ltr"><<a href="mailto:rprichard@google.com" target="_blank">rprichard@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Wed, Feb 7, 2018 at 9:49 AM, Rafael Avila de Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">With this change AsmPrinter::EmitPaddedULEB128 is dead, please delete<br>
it.<br></blockquote><div><br></div></span><div>I noticed that <span style="color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:left;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">MCStreamer::<wbr>EmitPaddedULEB128IntValue was also dead, so I removed both it and</span> <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">AsmPrinter::<wbr>EmitPaddedULEB128.</span></div><span class="HOEnZb"><font color="#888888"><div><br></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">-Ryan</span></div><div><br></div></font></span></div></div></div>
</blockquote></div><br></div></div>