<div dir="ltr">I'm a bit confused - aren't these tests built using the just-built compiler? What's the scenario they're being run under that requires backwards compatibility like that?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 2, 2018 at 12:44 PM Kuba Mracek via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kuba.brecka<br>
Date: Fri Feb  2 12:42:29 2018<br>
New Revision: 324136<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=324136&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=324136&view=rev</a><br>
Log:<br>
Use NULL instead of nullptr in invalid-pointer-pairs-compare-null.cc; nullptr is not available on older Darwin systems.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/test/asan/TestCases/invalid-pointer-pairs-compare-null.cc<br>
<br>
Modified: compiler-rt/trunk/test/asan/TestCases/invalid-pointer-pairs-compare-null.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/invalid-pointer-pairs-compare-null.cc?rev=324136&r1=324135&r2=324136&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/invalid-pointer-pairs-compare-null.cc?rev=324136&r1=324135&r2=324136&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/asan/TestCases/invalid-pointer-pairs-compare-null.cc (original)<br>
+++ compiler-rt/trunk/test/asan/TestCases/invalid-pointer-pairs-compare-null.cc Fri Feb  2 12:42:29 2018<br>
@@ -15,28 +15,28 @@ char small_global[7] = {};<br>
 int main() {<br>
   // Heap allocated memory.<br>
   char *p = (char *)malloc(42);<br>
-  int r = foo(p, nullptr);<br>
+  int r = foo(p, NULL);<br>
   free(p);<br>
<br>
   p = (char *)malloc(1024);<br>
-  foo(nullptr, p);<br>
+  foo(NULL, p);<br>
   free(p);<br>
<br>
   p = (char *)malloc(4096);<br>
-  foo(p, nullptr);<br>
+  foo(p, NULL);<br>
   free(p);<br>
<br>
   // Global variable.<br>
-  foo(&global[0], nullptr);<br>
-  foo(&global[1000], nullptr);<br>
+  foo(&global[0], NULL);<br>
+  foo(&global[1000], NULL);<br>
<br>
   p = &small_global[0];<br>
-  foo(p, nullptr);<br>
+  foo(p, NULL);<br>
<br>
   // Stack variable.<br>
   char stack[10000];<br>
-  foo(&stack[0], nullptr);<br>
-  foo(nullptr, &stack[9000]);<br>
+  foo(&stack[0], NULL);<br>
+  foo(NULL, &stack[9000]);<br>
<br>
   return 0;<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>