<html><head></head><body>We should probably port this to 6.0.<br>
<br>
Cheers,<br>
Rafael<br><br><div class="gmail_quote">On February 1, 2018 4:31:05 PM PST, Rui Ueyama via llvm-commits <llvm-commits@lists.llvm.org> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Author: ruiu<br>Date: Thu Feb 1 16:31:05 2018<br>New Revision: 324043<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=324043&view=rev">http://llvm.org/viewvc/llvm-project?rev=324043&view=rev</a><br>Log:<br>Fix typo: --nopie -> --no-pie.<br><br>--nopie was a typo. GNU gold doesn't recognize it. It is also<br>inconsistent with other options that have --foo and --no-foo.<br><br>Differential Revision: <a href="https://reviews.llvm.org/D42825">https://reviews.llvm.org/D42825</a><br><br>Modified:<br> lld/trunk/ELF/Driver.cpp<br> lld/trunk/ELF/Options.td<br> lld/trunk/test/ELF/pie.s<br><br>Modified: lld/trunk/ELF/Driver.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=324043&r1=324042&r2=324043&view=diff">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=324043&r1=324042&r2=324043&view=diff</a><hr>--- lld/trunk/ELF/Driver.cpp (original)<br>+++ lld/trunk/ELF/Driver.cpp Thu Feb 1 16:31:05 2018<br>@@ -646,7 +646,7 @@ void LinkerDriver::readConfigs(opt::Inpu<br> Config->Optimize = args::getInteger(Args, OPT_O, 1);<br> Config->OrphanHandling = getOrphanHandling(Args);<br> Config->OutputFile = Args.getLastArgValue(OPT_o);<br>- Config->Pie = Args.hasFlag(OPT_pie, OPT_nopie, false);<br>+ Config->Pie = Args.hasFlag(OPT_pie, OPT_no_pie, false);<br> Config->PrintIcfSections =<br> Args.hasFlag(OPT_print_icf_sections, OPT_no_print_icf_sections, false);<br> Config->PrintGcSections =<br><br>Modified: lld/trunk/ELF/Options.td<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=324043&r1=324042&r2=324043&view=diff">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=324043&r1=324042&r2=324043&view=diff</a><hr>--- lld/trunk/ELF/Options.td (original)<br>+++ lld/trunk/ELF/Options.td Thu Feb 1 16:31:05 2018<br>@@ -205,6 +205,8 @@ def no_gnu_unique: F<"no-gnu-unique">,<br> def no_merge_exidx_entries: F<"no-merge-exidx-entries">,<br> HelpText<"Disable merging .ARM.exidx entries">;<br> <br>+def no_pie: F<"no-pie">, HelpText<"Do not create a position independent executable">;<br>+<br> def no_threads: F<"no-threads">,<br> HelpText<"Do not run the linker multi-threaded">;<br> <br>@@ -214,8 +216,6 @@ def no_whole_archive: F<"no-whole-archiv<br> def noinhibit_exec: F<"noinhibit-exec">,<br> HelpText<"Retain the executable output file whenever it is still usable">;<br> <br>-def nopie: F<"nopie">, HelpText<"Do not create a position independent executable">;<br>-<br> def no_omagic: Flag<["--"], "no-omagic">, MetaVarName<"<magic>">,<br> HelpText<"Do not set the text data sections to be writable">;<br> <br><br>Modified: lld/trunk/test/ELF/pie.s<br>URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/pie.s?rev=324043&r1=324042&r2=324043&view=diff">http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/pie.s?rev=324043&r1=324042&r2=324043&view=diff</a><hr>--- lld/trunk/test/ELF/pie.s (original)<br>+++ lld/trunk/test/ELF/pie.s Thu Feb 1 16:31:05 2018<br>@@ -48,7 +48,7 @@<br> # CHECK: Type: PT_DYNAMIC<br> <br> ## Check -nopie<br>-# RUN: ld.lld -nopie %t1.o -o %t2<br>+# RUN: ld.lld -no-pie %t1.o -o %t2<br> # RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s --check-prefix=NOPIE<br> # NOPIE-NOT: Type: SharedObject<hr>llvm-commits mailing list<br>llvm-commits@lists.llvm.org<br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>