<div dir="ltr">Thanks Vedant, got it!</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 31, 2018 at 11:06 PM, Vedant Kumar <span dir="ltr"><<a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the fix :). FWIW for smaller changes like this, I think it'd be fine to skip the Phab step.<br>
<br>
vedant<br>
<br>
> On Jan 31, 2018, at 2:13 PM, Max Moroz via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: dor1s<br>
> Date: Wed Jan 31 14:13:07 2018<br>
> New Revision: 323923<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=323923&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=323923&view=rev</a><br>
> Log:<br>
> [llvm-cov] Fix incorrect usage of .precision specifier in format() call.<br>
><br>
> Summary: Existing version doesn't work on Windows as it always prints 0.00.<br>
><br>
> Reviewers: Dor1s<br>
><br>
> Reviewed By: Dor1s<br>
><br>
> Subscribers: llvm-commits<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D42767" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D42767</a><br>
><br>
> Modified:<br>
>    llvm/trunk/tools/llvm-cov/<wbr>SourceCoverageViewHTML.cpp<br>
><br>
> Modified: llvm/trunk/tools/llvm-cov/<wbr>SourceCoverageViewHTML.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/SourceCoverageViewHTML.cpp?rev=323923&r1=323922&r2=323923&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>cov/SourceCoverageViewHTML.<wbr>cpp?rev=323923&r1=323922&r2=<wbr>323923&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/tools/llvm-cov/<wbr>SourceCoverageViewHTML.cpp (original)<br>
> +++ llvm/trunk/tools/llvm-cov/<wbr>SourceCoverageViewHTML.cpp Wed Jan 31 14:13:07 2018<br>
> @@ -343,7 +343,7 @@ void CoveragePrinterHTML::<wbr>emitFileSummar<br>
>     {<br>
>       raw_string_ostream RSO{S};<br>
>       if (Total)<br>
> -        RSO << format("%6.2f", 7, Pctg) << "% ";<br>
> +        RSO << format("%*.2f", 7, Pctg) << "% ";<br>
>       else<br>
>         RSO << "- ";<br>
>       RSO << '(' << Hit << '/' << Total << ')';<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div><br></div>