<div dir="ltr">Hello Geoff,<br><br>This commit broke the test CodeGen/AArch64/machine-outliner.mir on one of our builders:<br>r323676<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/7621">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/7621</a><br><br>. . .<br>Failing Tests (3):<br>    LLVM :: CodeGen/AArch64/machine-outliner.mir<br>    LLVM :: CodeGen/ARM/pr25838.ll<br>    LLVM :: DebugInfo/X86/string-offsets-multiple-cus.ll<br><br>Previous revision:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/7624">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/7624</a><br><br>Please have a look?<br><br>Thanks<br><br>Galina<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 29, 2018 at 10:57 AM, Geoff Berry via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: gberry<br>
Date: Mon Jan 29 10:57:07 2018<br>
New Revision: 323676<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=323676&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=323676&view=rev</a><br>
Log:<br>
[MachineVerifier] Add check that renamable operands aren't reserved registers.<br>
<br>
Summary:<br>
<br>
Reviewers: qcolombet, MatzeB<br>
<br>
Subscribers: arsenm, sdardis, nhaehnle, mcrosier, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D42449" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D42449</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/<wbr>MachineVerifier.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/<wbr>MachineVerifier.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineVerifier.cpp?rev=323676&r1=323675&r2=323676&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>CodeGen/MachineVerifier.cpp?<wbr>rev=323676&r1=323675&r2=<wbr>323676&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/CodeGen/<wbr>MachineVerifier.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/<wbr>MachineVerifier.cpp Mon Jan 29 10:57:07 2018<br>
@@ -1101,12 +1101,14 @@ MachineVerifier::<wbr>visitMachineOperand(con<br>
           }<br>
         }<br>
       }<br>
-      if (MO->isRenamable() &&<br>
-          ((MO->isDef() && MI->hasExtraDefRegAllocReq()) ||<br>
-           (MO->isUse() && MI->hasExtraSrcRegAllocReq()))<wbr>) {<br>
-        report("Illegal isRenamable setting for opcode with extra regalloc "<br>
-               "requirements",<br>
-               MO, MONum);<br>
+      if (MO->isRenamable()) {<br>
+        if ((MO->isDef() && MI->hasExtraDefRegAllocReq()) ||<br>
+            (MO->isUse() && MI->hasExtraSrcRegAllocReq()))<br>
+          report("Illegal isRenamable setting for opcode with extra regalloc "<br>
+                 "requirements",<br>
+                 MO, MONum);<br>
+        if (MRI->isReserved(Reg))<br>
+          report("isRenamable set on reserved register", MO, MONum);<br>
         return;<br>
       }<br>
     } else {<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>