<div dir="ltr">Interesting. You have created a patch that spans two repositories (llvm and clang). I wonder how you could do it.<div>For review process probably it is better to split patch according to repositories or at least add cfe-commits to subscribers.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">Thanks,<br>--Serge<br></div></div>
<br><div class="gmail_quote">2018-01-25 12:04 GMT+07:00 Dan Gohman via Phabricator via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sunfish created this revision.<br>
Herald added subscribers: llvm-commits, aheejin, jgravelle-google, dschuff, jfb.<br>
<br>
This creates an attribute for specifying an explicit import module name for a function declaration. It also renames the default module import name from "env" to "__linker_resolve", which should be less likely to collide with other things, though I'm open to other suggestions.<br>
<br>
The expectation is that it's the linker's job to resolve symbols that have the default module name, so that they're either linked to a definition in the same resulting module, or to a definition in a separate module with two-level namespacing. Modules with non-default names should be left alone.<br>
<br>
It only applies to functions for now; we can generalize it for global variables later if needed.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D42520" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D42520</a><br>
<br>
Files:<br>
  include/llvm/MC/MCSymbolWasm.h<br>
  lib/Target/WebAssembly/<wbr>MCTargetDesc/<wbr>WebAssemblyTargetStreamer.cpp<br>
  lib/Target/WebAssembly/<wbr>MCTargetDesc/<wbr>WebAssemblyTargetStreamer.h<br>
  lib/Target/WebAssembly/<wbr>WebAssemblyAsmPrinter.cpp<br>
  test/CodeGen/WebAssembly/<wbr>import-module.ll<br>
  test/MC/WebAssembly/comdat.ll<br>
  test/MC/WebAssembly/external-<wbr>func-address.ll<br>
  test/MC/WebAssembly/global-<wbr>ctor-dtor.ll<br>
  test/MC/WebAssembly/stack-ptr.<wbr>ll<br>
  test/MC/WebAssembly/weak-<wbr>alias.ll<br>
  test/MC/WebAssembly/weak.ll<br>
  tools/clang/include/clang/<wbr>Basic/Attr.td<br>
  tools/clang/lib/CodeGen/<wbr>TargetInfo.cpp<br>
  tools/clang/lib/Sema/<wbr>SemaDeclAttr.cpp<br>
  tools/clang/test/CodeGen/wasm-<wbr>import-module.c<br>
<br>
<br>______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>