<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">+ <a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><div class=""><br class=""></div><div class="">Whoops, didn't specify the repository first time around.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 18, 2018, at 3:54 PM, Roman Tereshin via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">rtereshin created this revision.<br class="">rtereshin added a reviewer: qcolombet.<br class=""><br class="">`struct crashreporter_annotations_t` gained one more `uint64_t` field in<br class="">`CRASHREPORTER_ANNOTATIONS_VERSION` 5<br class=""><br class="">causing an annoying clang warning:<br class=""><br class=""> llvm/lib/Support/PrettyStackTrace.cpp:92:65: warning: missing field 'abort_cause' initializer [-Wmissing-field-initializers]<br class=""> = { CRASHREPORTER_ANNOTATIONS_VERSION, 0, 0, 0, 0, 0, 0 };<br class=""> ^<br class=""> 1 warning generated<br class=""><br class="">Let's fix it.<br class=""><br class=""><br class=""><a href="https://reviews.llvm.org/D42268" class="">https://reviews.llvm.org/D42268</a><br class=""><br class="">Files:<br class=""> lib/Support/PrettyStackTrace.cpp<br class=""><br class=""><br class="">Index: lib/Support/PrettyStackTrace.cpp<br class="">===================================================================<br class="">--- lib/Support/PrettyStackTrace.cpp<br class="">+++ lib/Support/PrettyStackTrace.cpp<br class="">@@ -88,7 +88,11 @@<br class=""> CRASH_REPORTER_CLIENT_HIDDEN <br class=""> struct crashreporter_annotations_t gCRAnnotations <br class=""> __attribute__((section("__DATA," CRASHREPORTER_ANNOTATIONS_SECTION))) <br class="">+#if CRASHREPORTER_ANNOTATIONS_VERSION < 5<br class=""> = { CRASHREPORTER_ANNOTATIONS_VERSION, 0, 0, 0, 0, 0, 0 };<br class="">+#else<br class="">+ = { CRASHREPORTER_ANNOTATIONS_VERSION, 0, 0, 0, 0, 0, 0, 0 };<br class="">+#endif<br class=""> }<br class=""> #elif defined(__APPLE__) && HAVE_CRASHREPORTER_INFO<br class=""> extern "C" const char *__crashreporter_info__<br class=""><br class=""><br class=""><span id="cid:AE2A394B-B57A-4F13-BE87-1CDDE8596CDE@apple.com"><D42268.130506.patch></span></div></div></blockquote></div><br class=""></div></body></html>