<div dir="ltr">Hi Yvan,<div><br></div><div>Thanks for the heads up. I'll revert the commit. <br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 18, 2018 at 8:23 AM, Yvan Roux via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Clement,<br>
<br>
On 16 January 2018 at 10:12, Clement Courbet via Phabricator via<br>
<span class="">llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> This revision was automatically updated to reflect the committed changes.<br>
> Closed by commit rL322538: Add a value_type to ArrayRef. (authored by courbet, committed by ).<br>
><br>
> Repository:<br>
>   rL LLVM<br>
><br>
> <a href="https://reviews.llvm.org/D41666" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D41666</a><br>
><br>
> Files:<br>
>   llvm/trunk/include/llvm/ADT/<wbr>ArrayRef.h<br>
>   llvm/trunk/unittests/ADT/<wbr>ArrayRefTest.cpp<br>
<br>
</span>Bisecting shows that this patch broke ARM self hosted bots.  Clang now<br>
eats all the memory in stage2 builds on ARM boxes (bots run with -j4<br>
but I reproduced the issue running one command at a time).  I don't<br>
get what is wrong with your patch but hope it is clearer for you !<br>
<br>
logs are available here:<br>
<a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost-neon/builds/2750/steps/build%20stage%202/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-cmake-armv7-<wbr>a15-selfhost-neon/builds/2750/<wbr>steps/build%20stage%202/logs/<wbr>stdio</a><br>
<br>
Cheers,<br>
Yvan<br>
<div class="HOEnZb"><div class="h5"><br>
> Index: llvm/trunk/unittests/ADT/<wbr>ArrayRefTest.cpp<br>
> ==============================<wbr>==============================<wbr>=======<br>
> --- llvm/trunk/unittests/ADT/<wbr>ArrayRefTest.cpp<br>
> +++ llvm/trunk/unittests/ADT/<wbr>ArrayRefTest.cpp<br>
> @@ -52,6 +52,14 @@<br>
>      "Assigning from an initializer list");<br>
>  #endif<br>
><br>
> +// Check Typedefs.<br>
> +static_assert(<br>
> +    std::is_same<ArrayRef<int>::<wbr>value_type, int>::value,<br>
> +    "erroneous value_type");<br>
> +static_assert(<br>
> +    std::is_same<ArrayRef<const int>::value_type, int>::value,<br>
> +    "erroneous value_type");<br>
> +<br>
>  namespace {<br>
><br>
>  TEST(ArrayRefTest, AllocatorCopy) {<br>
> Index: llvm/trunk/include/llvm/ADT/<wbr>ArrayRef.h<br>
> ==============================<wbr>==============================<wbr>=======<br>
> --- llvm/trunk/include/llvm/ADT/<wbr>ArrayRef.h<br>
> +++ llvm/trunk/include/llvm/ADT/<wbr>ArrayRef.h<br>
> @@ -45,6 +45,7 @@<br>
>      using const_iterator = const T *;<br>
>      using size_type = size_t;<br>
>      using reverse_iterator = std::reverse_iterator<<wbr>iterator>;<br>
> +    using value_type = typename std::remove_cv<T>::type;<br>
><br>
>    private:<br>
>      /// The start of the array, in an external buffer.<br>
><br>
><br>
><br>
</div></div><div class="HOEnZb"><div class="h5">> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
><br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>