<div dir="ltr">Hi Simon,<div><br></div><div>Thanks for pointing this out. I believe the issue should be fixed by r321926. I'll keep an eye on the builder.</div><div><br></div><div>Cheers,</div><div>Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 6, 2018 at 10:12 AM, Simon Dardis <span dir="ltr"><<a href="mailto:Simon.Dardis@mips.com" target="_blank">Simon.Dardis@mips.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi Lang,<br>
<br>
At least one of the failure reports you have received is from llvm-mips-linux builder.<br>
<br>
The cause here is that MIPS32 doesn't support 8 byte atomic operations natively, so<br>
any library/application attempting to use them have to be linked with libatomic. See:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/llvm-mips-linux/builds/3418/steps/compile/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-mips-linux/<wbr>builds/3418/steps/compile/<wbr>logs/stdio</a><br>
<br>
I'm reproducing the error message here for reference:<br>
<br>
CMakeFiles/LLVMOrcJIT.dir/<wbr>Core.cpp.o: In function `llvm::orc::<wbr>AsynchronousSymbolQuery::<wbr>setDefinition(llvm::orc::<wbr>SymbolStringPtr, llvm::JITSymbol)':<br>
/scratch/bb-slaves/<wbr>mipsswbrd002/llvm-mips-linux/<wbr>llvm.src/lib/ExecutionEngine/<wbr>Orc/Core.cpp:(.text._<wbr>ZN4llvm3orc23AsynchronousSymbo<wbr>lQuery13setDefinitionENS0_<wbr>15SymbolStringPtrENS_<wbr>9JITSymbolE+0x8a0): undefined reference to `__atomic_fetch_sub_8'<br>
CMakeFiles/LLVMOrcJIT.dir/<wbr>Core.cpp.o: In function `std::_Rb_tree<llvm::orc::<wbr>SymbolStringPtr, std::pair<llvm::orc::<wbr>SymbolStringPtr const, llvm::JITSymbol>, std::_Select1st<std::pair<<wbr>llvm::orc::SymbolStringPtr const, llvm::JITSymbol> >, std::less<llvm::orc::<wbr>SymbolStringPtr>, std::allocator<std::pair<llvm:<wbr>:orc::SymbolStringPtr const, llvm::JITSymbol> > >::_M_erase(std::_Rb_tree_<wbr>node<std::pair<llvm::orc::<wbr>SymbolStringPtr const, llvm::JITSymbol> >*)':<br>
/scratch/bb-slaves/<wbr>mipsswbrd002/llvm-mips-linux/<wbr>llvm.src/lib/ExecutionEngine/<wbr>Orc/Core.cpp:(.text._ZNSt8_Rb_<wbr>treeIN4llvm3orc15SymbolStringP<wbr>trESt4pairIKS2_NS0_<wbr>9JITSymbolEESt10_Select1stIS6_<wbr>ESt4lessIS2_ESaIS6_EE8_M_<wbr>eraseEPSt13_Rb_tree_nodeIS6_E[<wbr>_ZNSt8_Rb_<wbr>treeIN4llvm3orc15SymbolStringP<wbr>trESt4pairIKS2_NS0_<wbr>9JITSymbolEESt10_Select1stIS6_<wbr>ESt4lessIS2_ESaIS6_EE8_M_<wbr>eraseEPSt13_Rb_tree_nodeIS6_E]<wbr>+0x94): undefined reference to `__atomic_fetch_sub_8'<br>
clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation)<br>
<br>
Thanks,<br>
Simon<br>
______________________________<wbr>__________<br>
From: llvm-commits [<a href="mailto:llvm-commits-bounces@lists.llvm.org">llvm-commits-bounces@lists.<wbr>llvm.org</a>] on behalf of Lang Hames via llvm-commits [<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>]<br>
Sent: Saturday, January 6, 2018 5:19 AM<br>
To: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
Subject: [llvm] r321927 - [ORC] Yet more debugging output to diagnose test failures.<br>
<div class="HOEnZb"><div class="h5"><br>
Author: lhames<br>
Date: Fri Jan  5 21:19:07 2018<br>
New Revision: 321927<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=321927&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=321927&view=rev</a><br>
Log:<br>
[ORC] Yet more debugging output to diagnose test failures.<br>
<br>
Modified:<br>
    llvm/trunk/lib/<wbr>ExecutionEngine/Orc/Core.cpp<br>
<br>
Modified: llvm/trunk/lib/<wbr>ExecutionEngine/Orc/Core.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp?rev=321927&r1=321926&r2=321927&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>ExecutionEngine/Orc/Core.cpp?<wbr>rev=321927&r1=321926&r2=<wbr>321927&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/<wbr>ExecutionEngine/Orc/Core.cpp (original)<br>
+++ llvm/trunk/lib/<wbr>ExecutionEngine/Orc/Core.cpp Fri Jan  5 21:19:07 2018<br>
@@ -46,7 +46,10 @@ void AsynchronousSymbolQuery::<wbr>setDefinit<br>
     << "OutstandingResolutions = " << OutstandingResolutions << "\n"<br>
     << "OutstandingFinalizations = " << OutstandingFinalizations << "\n"<br>
     << "Symbols.size() = " << Symbols.size() << "\n"<br>
-    << "Symbols.count(Name) = " << Symbols.count(Name) << "\n";<br>
+    << "Symbols.count(Name) = " << Symbols.count(Name) << "\n"<br>
+    << "Callback size = " << sizeof(<wbr>SymbolsResolvedCallback) << "\n"<br>
+    << "Callback offset = "<br>
+    << (size_t)((char*)&<wbr>NotifySymbolsResolved - (char*)this) << "\n";<br>
<br>
   assert(!Symbols.count(Name) &&<br>
          "Symbol has already been assigned an address");<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>