<div dir="ltr">Approved.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jan 7, 2018 at 10:03 PM, Shoaib Meenai <span dir="ltr"><<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="m_8432958857768134999WordSection1">
<p class="MsoNormal">Andrew (the patch author) requested this be picked to the 6.0 branch. Rui, do you approve?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">llvm-commits <<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.<wbr>llvm.org</a>> on behalf of Shoaib Meenai via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Reply-To: </b>Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>><br>
<b>Date: </b>Sunday, January 7, 2018 at 9:59 PM<br>
<b>To: </b>"<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>" <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject: </b>[lld] r321983 - [COFF] Initalize ErrorHandler with CanExitEarly value<u></u><u></u></span></p>
</div><span class="">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Author: smeenai<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Date: Sun Jan 7 21:58:36 2018<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">New Revision: 321983<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</span><div>
<p class="MsoNormal">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D321983-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=fk7PeUgmwTUgCBtB68HduWEQUwyoCwjrViVysM5qEYE&e=" target="_blank">
https://urldefense.proofpoint.<wbr>com/v2/url?u=http-3A__llvm.<wbr>org_viewvc_llvm-2Dproject-<wbr>3Frev-3D321983-26view-3Drev&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=o3_<wbr>QVufrb5NLYnACh-<wbr>1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=<wbr>fk7PeUgmwTUgCBtB68HduWEQUwyoCw<wbr>jrViVysM5qEYE&e=</a><u></u><u></u></p>
</div><span class="">
<div>
<p class="MsoNormal">Log:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">[COFF] Initalize ErrorHandler with CanExitEarly value<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Previously, the COFF driver would call exit(1) from the<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">ErrorHandler in the case of a link error, even if<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">CanExitEarly=false was specified. Now it initializes<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">the ErrorHandler in the same way that the ELF driver does.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Patch by Andrew Kelley.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</span><div>
<p class="MsoNormal">Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D41803&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=3qU1avvt0PQHDV8uCN4Hs7B4O8_p5U09hIZ9Q0Qgqso&e=" target="_blank">
https://urldefense.proofpoint.<wbr>com/v2/url?u=https-3A__<wbr>reviews.llvm.org_D41803&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=o3_<wbr>QVufrb5NLYnACh-<wbr>1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=<wbr>3qU1avvt0PQHDV8uCN4Hs7B4O8_<wbr>p5U09hIZ9Q0Qgqso&e=</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Modified:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> lld/trunk/COFF/Driver.cpp<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Modified: lld/trunk/COFF/Driver.cpp<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_COFF_Driver.cpp-3Frev-3D321983-26r1-3D321982-26r2-3D321983-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=l60EZM4I9sqgjKUJh8vgkT-udkI7kk3KHrTDrSIebv8&e=" target="_blank">
https://urldefense.proofpoint.<wbr>com/v2/url?u=http-3A__llvm.<wbr>org_viewvc_llvm-2Dproject_lld_<wbr>trunk_COFF_Driver.cpp-3Frev-<wbr>3D321983-26r1-3D321982-26r2-<wbr>3D321983-26view-3Ddiff&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=o3_<wbr>QVufrb5NLYnACh-<wbr>1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=<wbr>l60EZM4I9sqgjKUJh8vgkT-<wbr>udkI7kk3KHrTDrSIebv8&e=</a><u></u><u></u></p>
</div><span class="">
<div>
<p class="MsoNormal">==============================<wbr>==============================<wbr>==================<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">--- lld/trunk/COFF/Driver.cpp (original)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">+++ lld/trunk/COFF/Driver.cpp Sun Jan 7 21:58:36 2018<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">@@ -57,6 +57,7 @@ bool link(ArrayRef<const char *> Args, b<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> errorHandler().<wbr>ErrorLimitExceededMsg =<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> "too many errors emitted, stopping now"<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> " (use /ERRORLIMIT:0 to see all errors)";<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">+ errorHandler().ExitEarly = CanExitEarly;<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> Config = make<Configuration>();<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> Config->Argv = {Args.begin(), Args.end()};<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> Config->CanExitEarly = CanExitEarly;<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">______________________________<wbr>_________________<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">llvm-commits mailing list<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><u></u><u></u></p>
</div>
</span><div>
<p class="MsoNormal"><a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=o3_QVufrb5NLYnACh-1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=WKBfYpw8TdyVRbbkrKIIGpjjzjI5UXMZKblXWcQ6Eps&e=" target="_blank">https://urldefense.proofpoint.<wbr>com/v2/url?u=http-3A__lists.<wbr>llvm.org_cgi-2Dbin_mailman_<wbr>listinfo_llvm-2Dcommits&d=<wbr>DwIGaQ&c=<wbr>5VD0RTtNlTh3ycd41b3MUw&r=<wbr>o3kDXzdBUE3ljQXKeTWOMw&m=o3_<wbr>QVufrb5NLYnACh-<wbr>1P2fkHw7LqwFYpAQ4Q-vPPbxw&s=<wbr>WKBfYpw8TdyVRbbkrKIIGpjjzjI5UX<wbr>MZKblXWcQ6Eps&e=</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</blockquote></div><br></div>