<div dir="ltr">Chapter9 was specifically missing from the parent directory's CMakeLists.txt - so it wouldn't be caught by any builder. Hopefully that's addressed now.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 20, 2017 at 1:05 PM Robinson, Paul <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Is there a bot that builds the examples?  It would obviously<br>
be nice to catch this kind of thing when it happens.<br>
--paulr<br>
<br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On Behalf<br>
> Of David Blaikie via llvm-commits<br>
> Sent: Wednesday, December 20, 2017 11:37 AM<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> Subject: [llvm] r321214 - PR35705: Fix Chapter 9 example code for API<br>
> changes to DIBuilder<br>
><br>
> Author: dblaikie<br>
> Date: Wed Dec 20 11:36:54 2017<br>
> New Revision: 321214<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=321214&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=321214&view=rev</a><br>
> Log:<br>
> PR35705: Fix Chapter 9 example code for API changes to DIBuilder<br>
><br>
> Modified:<br>
>     llvm/trunk/docs/tutorial/LangImpl09.rst<br>
>     llvm/trunk/examples/Kaleidoscope/CMakeLists.txt<br>
>     llvm/trunk/examples/Kaleidoscope/Chapter9/toy.cpp<br>
><br>
> Modified: llvm/trunk/docs/tutorial/LangImpl09.rst<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/docs/tutorial/LangImpl09.rst?rev=321214&r1=321213&r2=32<br>
> 1214&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- llvm/trunk/docs/tutorial/LangImpl09.rst (original)<br>
> +++ llvm/trunk/docs/tutorial/LangImpl09.rst Wed Dec 20 11:36:54 2017<br>
> @@ -197,7 +197,7 @@ expressions:<br>
>      if (DblTy)<br>
>        return DblTy;<br>
><br>
> -    DblTy = DBuilder->createBasicType("double", 64, 64,<br>
> dwarf::DW_ATE_float);<br>
> +    DblTy = DBuilder->createBasicType("double", 64, dwarf::DW_ATE_float);<br>
>      return DblTy;<br>
>    }<br>
><br>
> @@ -208,7 +208,8 @@ And then later on in ``main`` when we're<br>
>    DBuilder = new DIBuilder(*TheModule);<br>
><br>
>    KSDbgInfo.TheCU = DBuilder->createCompileUnit(<br>
> -      dwarf::DW_LANG_C, "fib.ks", ".", "Kaleidoscope Compiler", 0, "",<br>
> 0);<br>
> +      dwarf::DW_LANG_C, DBuilder->createFile("fib.ks", "."),<br>
> +      "Kaleidoscope Compiler", 0, "", 0);<br>
><br>
>  There are a couple of things to note here. First, while we're producing a<br>
>  compile unit for a language called Kaleidoscope we used the language<br>
><br>
> Modified: llvm/trunk/examples/Kaleidoscope/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/examples/Kaleidoscope/CMakeLists.txt?rev=321214&r1=3212<br>
> 13&r2=321214&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- llvm/trunk/examples/Kaleidoscope/CMakeLists.txt (original)<br>
> +++ llvm/trunk/examples/Kaleidoscope/CMakeLists.txt Wed Dec 20 11:36:54<br>
> 2017<br>
> @@ -14,3 +14,4 @@ add_subdirectory(Chapter5)<br>
>  add_subdirectory(Chapter6)<br>
>  add_subdirectory(Chapter7)<br>
>  add_subdirectory(Chapter8)<br>
> +add_subdirectory(Chapter9)<br>
><br>
> Modified: llvm/trunk/examples/Kaleidoscope/Chapter9/toy.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/examples/Kaleidoscope/Chapter9/toy.cpp?rev=321214&r1=32<br>
> 1213&r2=321214&view=diff<br>
> ==========================================================================<br>
> ====<br>
> --- llvm/trunk/examples/Kaleidoscope/Chapter9/toy.cpp (original)<br>
> +++ llvm/trunk/examples/Kaleidoscope/Chapter9/toy.cpp Wed Dec 20 11:36:54<br>
> 2017<br>
> @@ -823,7 +823,7 @@ DIType *DebugInfo::getDoubleTy() {<br>
>    if (DblTy)<br>
>      return DblTy;<br>
><br>
> -  DblTy = DBuilder->createBasicType("double", 64, 64,<br>
> dwarf::DW_ATE_float);<br>
> +  DblTy = DBuilder->createBasicType("double", 64, dwarf::DW_ATE_float);<br>
>    return DblTy;<br>
>  }<br>
><br>
> @@ -1436,7 +1436,8 @@ int main() {<br>
>    // Currently down as "fib.ks" as a filename since we're redirecting<br>
> stdin<br>
>    // but we'd like actual source locations.<br>
>    KSDbgInfo.TheCU = DBuilder->createCompileUnit(<br>
> -      dwarf::DW_LANG_C, "fib.ks", ".", "Kaleidoscope Compiler", 0, "",<br>
> 0);<br>
> +      dwarf::DW_LANG_C, DBuilder->createFile("fib.ks", "."),<br>
> +      "Kaleidoscope Compiler", 0, "", 0);<br>
><br>
>    // Run the main "interpreter loop" now.<br>
>    MainLoop();<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>