<div dir="ltr">Most likely. I was pointed to the problem on PowerPC so I can't be 100% but AArch also has pre-increment stores so it's reasonable to assume it's the same. <div><br></div><div>-Nirav<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 20, 2017 at 2:19 PM, Diana Picus <span dir="ltr"><<a href="mailto:diana.picus@linaro.org" target="_blank">diana.picus@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Dave,<br>
<br>
Is this going to fix this failure [1] ? If not, could you please have<br>
a look at it? I was just about to revert r321089.<br>
<br>
Thanks,<br>
Diana<br>
<br>
[1] <a href="http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3575" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-cmake-aarch64-<wbr>full/builds/3575</a><br>
<br>
On 20 December 2017 at 20:06, Nirav Dave via llvm-commits<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: niravd<br>
> Date: Wed Dec 20 11:06:47 2017<br>
> New Revision: 321204<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=321204&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=321204&view=rev</a><br>
> Log:<br>
> [DAG] Fix condition on overlapping store check.<br>
><br>
> Prevent overlapping store elision when overlapping store is<br>
> pre-inc/dec as analysis is wrong in these cases.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=321204&r1=321203&r2=321204&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>CodeGen/SelectionDAG/<wbr>DAGCombiner.cpp?rev=321204&r1=<wbr>321203&r2=321204&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp (original)<br>
> +++ llvm/trunk/lib/CodeGen/<wbr>SelectionDAG/DAGCombiner.cpp Wed Dec 20 11:06:47 2017<br>
> @@ -13786,8 +13786,8 @@ SDValue DAGCombiner::visitSTORE(SDNode *<br>
><br>
>    // Deal with elidable overlapping chained stores.<br>
>    if (StoreSDNode *ST1 = dyn_cast<StoreSDNode>(Chain))<br>
> -    if (OptLevel != CodeGenOpt::None && ST1->isUnindexed() &&<br>
> -        !ST1->isVolatile() && ST1->hasOneUse() &&<br>
> +    if (OptLevel != CodeGenOpt::None && ST->isUnindexed() &&<br>
> +        ST1->isUnindexed() && !ST1->isVolatile() && ST1->hasOneUse() &&<br>
>          !ST1->getBasePtr().isUndef() && !ST->isVolatile()) {<br>
>        BaseIndexOffset STBasePtr = BaseIndexOffset::match(ST-><wbr>getBasePtr(), DAG);<br>
>        BaseIndexOffset ST1BasePtr =<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>