<div dir="ltr">This is not your fault, but I think I dislike multi-argument hasArg function. It should've been named hasAnyOf or something like that, so that it's obvious that that's not hasAllOf.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 15, 2017 at 3:51 PM, Shoaib Meenai via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: smeenai<br>
Date: Fri Dec 15 15:51:14 2017<br>
New Revision: 320892<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=320892&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=320892&view=rev</a><br>
Log:<br>
[COFF] Simplify hasArgs calls. NFC<br>
<br>
We can just pass multiple options to hasArgs (which will check for any<br>
of those options being present) instead of calling it multiple times.<br>
<br>
Modified:<br>
    lld/trunk/COFF/Driver.cpp<br>
<br>
Modified: lld/trunk/COFF/Driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Driver.cpp?rev=320892&r1=320891&r2=320892&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/COFF/Driver.<wbr>cpp?rev=320892&r1=320891&r2=<wbr>320892&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/COFF/Driver.cpp (original)<br>
+++ lld/trunk/COFF/Driver.cpp Fri Dec 15 15:51:14 2017<br>
@@ -805,12 +805,11 @@ void LinkerDriver::link(ArrayRef<<wbr>const c<br>
   errorHandler().Verbose = Config->Verbose;<br>
<br>
   // Handle /force or /force:unresolved<br>
-  if (Args.hasArg(OPT_force) || Args.hasArg(OPT_force_<wbr>unresolved))<br>
+  if (Args.hasArg(OPT_force, OPT_force_unresolved))<br>
     Config->Force = true;<br>
<br>
   // Handle /debug<br>
-  if (Args.hasArg(OPT_debug) || Args.hasArg(OPT_debug_dwarf) ||<br>
-      Args.hasArg(OPT_debug_ghash)) {<br>
+  if (Args.hasArg(OPT_debug, OPT_debug_dwarf, OPT_debug_ghash)) {<br>
     Config->Debug = true;<br>
     if (auto *Arg = Args.getLastArg(OPT_debugtype)<wbr>)<br>
       Config->DebugTypes = parseDebugType(Arg->getValue()<wbr>);<br>
@@ -1152,7 +1151,7 @@ void LinkerDriver::link(ArrayRef<<wbr>const c<br>
   }<br>
<br>
   // Disable PDB generation if the user requested it.<br>
-  if (Args.hasArg(OPT_nopdb) || Args.hasArg(OPT_debug_dwarf))<br>
+  if (Args.hasArg(OPT_nopdb, OPT_debug_dwarf))<br>
     Config->PDBPath = "";<br>
<br>
   // Set default image base if /base is not given.<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>