<div dir="ltr">Yeah. Unfortunately that's true. I tried to make a change so that hasArg takes only one argument, and it causes a lot of compile failures.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 15, 2017 at 4:22 PM, Shoaib Meenai <span dir="ltr"><<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="m_-1956998511231409760WordSection1">
<p class="MsoNormal">I agree on that being slightly confusing. I think it's used commonly enough that developers would be familiar with the semantics though.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>><br>
<b>Date: </b>Friday, December 15, 2017 at 4:12 PM<br>
<b>To: </b>Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>><br>
<b>Cc: </b>llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: [lld] r320892 - [COFF] Simplify hasArgs calls. NFC<u></u><u></u></span></p>
</div><div><div class="h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This is not your fault, but I think I dislike multi-argument hasArg function. It should've been named hasAnyOf or something like that, so that it's obvious that that's not hasAllOf.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Fri, Dec 15, 2017 at 3:51 PM, Shoaib Meenai via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Author: smeenai<br>
Date: Fri Dec 15 15:51:14 2017<br>
New Revision: 320892<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D320892-26view-3Drev&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AzVwzgmXhdIf4n9m_zQGkFvOvz1CgkmblNsyw-rMEs4&s=_DjCNpTMW1IeqXtyjlTtuA2XT0NKtDTKra5LIPrB1HA&e=" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project?rev=320892&view=rev</a><br>
Log:<br>
[COFF] Simplify hasArgs calls. NFC<br>
<br>
We can just pass multiple options to hasArgs (which will check for any<br>
of those options being present) instead of calling it multiple times.<br>
<br>
Modified:<br>
lld/trunk/COFF/Driver.cpp<br>
<br>
Modified: lld/trunk/COFF/Driver.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_COFF_Driver.cpp-3Frev-3D320892-26r1-3D320891-26r2-3D320892-26view-3Ddiff&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AzVwzgmXhdIf4n9m_zQGkFvOvz1CgkmblNsyw-rMEs4&s=6Mtn1v4xVpLBnLEj9V_6611JCShdOVfweeLVb_nCz34&e=" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/COFF/Driver.<wbr>cpp?rev=320892&r1=320891&r2=<wbr>320892&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/COFF/Driver.cpp (original)<br>
+++ lld/trunk/COFF/Driver.cpp Fri Dec 15 15:51:14 2017<br>
@@ -805,12 +805,11 @@ void LinkerDriver::link(ArrayRef<<wbr>const c<br>
errorHandler().Verbose = Config->Verbose;<br>
<br>
// Handle /force or /force:unresolved<br>
- if (Args.hasArg(OPT_force) || Args.hasArg(OPT_force_<wbr>unresolved))<br>
+ if (Args.hasArg(OPT_force, OPT_force_unresolved))<br>
Config->Force = true;<br>
<br>
// Handle /debug<br>
- if (Args.hasArg(OPT_debug) || Args.hasArg(OPT_debug_dwarf) ||<br>
- Args.hasArg(OPT_debug_ghash)) {<br>
+ if (Args.hasArg(OPT_debug, OPT_debug_dwarf, OPT_debug_ghash)) {<br>
Config->Debug = true;<br>
if (auto *Arg = Args.getLastArg(OPT_debugtype)<wbr>)<br>
Config->DebugTypes = parseDebugType(Arg->getValue()<wbr>);<br>
@@ -1152,7 +1151,7 @@ void LinkerDriver::link(ArrayRef<<wbr>const c<br>
}<br>
<br>
// Disable PDB generation if the user requested it.<br>
- if (Args.hasArg(OPT_nopdb) || Args.hasArg(OPT_debug_dwarf))<br>
+ if (Args.hasArg(OPT_nopdb, OPT_debug_dwarf))<br>
Config->PDBPath = "";<br>
<br>
// Set default image base if /base is not given.<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AzVwzgmXhdIf4n9m_zQGkFvOvz1CgkmblNsyw-rMEs4&s=6pJlwUhvceEitagkTdH9YAV-fdw15PdX5tad12MLo84&e=" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div>