<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Dec 14, 2017 at 1:22 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Thu, Dec 14, 2017 at 10:27 AM, Rafael Avila de Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Is libwidevinecdm.so available somewhere?<br></blockquote><div><br></div></span><div>If you have a recent version of Chrome installed on your machine, you should be able to find a copy in your installation directory.</div><span class=""><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
We can try to make it a warning, but what is the correct thing to do<br>
about _ZN8tcmalloc11ThreadCache17thr<wbr>eadlocal_heap_E? Should we skip it?<br>
Handle it as if it was global?<br></blockquote><div><br></div></span><div>I think we should skip it. It looks like the symbol itself is supposed to be local.</div><div><a href="https://cs.chromium.org/chromium/src/third_party/tcmalloc/vendor/src/thread_cache.h?q=threadlocal_heap&sq=package:chromium&l=255" target="_blank">https://cs.chromium.org/<wbr>chromium/src/third_party/<wbr>tcmalloc/vendor/src/thread_<wbr>cache.h?q=threadlocal_heap&sq=<wbr>package:chromium&l=255</a></div></div></div></div></blockquote><div><br></div><div>Is it? It's a static member of some class and not a file local symbol.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Peter</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Cheers,<br>
Rafael<br>
<div class="m_-4395183605995781752gmail-HOEnZb"><div class="m_-4395183605995781752gmail-h5"><span class=""><br>
Hans Wennborg via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> writes:<br>
<br>
> hans added a comment.<br>
><br>
> This fixes the assert, now we error on it, which breaks our build all the same. It's a pre-built .so, which I'm not sure exactly where it comes from:<br>
><br>
> FAILED: libwidevinecdmadapter.so<br>
> ../../../../../../../../work/l<wbr>lvm/build.goma/bin/clang++ -shared libwidevinecdm.so -Wl,--fatal-warnings -Wl,--build-id=sha1 -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=lld -Wl,--icf=all -flto=thin -Wl,--thinlto-jobs=8 -Wl,--thinlto-cache-dir=thinlt<wbr>o-cache -Wl,--thinlto-cache-policy,cac<wbr>he_size=10\% -Wl,--lto-O0 -fwhole-program-vtables -m64 -Werror -Wl,-O1 -Wl,--gc-sections -Wl,--gdb-index -nostdlib++ --sysroot=../../build/linux/de<wbr>bian_stretch_amd64-sysroot -L../../build/linux/debian_str<wbr>etch_amd64-sysroot/lib/x86_64-<wbr>linux-gnu -Wl,-rpath-link=../../build/li<wbr>nux/debian_stretch_amd64-sysro<wbr>ot/lib/x86_64-linux-gnu -L../../build/linux/debian_str<wbr>etch_amd64-sysroot/usr/lib/x86<wbr>_64-linux-gnu -Wl,-rpath-link=../../build/li<wbr>nux/debian_stretch_amd64-sysro<wbr>ot/usr/lib/x86_64-linux-gnu -fsanitize=cfi-vcall -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./libwidevinecdmadapter.so" -Wl,-soname="libwidevinecdmada<wbr>pter.so" @"./libwidevinecdmadapter.so.r<wbr>sp"<br>
> /usr/local/google/work/chromiu<wbr>m/src/out/release/../../../../<wbr>../../../../work/llvm/build.<wbr>goma/bin/ld.lld: error: Found local symbol '_ZN8tcmalloc11ThreadCache17th<wbr>readlocal_heap_E' in global part of symbol table in file libwidevinecdm.so<br>
> clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation)<br>
> ninja: build stopped: subcommand failed.<br>
><br>
> Maybe the erorr could be downgraded to a warning? (We'd need to not treat warnings as errors for this target on our side I suppose)<br>
><br>
><br>
> <a href="https://reviews.llvm.org/D41215" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4121<wbr>5</a><br></span>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><span class="HOEnZb"><font color="#888888"><br>
</font></span></div></div></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_-4395183605995781752gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</font></span></div></div>
</blockquote></div><br></div></div>