<div dir="ltr"><span style="font-family:monospace,monospace">Hello Sam,<br><br>This commit broke one of our builders:<br><a href="http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/3698">http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/3698</a><br><br>. . .<br>FAILED: /usr/local/gcc-7.1/bin/g++-7.1   -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/ObjectYAML -I/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/lib/ObjectYAML -Iinclude -I/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include -Wno-noexcept-type -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O3  -fPIC   -UNDEBUG  -fno-exceptions -fno-rtti -MD -MT lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/ObjectYAML.cpp.o -MF lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/ObjectYAML.cpp.o.d -o lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/ObjectYAML.cpp.o -c /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/lib/ObjectYAML/ObjectYAML.cpp<br>In file included from /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include/llvm/ObjectYAML/ObjectYAML.h:16:0,<br>                 from /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/lib/ObjectYAML/ObjectYAML.cpp:14:<br>/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include/llvm/ObjectYAML/WasmYAML.h:37:48: error: extra ‘;’ [-Werror=pedantic]<br> LLVM_YAML_STRONG_TYPEDEF(uint32_t, SymbolFlags);<br>                                                ^<br>/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include/llvm/ObjectYAML/WasmYAML.h:38:49: error: extra ‘;’ [-Werror=pedantic]<br> LLVM_YAML_STRONG_TYPEDEF(uint32_t, SegmentFlags);<br>                                                 ^<br>/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include/llvm/ObjectYAML/WasmYAML.h:39:47: error: extra ‘;’ [-Werror=pedantic]<br> LLVM_YAML_STRONG_TYPEDEF(uint32_t, LimitFlags);<br>                                               ^<br>cc1plus: all warnings being treated as errors<br>FAILED: /usr/local/gcc-7.1/bin/g++-7.1   -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/ObjectYAML -I/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/lib/ObjectYAML -Iinclude -I/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include -Wno-noexcept-type -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O3  -fPIC   -UNDEBUG  -fno-exceptions -fno-rtti -MD -MT lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/WasmYAML.cpp.o -MF lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/WasmYAML.cpp.o.d -o lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/WasmYAML.cpp.o -c /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/lib/ObjectYAML/WasmYAML.cpp<br>In file included from /home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/lib/ObjectYAML/WasmYAML.cpp:14:0:<br>/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include/llvm/ObjectYAML/WasmYAML.h:37:48: error: extra ‘;’ [-Werror=pedantic]<br> LLVM_YAML_STRONG_TYPEDEF(uint32_t, SymbolFlags);<br>                                                ^<br>/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include/llvm/ObjectYAML/WasmYAML.h:38:49: error: extra ‘;’ [-Werror=pedantic]<br> LLVM_YAML_STRONG_TYPEDEF(uint32_t, SegmentFlags);<br>                                                 ^<br>/home/buildslave/am1i-slv2/ubuntu-gcc7.1-werror/llvm/include/llvm/ObjectYAML/WasmYAML.h:39:47: error: extra ‘;’ [-Werror=pedantic]<br> LLVM_YAML_STRONG_TYPEDEF(uint32_t, LimitFlags);<br>                                               ^<br>cc1plus: all warnings being treated as errors<br><br>Please have a look?<br><br>Thanks<br><br>Galina<br></span></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 13, 2017 at 2:02 PM, Sam Clegg via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: sbc<br>
Date: Wed Dec 13 14:02:25 2017<br>
New Revision: 320642<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=320642&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=320642&view=rev</a><br>
Log:<br>
[WebAssembly] Use bitfield types in wasm YAML representation<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D41202" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D41202</a><br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/<wbr>ObjectYAML/WasmYAML.h<br>
    llvm/trunk/lib/ObjectYAML/<wbr>WasmYAML.cpp<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/array-fill.ll<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/bss.ll<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/explicit-sections.<wbr>ll<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/init-fini-array.ll<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/unnamed-data.ll<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/visibility.ll<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/weak-alias.ll<br>
    llvm/trunk/test/MC/<wbr>WebAssembly/weak.ll<br>
    llvm/trunk/test/ObjectYAML/<wbr>wasm/elem_section.yaml<br>
    llvm/trunk/test/ObjectYAML/<wbr>wasm/import_section.yaml<br>
    llvm/trunk/test/ObjectYAML/<wbr>wasm/linking_section.yaml<br>
    llvm/trunk/test/ObjectYAML/<wbr>wasm/memory_section.yaml<br>
    llvm/trunk/test/ObjectYAML/<wbr>wasm/table_section.yaml<br>
    llvm/trunk/test/ObjectYAML/<wbr>wasm/weak_symbols.yaml<br>
    llvm/trunk/test/tools/llvm-nm/<wbr>wasm/weak-symbols.yaml<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>ObjectYAML/WasmYAML.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ObjectYAML/WasmYAML.h?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/ObjectYAML/WasmYAML.h?<wbr>rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>ObjectYAML/WasmYAML.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>ObjectYAML/WasmYAML.h Wed Dec 13 14:02:25 2017<br>
@@ -34,13 +34,16 @@ LLVM_YAML_STRONG_TYPEDEF(<wbr>int32_t, Signat<br>
 LLVM_YAML_STRONG_TYPEDEF(<wbr>uint32_t, ExportKind)<br>
 LLVM_YAML_STRONG_TYPEDEF(<wbr>uint32_t, Opcode)<br>
 LLVM_YAML_STRONG_TYPEDEF(<wbr>uint32_t, RelocType)<br>
+LLVM_YAML_STRONG_TYPEDEF(<wbr>uint32_t, SymbolFlags);<br>
+LLVM_YAML_STRONG_TYPEDEF(<wbr>uint32_t, SegmentFlags);<br>
+LLVM_YAML_STRONG_TYPEDEF(<wbr>uint32_t, LimitFlags);<br>
<br>
 struct FileHeader {<br>
   yaml::Hex32 Version;<br>
 };<br>
<br>
 struct Limits {<br>
-  yaml::Hex32 Flags;<br>
+  LimitFlags Flags;<br>
   yaml::Hex32 Initial;<br>
   yaml::Hex32 Maximum;<br>
 };<br>
@@ -113,7 +116,7 @@ struct SegmentInfo {<br>
   uint32_t Index;<br>
   StringRef Name;<br>
   uint32_t Alignment;<br>
-  uint32_t Flags;<br>
+  SegmentFlags Flags;<br>
 };<br>
<br>
 struct Signature {<br>
@@ -125,7 +128,7 @@ struct Signature {<br>
<br>
 struct SymbolInfo {<br>
   StringRef Name;<br>
-  uint32_t Flags;<br>
+  SymbolFlags Flags;<br>
 };<br>
<br>
 struct Section {<br>
@@ -334,6 +337,18 @@ template <> struct MappingTraits<WasmYAM<br>
   static void mapping(IO &IO, WasmYAML::Global &Global);<br>
 };<br>
<br>
+template <> struct ScalarBitSetTraits<WasmYAML::<wbr>LimitFlags> {<br>
+  static void bitset(IO &IO, WasmYAML::LimitFlags &Value);<br>
+};<br>
+<br>
+template <> struct ScalarBitSetTraits<WasmYAML::<wbr>SymbolFlags> {<br>
+  static void bitset(IO &IO, WasmYAML::SymbolFlags &Value);<br>
+};<br>
+<br>
+template <> struct ScalarBitSetTraits<WasmYAML::<wbr>SegmentFlags> {<br>
+  static void bitset(IO &IO, WasmYAML::SegmentFlags &Value);<br>
+};<br>
+<br>
 template <> struct ScalarEnumerationTraits<<wbr>WasmYAML::SectionType> {<br>
   static void enumeration(IO &IO, WasmYAML::SectionType &Type);<br>
 };<br>
<br>
Modified: llvm/trunk/lib/ObjectYAML/<wbr>WasmYAML.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ObjectYAML/WasmYAML.cpp?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>ObjectYAML/WasmYAML.cpp?rev=<wbr>320642&r1=320641&r2=320642&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/ObjectYAML/<wbr>WasmYAML.cpp (original)<br>
+++ llvm/trunk/lib/ObjectYAML/<wbr>WasmYAML.cpp Wed Dec 13 14:02:25 2017<br>
@@ -365,6 +365,28 @@ void MappingTraits<WasmYAML::<wbr>SymbolInfo><br>
   IO.mapRequired("Flags", Info.Flags);<br>
 }<br>
<br>
+void ScalarBitSetTraits<WasmYAML::<wbr>LimitFlags>::bitset(<br>
+    IO &IO, WasmYAML::LimitFlags &Value) {<br>
+#define BCase(X) IO.bitSetCase(Value, #X, wasm::WASM_LIMITS_FLAG_##X)<br>
+  BCase(HAS_MAX);<br>
+#undef BCase<br>
+}<br>
+<br>
+void ScalarBitSetTraits<WasmYAML::<wbr>SegmentFlags>::bitset(<br>
+    IO &IO, WasmYAML::SegmentFlags &Value) {<br>
+}<br>
+<br>
+void ScalarBitSetTraits<WasmYAML::<wbr>SymbolFlags>::bitset(<br>
+    IO &IO, WasmYAML::SymbolFlags &Value) {<br>
+#define BCaseMask(M, X) IO.maskedBitSetCase(Value, #X, wasm::WASM_SYMBOL_##X, wasm::WASM_SYMBOL_##M)<br>
+  //BCaseMask(BINDING_MASK, BINDING_GLOBAL);<br>
+  BCaseMask(BINDING_MASK, BINDING_WEAK);<br>
+  BCaseMask(BINDING_MASK, BINDING_LOCAL);<br>
+  //BCaseMask(VISIBILITY_MASK, VISIBILITY_DEFAULT);<br>
+  BCaseMask(VISIBILITY_MASK, VISIBILITY_HIDDEN);<br>
+#undef BCaseMask<br>
+}<br>
+<br>
 void ScalarEnumerationTraits<<wbr>WasmYAML::ValueType>::<wbr>enumeration(<br>
     IO &IO, WasmYAML::ValueType &Type) {<br>
 #define ECase(X) IO.enumCase(Type, #X, wasm::WASM_TYPE_##X);<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/array-fill.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/array-fill.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/array-fill.ll?rev=<wbr>320642&r1=320641&r2=320642&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/array-fill.ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/array-fill.ll Wed Dec 13 14:02:25 2017<br>
@@ -17,10 +17,10 @@ target triple = "wasm32-unknown-unknown-<br>
 ; CHECK-NEXT:     DataSize:        2<br>
 ; CHECK-NEXT:     SymbolInfo:<br>
 ; CHECK-NEXT:       - Name:            gBd<br>
-; CHECK-NEXT:         Flags:           4<br>
+; CHECK-NEXT:         Flags:           [ VISIBILITY_HIDDEN ]<br>
 ; CHECK-NEXT:     SegmentInfo:<br>
 ; CHECK-NEXT:       - Index:           0<br>
 ; CHECK-NEXT:         Name:            .data<br>
 ; CHECK-NEXT:         Alignment:       1<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT: ...<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/bss.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/bss.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/bss.ll?rev=320642&<wbr>r1=320641&r2=320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/bss.ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/bss.ll Wed Dec 13 14:02:25 2017<br>
@@ -76,17 +76,17 @@<br>
 ; CHECK-NEXT:       - Index:           0<br>
 ; CHECK-NEXT:         Name:            .bss.g0<br>
 ; CHECK-NEXT:         Alignment:       4<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           1<br>
 ; CHECK-NEXT:         Name:            .bss.g1<br>
 ; CHECK-NEXT:         Alignment:       4<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           2<br>
 ; CHECK-NEXT:         Name:            .bss.foo<br>
 ; CHECK-NEXT:         Alignment:       1<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           3<br>
 ; CHECK-NEXT:         Name:            .bss.bar<br>
 ; CHECK-NEXT:         Alignment:       1<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT: ...<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/explicit-sections.<wbr>ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/explicit-sections.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/explicit-sections.<wbr>ll?rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/explicit-sections.<wbr>ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/explicit-sections.<wbr>ll Wed Dec 13 14:02:25 2017<br>
@@ -71,13 +71,13 @@<br>
 ; CHECK-NEXT:       - Index:           0<br>
 ; CHECK-NEXT:         Name:            .data.global0<br>
 ; CHECK-NEXT:         Alignment:       8<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           1<br>
 ; CHECK-NEXT:         Name:            .sec1<br>
 ; CHECK-NEXT:         Alignment:       8<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           2<br>
 ; CHECK-NEXT:         Name:            .sec2<br>
 ; CHECK-NEXT:         Alignment:       8<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT: ...<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/init-fini-array.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/init-fini-array.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/init-fini-array.<wbr>ll?rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/init-fini-array.ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/init-fini-array.ll Wed Dec 13 14:02:25 2017<br>
@@ -92,14 +92,14 @@ declare void @func2()<br>
 ; CHECK-NEXT:       - Index:           0<br>
 ; CHECK-NEXT:         Name:            .data.global1<br>
 ; CHECK-NEXT:         Alignment:       8<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           1<br>
 ; CHECK-NEXT:         Name:            .init_array<br>
 ; CHECK-NEXT:         Alignment:       4<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           2<br>
 ; CHECK-NEXT:         Name:            .fini_array<br>
 ; CHECK-NEXT:         Alignment:       4<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT: ...<br>
<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/unnamed-data.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/unnamed-data.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/unnamed-data.ll?<wbr>rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/unnamed-data.ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/unnamed-data.ll Wed Dec 13 14:02:25 2017<br>
@@ -81,24 +81,24 @@<br>
 ; CHECK-NEXT:     DataSize:        28<br>
 ; CHECK-NEXT:     SymbolInfo:<br>
 ; CHECK-NEXT:       - Name:            .L.str1<br>
-; CHECK-NEXT:         Flags:           2<br>
+; CHECK-NEXT:         Flags:           [ BINDING_LOCAL ]<br>
 ; CHECK-NEXT:       - Name:            .L.str2<br>
-; CHECK-NEXT:         Flags:           2<br>
+; CHECK-NEXT:         Flags:           [ BINDING_LOCAL ]<br>
 ; CHECK-NEXT:     SegmentInfo:<br>
 ; CHECK-NEXT:       - Index:       0<br>
 ; CHECK-NEXT:         Name:        .rodata..L.str1<br>
 ; CHECK-NEXT:         Alignment:   1<br>
-; CHECK-NEXT:         Flags:       0<br>
+; CHECK-NEXT:         Flags:       [ ]<br>
 ; CHECK-NEXT:       - Index:       1<br>
 ; CHECK-NEXT:         Name:        .rodata..L.str2<br>
 ; CHECK-NEXT:         Alignment:   1<br>
-; CHECK-NEXT:         Flags:       0<br>
+; CHECK-NEXT:         Flags:       [ ]<br>
 ; CHECK-NEXT:       - Index:       2<br>
 ; CHECK-NEXT:         Name:        .data.a<br>
 ; CHECK-NEXT:         Alignment:   8<br>
-; CHECK-NEXT:         Flags:       0<br>
+; CHECK-NEXT:         Flags:       [ ]<br>
 ; CHECK-NEXT:       - Index:       3<br>
 ; CHECK-NEXT:         Name:        .data.b<br>
 ; CHECK-NEXT:         Alignment:   8<br>
-; CHECK-NEXT:         Flags:       0<br>
+; CHECK-NEXT:         Flags:       [ ]<br>
 ; CHECK_NEXT:   ...<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/visibility.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/visibility.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/visibility.ll?rev=<wbr>320642&r1=320641&r2=320642&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/visibility.ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/visibility.ll Wed Dec 13 14:02:25 2017<br>
@@ -19,5 +19,5 @@ entry:<br>
 ; CHECK-NEXT:     DataSize:        0<br>
 ; CHECK-NEXT:     SymbolInfo:<br>
 ; CHECK-NEXT:       - Name:            hiddenVis<br>
-; CHECK-NEXT:         Flags:           4<br>
+; CHECK-NEXT:         Flags:           [ VISIBILITY_HIDDEN ]<br>
 ; CHECK-NEXT: ...<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/weak-alias.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/weak-alias.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/weak-alias.ll?rev=<wbr>320642&r1=320641&r2=320642&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/weak-alias.ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/weak-alias.ll Wed Dec 13 14:02:25 2017<br>
@@ -109,22 +109,22 @@ entry:<br>
 ; CHECK-NEXT:     DataSize:        12<br>
 ; CHECK-NEXT:     SymbolInfo:<br>
 ; CHECK-NEXT:       - Name:            call_alias<br>
-; CHECK-NEXT:         Flags:           4<br>
+; CHECK-NEXT:         Flags:           [ VISIBILITY_HIDDEN ]<br>
 ; CHECK-NEXT:       - Name:            foo<br>
-; CHECK-NEXT:         Flags:           4<br>
+; CHECK-NEXT:         Flags:           [ VISIBILITY_HIDDEN ]<br>
 ; CHECK-NEXT:       - Name:            foo_alias<br>
-; CHECK-NEXT:         Flags:           5<br>
+; CHECK-NEXT:         Flags:           [ BINDING_WEAK, VISIBILITY_HIDDEN ]<br>
 ; CHECK-NEXT:       - Name:            bar_alias<br>
-; CHECK-NEXT:         Flags:           5<br>
+; CHECK-NEXT:         Flags:           [ BINDING_WEAK, VISIBILITY_HIDDEN ]<br>
 ; CHECK-NEXT:     SegmentInfo:<br>
 ; CHECK-NEXT:       - Index:           0<br>
 ; CHECK-NEXT:         Name:            .data.bar<br>
 ; CHECK-NEXT:         Alignment:       8<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT:       - Index:           1<br>
 ; CHECK-NEXT:         Name:            .data.bar_alias_address<br>
 ; CHECK-NEXT:         Alignment:       8<br>
-; CHECK-NEXT:         Flags:           0<br>
+; CHECK-NEXT:         Flags:           [ ]<br>
 ; CHECK-NEXT: ...<br>
<br>
 ; CHECK-SYMS: SYMBOL TABLE:<br>
<br>
Modified: llvm/trunk/test/MC/<wbr>WebAssembly/weak.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/WebAssembly/weak.ll?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/MC/<wbr>WebAssembly/weak.ll?rev=<wbr>320642&r1=320641&r2=320642&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/MC/<wbr>WebAssembly/weak.ll (original)<br>
+++ llvm/trunk/test/MC/<wbr>WebAssembly/weak.ll Wed Dec 13 14:02:25 2017<br>
@@ -33,7 +33,7 @@ entry:<br>
 ; CHECK-NEXT:     DataSize:        0<br>
 ; CHECK-NEXT:     SymbolInfo:<br>
 ; CHECK-NEXT:       - Name:            weak_external_data<br>
-; CHECK-NEXT:         Flags:           1<br>
+; CHECK-NEXT:         Flags:           [ BINDING_WEAK ]<br>
 ; CHECK-NEXT:       - Name:            weak_function<br>
-; CHECK-NEXT:         Flags:           5<br>
+; CHECK-NEXT:         Flags:           [ BINDING_WEAK, VISIBILITY_HIDDEN ]<br>
 ; CHECK-NEXT: ...<br>
<br>
Modified: llvm/trunk/test/ObjectYAML/<wbr>wasm/elem_section.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/wasm/elem_section.yaml?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ObjectYAML/wasm/elem_section.<wbr>yaml?rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ObjectYAML/<wbr>wasm/elem_section.yaml (original)<br>
+++ llvm/trunk/test/ObjectYAML/<wbr>wasm/elem_section.yaml Wed Dec 13 14:02:25 2017<br>
@@ -7,7 +7,7 @@ Sections:<br>
     Tables:<br>
       - ElemType:          ANYFUNC<br>
         Limits:<br>
-          Flags:           0x00000001<br>
+          Flags:           [ HAS_MAX ]<br>
           Initial:         0x00000010<br>
           Maximum:         0x00000011<br>
   - Type:            ELEM<br>
<br>
Modified: llvm/trunk/test/ObjectYAML/<wbr>wasm/import_section.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/wasm/import_section.yaml?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ObjectYAML/wasm/import_<wbr>section.yaml?rev=320642&r1=<wbr>320641&r2=320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ObjectYAML/<wbr>wasm/import_section.yaml (original)<br>
+++ llvm/trunk/test/ObjectYAML/<wbr>wasm/import_section.yaml Wed Dec 13 14:02:25 2017<br>
@@ -23,7 +23,7 @@ Sections:<br>
         Field:           imported_memory<br>
         Kind:            MEMORY<br>
         Memory:<br>
-          Flags:           0x00000001<br>
+          Flags:           [ HAS_MAX ]<br>
           Initial:         0x00000010<br>
           Maximum:         0x00000011<br>
       - Module:          foo<br>
@@ -32,7 +32,7 @@ Sections:<br>
         Table:<br>
           ElemType:      ANYFUNC<br>
           Limits:<br>
-            Flags:           0x00000001<br>
+            Flags:           [ HAS_MAX ]<br>
             Initial:         0x00000020<br>
             Maximum:         0x00000022<br>
 ...<br>
@@ -55,7 +55,7 @@ Sections:<br>
 # CHECK:         Field:           imported_memory<br>
 # CHECK:         Kind:            MEMORY<br>
 # CHECK:         Memory:<br>
-# CHECK:           Flags:           0x00000001<br>
+# CHECK:           Flags:           [ HAS_MAX ]<br>
 # CHECK:           Initial:         0x00000010<br>
 # CHECK:           Maximum:         0x00000011<br>
 # CHECK:       - Module:          foo<br>
@@ -64,7 +64,7 @@ Sections:<br>
 # CHECK:         Table:<br>
 # CHECK:           ElemType:      ANYFUNC<br>
 # CHECK:           Limits:<br>
-# CHECK:             Flags:           0x00000001<br>
+# CHECK:             Flags:           [ HAS_MAX ]<br>
 # CHECK:             Initial:         0x00000020<br>
 # CHECK:             Maximum:         0x00000022<br>
 # CHECK: ...<br>
<br>
Modified: llvm/trunk/test/ObjectYAML/<wbr>wasm/linking_section.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/wasm/linking_section.yaml?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ObjectYAML/wasm/linking_<wbr>section.yaml?rev=320642&r1=<wbr>320641&r2=320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ObjectYAML/<wbr>wasm/linking_section.yaml (original)<br>
+++ llvm/trunk/test/ObjectYAML/<wbr>wasm/linking_section.yaml Wed Dec 13 14:02:25 2017<br>
@@ -31,15 +31,15 @@ Sections:<br>
     DataSize:        999<br>
     SymbolInfo:<br>
       - Name:            bar<br>
-        Flags:           1<br>
+        Flags:           [ BINDING_WEAK ]<br>
     SegmentInfo:<br>
       - Index:       0<br>
         Alignment:   4<br>
-        Flags:       0<br>
+        Flags:       [ ]<br>
         Name:        mydata<br>
       - Index:       1<br>
         Alignment:   2<br>
-        Flags:       1<br>
+        Flags:       [ ]<br>
         Name:        moredata<br>
 ...<br>
 # CHECK:       - Type:            CUSTOM<br>
@@ -47,14 +47,14 @@ Sections:<br>
 # CHECK-NEXT:    DataSize:        999<br>
 # CHECK-NEXT:    SymbolInfo:<br>
 # CHECK-NEXT:      - Name:            bar<br>
-# CHECK-NEXT:        Flags:           1<br>
+# CHECK-NEXT:        Flags:           [ BINDING_WEAK ]<br>
 # CHECK-NEXT:    SegmentInfo:<br>
 # CHECK-NEXT:      - Index:           0<br>
 # CHECK-NEXT:        Name:            mydata<br>
 # CHECK-NEXT:        Alignment:       4<br>
-# CHECK-NEXT:        Flags:           0<br>
+# CHECK-NEXT:        Flags:           [ ]<br>
 # CHECK-NEXT:      - Index:           1<br>
 # CHECK-NEXT:        Name:            moredata<br>
 # CHECK-NEXT:        Alignment:       2<br>
-# CHECK-NEXT:        Flags:           1<br>
+# CHECK-NEXT:        Flags:           [ ]<br>
 # CHECK-NEXT: ...<br>
<br>
Modified: llvm/trunk/test/ObjectYAML/<wbr>wasm/memory_section.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/wasm/memory_section.yaml?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ObjectYAML/wasm/memory_<wbr>section.yaml?rev=320642&r1=<wbr>320641&r2=320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ObjectYAML/<wbr>wasm/memory_section.yaml (original)<br>
+++ llvm/trunk/test/ObjectYAML/<wbr>wasm/memory_section.yaml Wed Dec 13 14:02:25 2017<br>
@@ -5,7 +5,7 @@ FileHeader:<br>
 Sections:<br>
   - Type:            MEMORY<br>
     Memories:<br>
-      - Flags:           0x00000001<br>
+      - Flags:           [ HAS_MAX ]<br>
         Initial:         0x00000002<br>
         Maximum:         0x000000FF<br>
       - Initial:         0x00000003<br>
@@ -16,7 +16,7 @@ Sections:<br>
 # CHECK: Sections:<br>
 # CHECK:   - Type:            MEMORY<br>
 # CHECK:     Memories:<br>
-# CHECK:       - Flags:            0x00000001<br>
+# CHECK:       - Flags:            [ HAS_MAX ]<br>
 # CHECK:         Initial:          0x00000002<br>
 # CHECK:         Maximum:          0x000000FF<br>
 # CHECK:       - Initial:          0x00000003<br>
<br>
Modified: llvm/trunk/test/ObjectYAML/<wbr>wasm/table_section.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/wasm/table_section.yaml?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ObjectYAML/wasm/table_section.<wbr>yaml?rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ObjectYAML/<wbr>wasm/table_section.yaml (original)<br>
+++ llvm/trunk/test/ObjectYAML/<wbr>wasm/table_section.yaml Wed Dec 13 14:02:25 2017<br>
@@ -7,7 +7,7 @@ Sections:<br>
     Tables:<br>
       - ElemType:        ANYFUNC<br>
         Limits:<br>
-          Flags:           0x00000001<br>
+          Flags:           [ HAS_MAX ]<br>
           Initial:         0x00000010<br>
           Maximum:         0x00000011<br>
 ...<br>
@@ -19,7 +19,7 @@ Sections:<br>
 # CHECK:    Tables:<br>
 # CHECK:      - ElemType:        ANYFUNC<br>
 # CHECK:        Limits:<br>
-# CHECK:          Flags:           0x00000001<br>
+# CHECK:          Flags:           [ HAS_MAX ]<br>
 # CHECK:          Initial:         0x00000010<br>
 # CHECK:          Maximum:         0x00000011<br>
 # CHECK: ...<br>
<br>
Modified: llvm/trunk/test/ObjectYAML/<wbr>wasm/weak_symbols.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ObjectYAML/wasm/weak_symbols.yaml?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>ObjectYAML/wasm/weak_symbols.<wbr>yaml?rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/ObjectYAML/<wbr>wasm/weak_symbols.yaml (original)<br>
+++ llvm/trunk/test/ObjectYAML/<wbr>wasm/weak_symbols.yaml Wed Dec 13 14:02:25 2017<br>
@@ -29,9 +29,9 @@ Sections:<br>
     DataSize:        10<br>
     SymbolInfo:<br>
       - Name:            function_export<br>
-        Flags:           1<br>
+        Flags:           [ BINDING_WEAK ]<br>
       - Name:            global_export<br>
-        Flags:           1<br>
+        Flags:           [ BINDING_WEAK ]<br>
 ...<br>
 # CHECK: --- !WASM<br>
 # CHECK: FileHeader:<br>
@@ -50,6 +50,6 @@ Sections:<br>
 # CHECK:     DataSize:        10<br>
 # CHECK:     SymbolInfo:<br>
 # CHECK:       - Name:            function_export<br>
-# CHECK:         Flags:           1<br>
+# CHECK:         Flags:           [ BINDING_WEAK ]<br>
 # CHECK:       - Name:            global_export<br>
-# CHECK:         Flags:           1<br>
+# CHECK:         Flags:           [ BINDING_WEAK ]<br>
<br>
Modified: llvm/trunk/test/tools/llvm-nm/<wbr>wasm/weak-symbols.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-nm/wasm/weak-symbols.yaml?rev=320642&r1=320641&r2=320642&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/tools/<wbr>llvm-nm/wasm/weak-symbols.<wbr>yaml?rev=320642&r1=320641&r2=<wbr>320642&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/tools/llvm-nm/<wbr>wasm/weak-symbols.yaml (original)<br>
+++ llvm/trunk/test/tools/llvm-nm/<wbr>wasm/weak-symbols.yaml Wed Dec 13 14:02:25 2017<br>
@@ -55,13 +55,13 @@ Sections:<br>
     DataSize:        0<br>
     SymbolInfo:<br>
       - Name:            weak_global_func<br>
-        Flags:           1<br>
+        Flags:           [ BINDING_WEAK ]<br>
       - Name:            weak_global_data<br>
-        Flags:           1<br>
+        Flags:           [ BINDING_WEAK ]<br>
       - Name:            weak_import_func<br>
-        Flags:           1<br>
+        Flags:           [ BINDING_WEAK ]<br>
       - Name:            weak_import_data<br>
-        Flags:           1<br>
+        Flags:           [ BINDING_WEAK ]<br>
<br>
 # CHECK: 00000400 W weak_global_data<br>
 # CHECK: 00000004 W weak_global_func<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>