<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Galina,<div class=""><br class=""></div><div class="">I did a build with EXPENSIVE_CHECKS but this failure happens without my patch so it seems to be an existing issue.</div><div class=""><br class=""></div><div class="">Jessica, could you take a look?</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Amara<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 11, 2017, at 10:08 PM, Galina Kistanova <<a href="mailto:gkistanova@gmail.com" class="">gkistanova@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hello Amara,<br class=""><br class="">It looks like this commit broke a test on one of our builders:<br class=""><a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6693" class="">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6693</a><br class=""><br class="">. . .<br class="">Failing Tests (3):<br class=""> LLVM :: CodeGen/AArch64/machine-outliner.mir<br class="">. . .<br class=""><br class="">Please have a look?<br class="">The builder was already red and did not send notifications.<br class=""><br class="">Thanks<br class=""><br class="">Galina<br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Dec 11, 2017 at 8:58 AM, Amara Emerson via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aemerson<br class="">
Date: Mon Dec 11 08:58:29 2017<br class="">
New Revision: 320388<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=320388&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=320388&view=rev</a><br class="">
Log:<br class="">
[GlobalISel] Disable GISel for big endian.<br class="">
<br class="">
This is due to PR26161 needing to be resolved before we can fix<br class="">
big endian bugs like PR35359. The work to split aggregates into smaller LLTs<br class="">
instead of using one large scalar will take some time, so in the mean time<br class="">
we'll fall back to SDAG.<br class="">
<br class="">
Some ARM BE tests xfailed for now as a result.<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D40789" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D40789</a><br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/CodeGen/<wbr class="">GlobalISel/IRTranslator.cpp<br class="">
llvm/trunk/test/CodeGen/<wbr class="">AArch64/GlobalISel/arm64-<wbr class="">fallback.ll<br class="">
llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-irtranslator.ll<br class="">
llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-param-lowering.<wbr class="">ll<br class="">
<br class="">
Modified: llvm/trunk/lib/CodeGen/<wbr class="">GlobalISel/IRTranslator.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/IRTranslator.cpp?rev=320388&r1=320387&r2=320388&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/lib/<wbr class="">CodeGen/GlobalISel/<wbr class="">IRTranslator.cpp?rev=320388&<wbr class="">r1=320387&r2=320388&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/CodeGen/<wbr class="">GlobalISel/IRTranslator.cpp (original)<br class="">
+++ llvm/trunk/lib/CodeGen/<wbr class="">GlobalISel/IRTranslator.cpp Mon Dec 11 08:58:29 2017<br class="">
@@ -1253,6 +1253,15 @@ bool IRTranslator::<wbr class="">runOnMachineFunction(<br class="">
<br class="">
assert(PendingPHIs.empty() && "stale PHIs");<br class="">
<br class="">
+ if (!DL->isLittleEndian()) {<br class="">
+ // Currently we don't properly handle big endian code.<br class="">
+ OptimizationRemarkMissed R("gisel-irtranslator", "GISelFailure",<br class="">
+ MF->getFunction()-><wbr class="">getSubprogram(),<br class="">
+ &MF->getFunction()-><wbr class="">getEntryBlock());<br class="">
+ R << "unable to translate in big endian mode";<br class="">
+ reportTranslationError(*MF, *TPC, *ORE, R);<br class="">
+ }<br class="">
+<br class="">
// Release the per-function state when we return, whether we succeeded or not.<br class="">
auto FinalizeOnReturn = make_scope_exit([this]() { finalizeFunction(); });<br class="">
<br class="">
<br class="">
Modified: llvm/trunk/test/CodeGen/<wbr class="">AArch64/GlobalISel/arm64-<wbr class="">fallback.ll<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll?rev=320388&r1=320387&r2=320388&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/test/<wbr class="">CodeGen/AArch64/GlobalISel/<wbr class="">arm64-fallback.ll?rev=320388&<wbr class="">r1=320387&r2=320388&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/test/CodeGen/<wbr class="">AArch64/GlobalISel/arm64-<wbr class="">fallback.ll (original)<br class="">
+++ llvm/trunk/test/CodeGen/<wbr class="">AArch64/GlobalISel/arm64-<wbr class="">fallback.ll Mon Dec 11 08:58:29 2017<br class="">
@@ -3,6 +3,7 @@<br class="">
; RUN: llc -O0 -global-isel -global-isel-abort=2 -pass-remarks-missed='gisel*' -verify-machineinstrs %s -o %t.out 2> %t.err<br class="">
; RUN: FileCheck %s --check-prefix=FALLBACK-WITH-<wbr class="">REPORT-OUT < %t.out<br class="">
; RUN: FileCheck %s --check-prefix=FALLBACK-WITH-<wbr class="">REPORT-ERR < %t.err<br class="">
+; RUN: not llc -global-isel -mtriple aarch64_be %s -o - 2>&1 | FileCheck %s --check-prefix=BIG-ENDIAN<br class="">
; This file checks that the fallback path to selection dag works.<br class="">
; The test is fragile in the sense that it must be updated to expose<br class="">
; something that fails with global-isel.<br class="">
@@ -12,6 +13,8 @@<br class="">
target datalayout = "e-m:o-i64:64-i128:128-n32:64-<wbr class="">S128"<br class="">
target triple = "aarch64--"<br class="">
<br class="">
+; BIG-ENDIAN: unable to translate in big endian mode<br class="">
+<br class="">
; We use __fixunstfti as the common denominator for __fixunstfti on Linux and<br class="">
; ___fixunstfti on iOS<br class="">
; ERROR: unable to lower arguments: i128 (i128)* (in function: ABIi128)<br class="">
<br class="">
Modified: llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-irtranslator.ll<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-irtranslator.ll?rev=320388&r1=320387&r2=320388&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/test/<wbr class="">CodeGen/ARM/GlobalISel/arm-<wbr class="">irtranslator.ll?rev=320388&r1=<wbr class="">320387&r2=320388&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-irtranslator.ll (original)<br class="">
+++ llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-irtranslator.ll Mon Dec 11 08:58:29 2017<br class="">
@@ -1,5 +1,6 @@<br class="">
; RUN: llc -mtriple arm-unknown -mattr=+vfp2,+v4t -global-isel -stop-after=irtranslator -verify-machineinstrs %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=LITTLE<br class="">
-; RUN: llc -mtriple armeb-unknown -mattr=+vfp2,+v4t -global-isel -stop-after=irtranslator -verify-machineinstrs %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=BIG<br class="">
+; RUN: llc -mtriple armeb-unknown -mattr=+vfp2,+v4t -global-isel -global-isel-abort=0 -stop-after=irtranslator -verify-machineinstrs %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=BIG<br class="">
+; XFAIL: armeb<br class="">
<br class="">
define void @test_void_return() {<br class="">
; CHECK-LABEL: name: test_void_return<br class="">
<br class="">
Modified: llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-param-lowering.<wbr class="">ll<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-param-lowering.ll?rev=320388&r1=320387&r2=320388&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/test/<wbr class="">CodeGen/ARM/GlobalISel/arm-<wbr class="">param-lowering.ll?rev=320388&<wbr class="">r1=320387&r2=320388&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-param-lowering.<wbr class="">ll (original)<br class="">
+++ llvm/trunk/test/CodeGen/ARM/<wbr class="">GlobalISel/arm-param-lowering.<wbr class="">ll Mon Dec 11 08:58:29 2017<br class="">
@@ -1,5 +1,6 @@<br class="">
; RUN: llc -mtriple arm-unknown -mattr=+vfp2,+v4t -global-isel -stop-after=irtranslator -verify-machineinstrs %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=LITTLE<br class="">
-; RUN: llc -mtriple armeb-unknown -mattr=+vfp2,+v4t -global-isel -stop-after=irtranslator -verify-machineinstrs %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=BIG<br class="">
+; RUN: llc -mtriple armeb-unknown -mattr=+vfp2,+v4t -global-isel -global-isel-abort=0 -stop-after=irtranslator -verify-machineinstrs %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=BIG<br class="">
+; XFAIL: armeb<br class="">
<br class="">
declare arm_aapcscc i32* @simple_reg_params_target(i32, i32*)<br class="">
<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>